Ref LSP - compliance check

abhinavv245 commented 1 year ago

Flow 1

Incorrect Flow as per context/timestamps - (on_update,on_confirm,search,on_search,init,on_init,confirm,on_status,status,update)

/search

reverse geocoding of start and end gps cordinates shows a different area code
city code does not match fulfillment start location

/on_search

how is motorable distance calculated(fulfillments/tags/distance) as the gps for start and end in /search is same
RTO quote should be provided in /items for each category
bpp/providers/categories/time/timestamp should be referring to date (vis-a-vis Context.timestamp) for which this TAT is provided (same day for Immediate Delivery / SDD, next day for NDD, appropriate date for other categories)

/init

context/city code should not change in /init and onwards
Item Id 'I1' does not exist in /on_search (LSP should send NACK)
start/location/gps does not match start location in search
end/location/gps does not match end location in search
billing/created_at does not match context timestamp - \"2023-08-22T12:10:10.122Z\"
billing/updated_at does not match context timestamp - \"2023-08-22T12:10:10.122Z\"

/on_init

provider_location/id should be the one provided in /on_search
@ondc/org/title_type in /items should be one of the allowed values (delivery, tax, rto, diff)

/confirm

order/provider/id mismatches in /init and /confirm
end/location/gps mismatches in /init and /confirm
@ondc/org/linked_order/order/weight has changed in /confirm
address/name mismatches in /billing in /init and /confirm
address/locality mismatches in /billing in /init and /confirm
tax_number mismatches in /billing in /init and /confirm
created_at mismatches in /billing in /init and /confirm
updated_at mismatches in /billing in /init and /confirm
message/order/created_at does not match context timestamp - \"2023-08-22T12:10:20.122Z\

/on_confirm

order/id mismatches in /confirm and /on_confirm
order/created_at mismatches in /confirm and /on_confirm

/update

@ondc/org/ebnexpirydate cannot be past dated

/on_update

ready_to_ship = no in /update, how is fulfillment state 'Order-picked-up'

/on_status

order/id mismatches in /confirm and /on_status
'Agent-assigned' is not a valid Order state
provider id mismatches in /init and /on_status
quote/breakup must have required property '@ondc/org/item_id' and '@ondc/org/title_type',
'_id' is not a valid attribute at multiple places (billing/address,quote/breakup,fulfillments/location, etc)
unsolicited /on_status calls with fulfillment states upto Order delivery should be provided (Order-picked-up,Out-for-delivery,Order-delivered)

abhinavv245 commented 1 year ago

Flow 1 and 2

/search

"@ondc/org/collection_amount" is required only for payment type 'ON-FULFILLMENT' , not needed for 'POST-FULFILLMENT' (LSP should send NACK in case not provided)

/on_search

RTO line item for 'Next Day Delivery' is missing in /items
price for 'Next Day Delivery' is 0, is this intentional?
bpp/providers/locations to be provided only for cases where shipment has to be dropped off at LSP location; not required for P2P

/init

start/location/gps does not match start location in search

/on_init

payment/type mismatches in /search and /on_init
check for rider availability is missing in /fulfillments/tags

/confirm

order/items/time/duration (average pickup time) is different from what was quoted earlier in /on_search, LSP can NACK /confirm with error code 60008 (how is this being handled)

/on_status

Message Id should be different for all unsolicited /on_status responses
order/tags should be removed

Flow 3

similar issues as above
Incorrect Flow as per context/timestamps - (search,on_search,init,update,on_init,confirm,on_update,on_status,on_confirm,on_cancel)
Flow showcasing how P2H2P shipments are being handled should be provided (refer Test case scenarios, Logistics Flow 2)

/on_update

Message ID should be same as /update: "ecd66045-3bc7-4ea6-9a9c-1c30b662f1"
why is fulfillment state 'Agent-Assigned' in /on_update
empty tags array to be removed

/on_status

on_status_RTO_initiated is not required as it is already initiated in /on_cancel
In on_status_RTO_delivered, fulfillment state of type 'Delivery' should be cancelled first, another fulfillment of type RTO needs to be added with its fulfillment state being 'RTO-delivered'

abhinavv245 commented 1 year ago

Flow 2

context/timestamp difference between /action and /on_action apis should be within 1 second

/confirm

start/instructions/code should be one of the allowed values ("1" - buyer contact no (for self-pickup), "2" - merchant order no, "3" - other pickup confirmation code, "4" - OTP) (LSP should send NACK in case of schema errors)
dummy values should be avoided ("value of PCC","value of DCC")
order/items/time/duration is different from what was quoted earlier in /on_search (item level duration supersedes category level duration), how is this being handled?

/on_confirm

@ondc/org/linked_order is missing in /order

Flow 3

similar issues as above

/on_status

@ondc/org/item_id and @ondc/org/title_type are missing in quote/breakup (out-for-delivery and order-picked-up)
item id (@ondc/org/item_id) for rto line item in quote/breakup should be the same provided in /on_search

/on_update

why is fulfillment state 'Agent-Assigned' in /on_update (this response is triggered after 12 seconds, however response time should be within 1 second)

/on_cancel

fulfillment state will also be 'Cancelled'

abhinavv245 commented 1 year ago

Flow 1 and 2

/on_search

parent_item_id for item with id 'rto' should be the id of the parent item ('express') in bpp/providers/items

/on_init

check for rider availability is missing in /fulfillments/tags
'collected_by' is missing in payment object
@ondc/org/item_id in quote/breakup should match with the items/id provided in /on_search (in /on_init and onwards)

/confirm

bpp_id and bpp_uri in context cannot not change
auto RTS (ready_to_ship) flow is missing

/update

order/updated_at cannot be future dated and should match context/timestamp

/on_update

bap_terms and bpp_terms tags are not required in order in /on_update
'collected_by' is missing in payment object
'ready_to_ship' and 'rto_action' tags are not required in /fulfillments in /on_update

/on_status

'ready_to_ship' and 'rto_action' tags are not required in /fulfillments in /on_update
'collected_by' is missing in payment object
how were settlement details captured in /on_status_order_delivered as they were not provided by the buyer
status is missing in payment object
time/timestamp should be provided in payment object for delivery orders when order state is "Completed"

Flow 3

similar issues as above

/on_cancel

incorrect context/action
why was order/cancellation removed (it is a required property)
empty tags to be removed withy fulfillment type rto
ready_to_ship and rto_action tags are not required in fulfillment with type delivery

@gajendrawits

tanya-ondc commented 1 year ago

Flow1 & 2

/on_init:

Can you confirm if cancellation charges are being dynamically defined? I see the forward shipment charges as 57 and cancellation charges as 50 (Agent-Assigned), 100 (Order-Picked-up and Out-for-delivery). Also, these values are same picked up from examples.
In case of Prepaid order (payment type is ON-ORDER), can LSP send settlement details?

@gajendrawits

gajendrawits commented 1 year ago

@tanya-ondc

on_init: • Can you confirm if cancellation charges are being dynamically defined? I see the forward shipment charges as 57 and cancellation charges as 50 (Agent-Assigned), 100 (Order-Picked-up and Out-for-delivery). Also, these values are same picked up from examples.

Yes the cancellation charges are static, the max dynamism that can be set is setting multipliers on the calculated quote which can make the charges dynamic per order. (This can be made incremental in the upcoming changes)

• In case of Prepaid order (payment type is ON-ORDER), can LSP send settlement details?

Under our understanding we have added the solution for ON-FULLFILLMENT deliveries. Since it was not clear from the contract how the ON-ORDER solution has to be catered to, we have not added that yet. We can add a solution providing settlement details in the ON-ORDER solution on your call.

abhinavv245 commented 1 year ago

P2H2P Flow

/on_search

/on_search/message/catalog/bpp/providers/categories/time/duration must match format "duration"
/on_search/message/catalog/bpp/providers/items/time/duration must match format "duration"

/init

/init/context/transaction_id Transaction ID should be same across the transaction: "17e9423f-c5ff-4efe-a95c-d331289475fb"
/init/message/order/fulfillments/start/location/gps does not match start location in search
/init/message/order/fulfillments/end/location/gps does not match end location in search
Fulfillment id '27acc85d-2b0e-42fa-b1dd-a6655bed19fd' for item with id 'Express' does not match with the catalog provided in /on_search

/on_init

/on_init/context/transaction_id Transaction ID should be same across the transaction: "17e9423f-c5ff-4efe-a95c-d331289475fb"
/on_init/message/order/fulfillments/start/location/gps does not match start location in search
/on_init/message/order/fulfillments/end/location/gps does not match end location in search

/confirm

/confirm/message/order/quote/breakup/1/@ondc/org/title_type must be equal to one of the allowed values (delivery,rto,reverseqc)
/confirm/message/order/quote object mismatches in /on_init and /confirm.
/confirm/message/order/billing/created_at mismatches in /billing in /init and /confirm
/confirm/message/order/billing/updated_at mismatches in /billing in /init and /confirm
/confirm/message/order/payment must have required property 'collected_by'

/on_confirm

/on_confirm/message/order/provider/locations/id must be equal to constant (651413d55665fa7b696c3fcb)
/on_confirm/message/order/quote/breakup/1/@ondc/org/title_type must be equal to one of the allowed values (delivery,rto,reverseqc)
/on_confirm/message/order/payment must have required property 'collected_by'

/update

/update/message/order/@ondc/org/linked_order must have required property 'provider'
Pickup code is not required for P2H2P shipments as shipping label is provided by LSP

/on_update

/on_update/message/order/fulfillments/start/instructions must have required property 'image' (required for P2H2P shipments)
/on_update/message/order/payment must have required property 'collected_by'
AWB No (@ondc/org/awb_no) is required in /fulfillments for P2H2P shipments (may be provided in /confirm or /update by logistics buyer or /on_confirm or /on_update by LSP)

/on_status

/on_status/5/message/order must have required property 'state'
/on_status/5 fulfillment state is not a valid enum (should be Order-delivered)
/on_status/message/order/provider/locations/id mismatches between /init and /on_status
/on_status/message/order/payment must have required property 'collected_by'
/on_status/message/order/payment/@ondc/org/collection_amount must be equal to constant (300)
payment status should be 'PAID' once order is delivered and timestamp should be added for the same.
Pickup timestamp (fulfillments/start/time/timestamp) cannot change for fulfillment state - Out-for-delivery

@gajendrawits

abhinavv245 commented 1 year ago

P2H2P Flow

Transaction ID should be same across the transaction

/on_search

bpp/providers/categories/time/timestamp should be referring to date (vis-a-vis Context.timestamp) for which this TAT is provided (same day for Immediate Delivery / SDD, next day for NDD, appropriate date for other categories)
Average time to pickup (fulfillments/star/time/duration) should be realistic (why is kept equal to delivery TAT)
motorable distance is not recorded accurately (fulfillments/tags)
bpp/providers/items/time/timestamp for RTO item, should be referring to date (vis-a-vis Context.timestamp) for which this TAT is provided (same day for Immediate Delivery / SDD, next day for NDD, appropriate date for other categories)

/confirm

/confirm/message/order/fulfillments/0/@ondc/org/awb_no should be 11-16 digits (LSP should handle it)
order/items/time/timestamp is different from what was quoted earlier in /on_search, LSP should NACK /confirm with error code 60008 (how is this being handled)

/on_update

/on_update/message/order/fulfillments/0 must have required property 'id',

@gajendrawits

abhinavv245 commented 1 year ago

P2H2P Flow

/confirm

average pickup time (fulfillments/start/time/duration) is changed in/confirm (how is LSP handling this)

/on_search

bpp/providers/items/time/timestamp for RTO item, should be referring to date (vis-a-vis Context.timestamp) for which this TAT is provided (same day for Immediate Delivery / SDD, next day for NDD, appropriate date for other categories)

@gajendrawits

abhinavv245 commented 1 year ago

P2H2P Flow

context/timestamp difference between /action and /on_action apis should be within 1 second

/on_search

context/bap_id does not match with /search
distance is not required for P2H2P shipments in fulfillment/tags
why is bpp/providers/locations provided (mandatory only for cases where shipment has to be dropped off at LSP location)

@gajendrawits

abhinavv245 commented 1 year ago

P2H2P Flow

/confirm (and onwards)

item timestamp does not match with the one provided in /on_search (LSP can send NACK)
/confirm/0/message/order/fulfillments/0/start/location/gps does not match start location in search (how is LSP handling this)

/on_update

AWB No (@ondc/org/awb_no) is required in /fulfillments for P2H2P shipments (may be provided in /confirm or /update by logistics buyer or /on_confirm or /on_update by LSP)
Shipping label (/start/instructions/images) is required for P2H2P shipments

@gajendrawits

tanya-ondc commented 1 year ago

The logs looks good now. @gajendrawits

ONDC-Official / v1.2.0-logs