search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 240 forks source link

GlobalLinker (SA: RET10/12/13/14/15/16/18) - compliance check #805

Closed sahil-ondc closed 1 month ago

sahil-ondc commented 6 months ago

RET10

Flow 1

on_search_full_catalog

on_search_inc_catalog

Flow 3

on_select (out-of-stock)

Other Flows

select

on_select

on_init

confirm

on_confirm

on_status

Note

@Tjsvaradhan

Tjsvaradhan commented 6 months ago

@sahil-ondc

Can we connect on Google Meet? Need some clarifications on the feedback.

sahil-ondc commented 6 months ago

@Tjsvaradhan, Let me know the queries please

Tjsvaradhan commented 6 months ago

@sahil-ondc

We are not able to understand point form on_search_full_catalog - variants` should be provided in case of categories provided

Can you please explain this point?

Do you want to connect now?

sahil-ondc commented 6 months ago

@Tjsvaradhan As you have provided categories in your catalog, but you have not provided any variants based on those categories, my point is, that you provide some items with variants.

nishthamongaondc commented 6 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

Flow 2

on_confirm

on_status_picked

Flow 5

@Tjsvaradhan

Tjsvaradhan commented 6 months ago

@nishthamongaondc

GlobalLinker Response for the second bullet point in Flow-1:

This code is optional and hence we are not sending this. Refer to page: 43 of the API specifications:

(Ref.: 165) optional; unique code for item which will be in this format- "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 -others;

Response for Flow -2 on_confirm:

The same store (/fulfillments[0]/start/location/descriptor/name) is sent across all APIs. There is no change in the store name (descriptor). This feedback is incorrect.

item quote breakup prices for on_confirm is equalto the total price - This feedback is incorrect.**

The same store (/fulfillments[0]/start/location/descriptor/name) is sent across all APIs. There is no change in the store name (descriptor). This feedback is incorrect.

item quote breakup prices for on_confirm is equal to the total price - This feedback is incorrect.

Response for Flow-2, on_status (picked), first bullet point:

“message/order/id” generated and shared by the buyer APP and same is used by GlobalLinler (Seller APP) – we can’t change the order id at our end.

The above points were discussed / explained to Akshay on a 12 O’clock call (ONDC V1.2 Tech Community Call)

sahil-ondc commented 5 months ago

RET10

Flow 1

on_search

on_search_inc

Flow 2

select

on_init

on_confirm

on_status

Flow 3

on_select (out-for-stock)

Flow 4

on_cancel

Flow 5

Flow 6

on_update (return_initiated)

on_update (return_picked)

@Tjsvaradhan

Tjsvaradhan commented 5 months ago

Sahil,

Thanks for sharing the feedback on the Logs submitted by us (GlobalLinker) through the following PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1163.

However, we checked the feedback against the logs submitted.

Appreciate if we can quickly connect on a call and clarify the points. Please let me know your availability.

RET10 / GlobalLinker

(PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1163)

Flow 1

on_search

· /message/catalog/bpp/descriptor must have required property 'tags' (specifing np_type)

GlobalLinker: We are already sending ‘tags’ np_type in /on_search JOSN.

· /message/catalog/bpp/providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

GlobalLinker: We are already using the given Enums in items/quantity/unitized/measure/unit

· some of the category_id used in /message/catalog/bpp/providers/items has been deprecated https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0

GlobalLinker: We are NOT using deprecated categories (using ONLY the existing & new categories.)

on_search_inc

· /message/catalog/bpp~1providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

GlobalLinker: We are already using the given Enums in items/quantity/unitized/measure/unit

Flow 2

on_init

· @ondc/org/settlement_basis, @ondc/org/settlement_window, @ondc/org/withholding_amount should only be provided when SNP is collecting payment

GlobalLinker: We are not sending the above fields in the /on_init JSON (Currently, GlobalLinker does NOT collect payments from the buyers.)

on_confirm

· np_type is missing in message/order/tags/bpp_terms

GlobalLinker: We have sent np_type in message/order/tags/bpp_terms in /on_confirm JSON.

on_status

· packed, out-for-delivery states should be provided.

GlobalLinker: We currently support: Order-picked-up and Order-delivered states only.

Flow 3

on_select (out-for-stock)

· error/message should be as per API contract

GlobalLinker: We are already using the same error/message construct, including the error code, as given in the API contract.

Flow 5

· Invalid RTO Flow

GlobalLinker: We are NOT clear about this feedback – please provide more details.

Flow 6

on_update (return_initiated)

· @ondc/org/settlement_details should have refund settlement details of part-cancellation as it was done before

GlobalLinker: This field is not mentioned in the API contract document.

Other RETs: RET12 & 13

We have (Flow-1) submitted the logs for the above two domains too. Hope they comply with the API specifications (as per the API Contract document)

Thanks

On Fri, Mar 22, 2024 at 12:24 AM Sahil Sharma @.***> wrote:

RET10 Flow 1 on_search

on_search_inc

  • /message/catalog/bpp~1providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

Flow 2 select

  • /message/order/items/quantity/count must be integer
  • context/timestamp for /on_search api cannot be greater than to /select api

on_init

  • provider_tax_number and np_type should be provided in bpp_terms
  • @ondc/org/settlement_basis, @ondc/org/settlement_window, @ondc/org/withholding_amount should only be provided when SNP is collecting payment

on_confirm

  • store name /fulfillments[0]/start/location/descriptor/name can't change
  • np_type is missing in message/order/tags/bpp_terms

on_status

  • packed, out-for-delivery states should be provided

Flow 3 on_select (out-for-stock)

  • error/message should be as per API contract

Flow 4 on_cancel

  • quote_trail should be provided for all the cancelled items

Flow 5

  • Invalid RTO Flow

Flow 6

  • update settlement request is missing

on_update (return_initiated)

  • @ondc/org/settlement_details should have refund settlement details of part-cancellation as it was done before

on_update (return_picked)

  • invalid @ondc/org/provider_name provided as compare to on_select

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2013324103, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XHT6SGCKUYPNVV2VJLYZMUH7AVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGMZDIMJQGM . You are receiving this because you were mentioned.Message ID: @.***>

Tjsvaradhan commented 5 months ago

Sandeep,

We have submitted Logs again after making some corrections at our end, based on your last feedback. However, please refer to the email below that contains our responses to some of the feedback shared by you (as indicated these issues reported incorrectly).

Please refer to the new PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1189

(We have also included RET14, RET15 and RET18, in addition to RET10)

Kindly review and provide your confirmation.

Thanks

On Fri, Mar 22, 2024 at 1:24 PM Tjs Varadhan < @.***> wrote:

Sahil,

Thanks for sharing the feedback on the Logs submitted by us (GlobalLinker) through the following PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1163.

However, we checked the feedback against the logs submitted.

  • Many items as mentioned below are already complying with API Contract Specifications.

  • In one case, we need some clarifications.

Appreciate if we can quickly connect on a call and clarify the points. Please let me know your availability.

RET10 / GlobalLinker

(PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1163)

Flow 1

on_search

· /message/catalog/bpp/descriptor must have required property 'tags' (specifing np_type)

GlobalLinker: We are already sending ‘tags’ np_type in /on_search JOSN.

· /message/catalog/bpp/providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

GlobalLinker: We are already using the given Enums in items/quantity/unitized/measure/unit

· some of the category_id used in /message/catalog/bpp/providers/items has been deprecated

https://docs.google.com/spreadsheets/d/1APAvavF_BNbTA89benAlGtv0GuFvpn2b6XXi4lSdTTw/edit#gid=0

GlobalLinker: We are NOT using deprecated categories (using ONLY the existing & new categories.)

on_search_inc

· /message/catalog/bpp~1providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

GlobalLinker: We are already using the given Enums in items/quantity/unitized/measure/unit

Flow 2

on_init

· @ondc/org/settlement_basis, @ondc/org/settlement_window, @ondc/org/withholding_amount should only be provided when SNP is collecting payment

GlobalLinker: We are not sending the above fields in the /on_init JSON (Currently, GlobalLinker does NOT collect payments from the buyers.)

on_confirm

· np_type is missing in message/order/tags/bpp_terms

GlobalLinker: We have sent np_type in message/order/tags/bpp_terms in /on_confirm JSON.

on_status

· packed, out-for-delivery states should be provided.

GlobalLinker: We currently support: Order-picked-up and Order-delivered states only.

Flow 3

on_select (out-for-stock)

· error/message should be as per API contract

GlobalLinker: We are already using the same error/message construct, including the error code, as given in the API contract.

Flow 5

· Invalid RTO Flow

GlobalLinker: We are NOT clear about this feedback – please provide more details.

Flow 6

on_update (return_initiated)

· @ondc/org/settlement_details should have refund settlement details of part-cancellation as it was done before

GlobalLinker: This field is not mentioned in the API contract document.

Other RETs: RET12 & 13

We have (Flow-1) submitted the logs for the above two domains too. Hope they comply with the API specifications (as per the API Contract document)

Thanks

On Fri, Mar 22, 2024 at 12:24 AM Sahil Sharma @.***> wrote:

RET10 Flow 1 on_search

on_search_inc

  • /message/catalog/bpp~1providers/items/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)

Flow 2 select

  • /message/order/items/quantity/count must be integer
  • context/timestamp for /on_search api cannot be greater than to /select api

on_init

  • provider_tax_number and np_type should be provided in bpp_terms
  • @ondc/org/settlement_basis, @ondc/org/settlement_window, @ondc/org/withholding_amount should only be provided when SNP is collecting payment

on_confirm

  • store name /fulfillments[0]/start/location/descriptor/name can't change
  • np_type is missing in message/order/tags/bpp_terms

on_status

  • packed, out-for-delivery states should be provided

Flow 3 on_select (out-for-stock)

  • error/message should be as per API contract

Flow 4 on_cancel

  • quote_trail should be provided for all the cancelled items

Flow 5

  • Invalid RTO Flow

Flow 6

  • update settlement request is missing

on_update (return_initiated)

  • @ondc/org/settlement_details should have refund settlement details of part-cancellation as it was done before

on_update (return_picked)

  • invalid @ondc/org/provider_name provided as compare to on_select

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2013324103, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XHT6SGCKUYPNVV2VJLYZMUH7AVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJTGMZDIMJQGM . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 4 months ago

RET 16

on_search (full-catalog)

on_search (inc-catalog)

@Tjsvaradhan

sahil-ondc commented 4 months ago

RET 13, 18, 12, 14

on_search (full-catalog)

on_search (inc-catalog)

RET 15

on_search (full-catalog)

on_search (inc-catalog)

@Tjsvaradhan

sahil-ondc commented 4 months ago

RET 10

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

Flow 2

on_init

confirm

on_confirm

on_status_pending

on_status_packed

on_status_picked

on_status_out_for_delivery

on_status_delivered

Flow 4

on_cancel

Flow 5

on_cancel

Flow 6a

on_update

update

Flow 6b

on_update_approval

on_update_picked

update_settlement

on_update_delivered

@Tjsvaradhan

Tjsvaradhan commented 4 months ago

@sahil-ondc

All the above feedback except the following five are invalid. The following five will be corrected and resubmitted. If you have queries on other points let us connect and discuss.

Flow 2 on_comfirm • message.order.fulfillments[c9211089-8b5e-4f41-9ee6-c69abd21d97b]: 'TAT' must be provided in message/order/fulfilments

on_status_pending • schemaErr0: /message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)

Flow 6b on_update_picked

• on_update_picked_msgId: Message id should not be same with previous calls • invldQuoteTrailPrices: quote_trail price and item quote price sum for on_update should be equal to the price as in

update_settlement • update: JSON cannot be empty – Forgot to upload we will upload update_settlement json.

on_update_delivered • on_update_approval_msgId: Message id should not be same with previous calls • invldQuoteTrailPrices: quote_trail price and item quote price sum for on_update should be equal to the price as in

sahil-ondc commented 4 months ago

@Tjsvaradhan

ACK for other points

Tjsvaradhan commented 4 months ago

Sahil, That is one of the corrections we will do at our end - I have already indicated that. Let me know if you want to connect on the comments I have shared. Thanks

On Tue, Apr 23, 2024 at 12:08 PM Sahil Sharma @.***> wrote:

@Tjsvaradhan https://github.com/Tjsvaradhan

  • Invoice should not be provided before pickup state.

ACK for other points

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2071513666, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XF2Z7MOQ246JNV45X3Y6X6U7AVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRGUYTGNRWGY . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 4 months ago

RET 10

Flow 1

on_search

Flow 2

select

init

on_init

on_confirm

on_status (delivered)

Flow 3

on_select (out-of-stock)

Flow 4

on_cancel

Flow 5

on_cancel

Rto-Disposed or Delivered missing

Flow 6

@Tjsvaradhan

Tjsvaradhan commented 4 months ago

Sahil,

Thanks for the feedback.

Please check our details review comments below. In summary, there are 4 basic corrections occurring in about 7 places in the feedback.

Flow 1

on_search

· short_desc and long_desc should not be provided as same

· placeholder values should not be provided for other_FSSAI_license_no, importer_FSSAI_license_no, brand_owner_FSSAI_license_no

GlobalLinker Resp:

Globallinker’s staging environment contains test data – that includes scenarios for multiple test items. In RET10 cases, we are sending the same test “text” in both short_desc and long_desc. However, for other RETs (domains), we are sending different “text” for short_desc and long_desc. Hence, the "different text" case is already included. (In the actual live environment, Sellers will upload different data / text for short_desc and long_desc.)

Also, we are using test FSSAI numbers (complying with the specs requirement of 14 chars) – the actual FSSAI numbers will be shared in the live.

Flow 2

select

· /message/order/items/quantity/count must be integer (SNP should NACK)

init

· /message/order/items/0/quantity/count must be integer (SNP should NACK)

GlobalLinker Resp:

GlobalLinker can accept both String or Integers, AND process them correctly. Also, we are sending correct integer values in on_init and on_confirm too.

Note: We are using the ONDC buyer app for testing.

on_init

· placeholder values should not be provided in payment objects

GlobalLinker Resp:

GlobalLinker sends test data in the payment objects. We can’t provide actual values.

on_confirm

· for buyer apps to process hyperlocal vs intercity orders, pls set routing.type to P2P (hyperlocal), P2H2P (intercity), whenever the order is accepted

GlobalLinker Resp:

Checked on the API contract for mandatory details - routing.type field is not available in on_confirm.

on_status (delivered)

· payment object mismatch

· /message/order/document/url should be publicly accessible

GlobalLinker Resp:

We will send the same payment object received in ‘confirm’ API call. (We added some additional fields based on the API specs – however, after checking they may not be required.)

Payment Object link requires some corrections, we will fix this.

Flow 3

on_select (out-of-stock)

· /error/message should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

GlobalLinker Resp:

The string that we are sending has correct values in correct positions; however, some string notations are missing, and we will fix this.

Flow 4

· Same as above

GlobalLinker Resp:

Refer to the above comments – the same will be applicable here.

on_cancel

· why delivery charges are not refunded if order is in pending state

· /message/order/fulfillment/tags/precancel_state/fulfillment_state is not captured correctly

· /message/order/fulfillment/tags/precancel_state/updated_at is not captured correctly

GlobalLinker Resp:

We will fix the above on_cancel issues.

Flow 5

on_cancel

· /message/order/fulfillment/tags/precancel_state/fulfillment_state is not captured correctly

· /message/order/fulfillment/tags/precancel_state/updated_at is not captured correctly

GlobalLinker Resp:

Same as above - we will fix the above on_cancel issues.

Rto-Disposed or Delivered missing

GlobalLinker Resp:

We will add the payload for this.

Flow 6

· same as above

GlobalLinker Resp:

Refer to the above comments – the same will be applicable here.

Thanks and Regards

TJS Varadhan

On Mon, Apr 29, 2024 at 9:19 PM Sahil Sharma @.***> wrote:

Flow 1 on_search

  • short_desc and long_desc should not be provided as same
  • placeholder values should not be provided for other_FSSAI_license_no, importer_FSSAI_license_no, brand_owner_FSSAI_license_no

Flow 2 select

  • /message/order/items/quantity/count must be integer (SNP should NACK)

init

  • /message/order/items/0/quantity/count must be integer (SNP should NACK)

on_init

  • placeholder values should not be provided in payment objects

on_confirm

  • for buyer apps to process hyperlocal vs intercity orders, pls set routing.type to P2P (hyperlocal), P2H2P (intercity), whenever the order is accepted

on_status (delivered)

  • payment object mismatch
  • /message/order/document/url should be publically accessible

Flow 3 on_select (out-of-stock)

Flow 4

  • Same as above

on_cancel

  • why delivery charges are not refunded if order is in pending state
  • /message/order/fulfillment/tags/precancel_state/fulfillment_state is not captured correctly
  • /message/order/fulfillment/tags/precancel_state/updated_at is not captured correctly

Flow 5 on_cancel

  • /message/order/fulfillment/tags/precancel_state/fulfillment_state is not captured correctly
  • /message/order/fulfillment/tags/precancel_state/updated_at is not captured correctly

Rto-Disposed or Delivered missing Flow 6

  • same as above

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2083085056, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XGAJV6HYVXVN4CXEWTY7ZTXBAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGA4DKMBVGY . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 3 months ago

@Tjsvaradhan,

  1. on_search catalog should be the subset of production, it should not contain test data.
  2. values being either string or integer are defined in API contract, and it should remain same as defined.
  3. Test Data should not be provided.
Tjsvaradhan commented 3 months ago

Hi @Sahil Sharma, Witslab @.***> ,

Thanks for your feedback.

However, please understand:

a) We are creating test data in staging (hence, it will be placeholder text/data only).

b) As a policy (as our bank partners are very sensitive about this), we are NOT allowed to use production data for testing.

c) Data Type requirements (integer, string, etc.) - if there are differences, we will fix them / be compliant as per the specs, as indicated in my responses.

Thanks

On Tue, May 7, 2024 at 6:23 PM Sahil Sharma @.***> wrote:

@Tjsvaradhan https://github.com/Tjsvaradhan,

  1. on_search catalog should be the subset of production, it should not contain test data.
  2. values being either string or integer are defined in API contract, and it should remain same as defined.
  3. Test Data should not be provided.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2098338406, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XC24RKXKR6SPFCBGO3ZBDFERAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGMZTQNBQGY . You are receiving this because you were mentioned.Message ID: @.***>

sandeepshahi commented 3 months ago

RET 15

/on_search (full pull)

/on_search (inc pull)

RET 14

RET 16

RET 13

RET 12

RET 18

@Tjsvaradhan

sahil-ondc commented 3 months ago

RET 10, 16, 18

on_search (full catalog)

RET 12

on_search (full catalog)

RET 13

on_search (full catalog)

on_search (inc catalog)

RET 14

on_search (full catalog)

on_search (inc catalog)

RET 15

on_search (full catalog)

on_search (inc catalog)

Note

@Tjsvaradhan

sahil-ondc commented 3 months ago

Logs has been submitted with repeated issues

(RET10)

Flow 1

on_search (full_catalog)

on_search (inc_catalog)

Flow 2

select

init

on_init

confirm

on_confirm

on_status (pending)

Flow 3, 4, 5, 6

Note

@Tjsvaradhan

Tjsvaradhan commented 3 months ago

Hi Sahil,

Thanks for sharing the feedback. However, some points are not clear - I have explained the details below. Appreciate your confirmation / clarifications. If required, we can connect on call too to understand this.

(RET10)

Flow 1

on_search (full_catalog)

· unicode formatting should not be provided

GlobalLinker Resp: We are not clear about feedback we are not sending Unicode formatting in /on_search. Currently we are sending plain text in name & description.

· placeholders should not be provided in any FSSAI number

GlobalLinker Resp:

we are using test FSSAI numbers (complying with the specs requirement of 14 chars) – the actual FSSAI numbers will be shared in the live.

on_search (inc_catalog)

· descriptor/code should not be provided at item level

GlobalLinker Resp: We are not clear about the above feedback. As per spec document descriptor/code is at item level. Refer to the screenshot below.

[image: image.png]

Flow 2

select

· /message/order/items/quantity/count must be integer (SNP should NACK)

init

· /message/order/items/0/quantity/count must be integer (SNP should NACK)

on_init

· context/timestamp difference between /on_init and /init should be less than 5 sec

GlobalLinker Resp: In the staging environment there are capacity constraints (due to server size/capacity, etc.) – however, in the live environment we do not have such constraints. Hence, we request to ignore any TAT > 5 secs issue.

on_confirm

· context/timestamp difference between /on_confirm and /confirm should be less than 5 sec

GlobalLinker Resp: In the staging environment there are capacity constraints (due to server size/capacity, etc.) – however, in the live environment we do not have such constraints. Hence, we request to ignore any TAT > 5 secs issue.

· payment object mismatches in /confirm & /on_confirm

GlobalLinker Resp: Payment object is same in /confirm & /on_confirm. Refer to the below screenshot. Why is this feedback coming again & again?

[image: image.png]

on_status (pending)

· why pickup and delivery range changes

GlobalLinker Resp: We are sending pickup and delivery range same in /on_confirm & /on_status (Pending)

[image: image.png]

Note

· how range is provided same in Flow 3, Flow 4 and Flow 5 ( "start": "2024-05-19T03:30:00.000Z", "end": "2024-05-21T15:30:00.000Z")

GlobalLinker Resp: There are rules applied to compute time ranges for start & end.

Thanks

On Thu, May 23, 2024 at 6:32 PM Sahil Sharma @.***> wrote:

Logs has been submitted with repeated issues (RET10) Flow 1 on_search (full_catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
  • name, short_desc, and long_desc should not be provided same in /message/catalog/bpp/providers[0]/descriptor
  • unicode formatting should not be provided
  • placeholders should not be provided in any FSSAI number

on_search (inc_catalog)

  • descriptor/code should not be provided at item level
  • matched and reccomended is provided in on_search but missing in on_search inc catalog

Flow 2 select

  • /message/order/items/quantity/count must be integer (SNP should NACK)

init

  • /message/order/items/0/quantity/count must be integer (SNP should NACK)

on_init

  • context/timestamp difference between /on_init and /init should be less than 5 sec

confirm

  • /message/order/items/0/quantity/count must be integer
  • /message/order/fulfillments/0/tracking must be boolean
  • @.***/org/item_quantity/count must be integer

on_confirm

  • context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
  • payment object mismatches in /confirm & /on_confirm

on_status (pending)

  • why pickup and delivery range changes

Flow 3, 4, 5, 6

  • same as above

Note

  • how range is provided same in Flow 3, Flow 4 and Flow 5 ( "start": "2024-05-19T03:30:00.000Z", "end": "2024-05-21T15:30:00.000Z")

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2127051650, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XD6Y7ZS4I5GVI74XX3ZDXSFNAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGA2TCNRVGA . You are receiving this because you were mentioned.Message ID: @.***>

Tjsvaradhan commented 2 months ago

Hi Sandeep / Sahil,

We are submitting RET10 Logs as detailed below>

Upload PR for RET10 (Grocery)

https://github.com/ONDC-Official/v1.2.0-logs/pull/1794

Delete PR for OLD RET10 (Grocery) https://github.com/ONDC-Official/v1.2.0-logs/pull/1793

Note-1:

Please process the Delete PR followed by Upload PR.

Note-2:

1) As “mandated” for us, we have added codes (EAN).

2) Please ignore < 5 secs error, as this happens due to constraints in our staging environment. (Our Live Environment does NOT have this issue)

3) Return Liquidated is NOT supported and hence not included.

4) All other issues have been fixed / verified.

Thanks

On Fri, May 24, 2024 at 2:54 PM Tjs Varadhan < @.***> wrote:

Hi Sahil,

Thanks for sharing the feedback. However, some points are not clear - I have explained the details below. Appreciate your confirmation / clarifications. If required, we can connect on call too to understand this.

(RET10)

Flow 1

on_search (full_catalog)

· unicode formatting should not be provided

GlobalLinker Resp: We are not clear about feedback we are not sending Unicode formatting in /on_search. Currently we are sending plain text in name & description.

· placeholders should not be provided in any FSSAI number

GlobalLinker Resp:

we are using test FSSAI numbers (complying with the specs requirement of 14 chars) – the actual FSSAI numbers will be shared in the live.

on_search (inc_catalog)

· descriptor/code should not be provided at item level

GlobalLinker Resp: We are not clear about the above feedback. As per spec document descriptor/code is at item level. Refer to the screenshot below.

[image: image.png]

Flow 2

select

· /message/order/items/quantity/count must be integer (SNP should NACK)

init

· /message/order/items/0/quantity/count must be integer (SNP should NACK)

on_init

· context/timestamp difference between /on_init and /init should be less than 5 sec

GlobalLinker Resp: In the staging environment there are capacity constraints (due to server size/capacity, etc.) – however, in the live environment we do not have such constraints. Hence, we request to ignore any TAT > 5 secs issue.

on_confirm

· context/timestamp difference between /on_confirm and /confirm should be less than 5 sec

GlobalLinker Resp: In the staging environment there are capacity constraints (due to server size/capacity, etc.) – however, in the live environment we do not have such constraints. Hence, we request to ignore any TAT > 5 secs issue.

· payment object mismatches in /confirm & /on_confirm

GlobalLinker Resp: Payment object is same in /confirm & /on_confirm. Refer to the below screenshot. Why is this feedback coming again & again?

[image: image.png]

on_status (pending)

· why pickup and delivery range changes

GlobalLinker Resp: We are sending pickup and delivery range same in /on_confirm & /on_status (Pending)

[image: image.png]

Note

· how range is provided same in Flow 3, Flow 4 and Flow 5 ( "start": "2024-05-19T03:30:00.000Z", "end": "2024-05-21T15:30:00.000Z")

GlobalLinker Resp: There are rules applied to compute time ranges for start & end.

Thanks

On Thu, May 23, 2024 at 6:32 PM Sahil Sharma @.***> wrote:

Logs has been submitted with repeated issues (RET10) Flow 1 on_search (full_catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
  • name, short_desc, and long_desc should not be provided same in /message/catalog/bpp/providers[0]/descriptor
  • unicode formatting should not be provided
  • placeholders should not be provided in any FSSAI number

on_search (inc_catalog)

  • descriptor/code should not be provided at item level
  • matched and reccomended is provided in on_search but missing in on_search inc catalog

Flow 2 select

  • /message/order/items/quantity/count must be integer (SNP should NACK)

init

  • /message/order/items/0/quantity/count must be integer (SNP should NACK)

on_init

  • context/timestamp difference between /on_init and /init should be less than 5 sec

confirm

  • /message/order/items/0/quantity/count must be integer
  • /message/order/fulfillments/0/tracking must be boolean
  • @.***/org/item_quantity/count must be integer

on_confirm

  • context/timestamp difference between /on_confirm and /confirm should be less than 5 sec
  • payment object mismatches in /confirm & /on_confirm

on_status (pending)

  • why pickup and delivery range changes

Flow 3, 4, 5, 6

  • same as above

Note

  • how range is provided same in Flow 3, Flow 4 and Flow 5 ( "start": "2024-05-19T03:30:00.000Z", "end": "2024-05-21T15:30:00.000Z")

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2127051650, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XD6Y7ZS4I5GVI74XX3ZDXSFNAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXGA2TCNRVGA . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 2 months ago

RET10

Flow 1

on_search (full catalog)

on_search (inc catalog)

Flow 2

on_init

on_confirm

on_status (pending)

Flow 5

on_cancel (rto)

on_status (rto-delivered)

Flow 6

on_status, on_update

Note

@Tjsvaradhan

Tjsvaradhan commented 2 months ago

Hi Sandeep and Sahil,

Thanks for sharing the feedback on RET10. However, few points are NOT clear

Appreciate if you can clarify; if required, I can walk you through these details on a GM call.

Flow 2

on_init

· context/timestamp difference between /on_init and /init should be less than 5 sec

GlobalLinker Response:

Please ignore < 5 secs error, as this happens due to constraints in our staging environment. (Our Live Environment does NOT have this issue)

on_status (pending)

· When the onConfirm Order State is 'Accepted', the on_status_pending is not required (as neither order state is updated nor fulfillment state)

GlobalLinker Response:

Flow 2 contains /on_status_pending that’s why we have added /on_status_pending JSON.

· Flow 2

· search

· on_search

· select

· on_select

· init

· on_init

· confirm

· on_confirm

· on_status_pending

· on_status_packed

· on_status_picked

Flow 5

on_cancel (rto)

· forward fulfillment/pickup timestamp missing

GlobalLinker Response:

The pickup timestamp is not mentioned in the /on_cancel (RTO Flow) in the ONDC API document. We are following the API document. Please refer to the attached screenshot

[image: image.png]

on_status (rto-delivered)

· forward_shipment/pickup timestamp missing

GlobalLinker Response:

The pickup timestamp is not mentioned in the /on_status (RTO-delivered) in the ONDC API document. We are following the API document. Please refer to the attached screenshot

Refer to the screenshot shared above for on_cancel (RTO flow)

Flow 6

on_status, on_update

· forward fulfillment pickup and delivery ranges should be provided in every call.

GlobalLinker Response:

on_status call GlobalLinker is sending pickup and delivery ranges. But in /on_update pickup and delivery ranges are not mentioned in the ONDC API document. [image: image.png]

Note

· short_desc and long_desc should not be same accross providers, items.

GlobalLinker Response:

short_desc and long_desc are not the same for providers and items, unless they are variants.

Thanks

On Tue, Jun 11, 2024 at 1:52 AM Sahil Sharma @.***> wrote:

RET10 Flow 1 on_search (full catalog)

  • item/images are not as per the desciption provided (item_id: 5775276_6459947_9621819)

on_search (inc catalog)

  • Similar Item as in /on_search_full_catalog_refresh api call, item id- 5775276_6459952_9621825 (item should only be provided in case of any change in delta)

Flow 2 on_init

  • context/timestamp difference between /on_init and /init should be less than 5 sec

on_confirm

  • rateable is not a valid property for /message/order/provider

on_status (pending)

  • When the onConfirm Order State is 'Accepted', the on_status_pending is not required (as neither order state is updated nor fulfillment state)

Flow 5 on_cancel (rto)

  • forward fulfillment/pickup timestamp missing
  • invalid /message/order/updated_at, it cannot be less than last API call

on_status (rto-delivered)

  • forward_shipment/pickup timestamp missing

Flow 6 on_status, on_update

  • forward fulfillment pickup and delivery ranges should be provided in every call

Note

  • short_desc and long_desc should not be same accross providers, items.

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2159215507, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XFO7NFJVT7SV3CUP5TZGYDHXAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZGIYTKNJQG4 . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 2 months ago
  1. · forward fulfillment/pickup timestamp missing (required)

@Tjsvaradhan

Tjsvaradhan commented 2 months ago

Hi Sandeep / Sahil,

We are submitting RET10 Logs as detailed below. Please check and approve.

Upload PR for RET10 (Grocery)

https://github.com/ONDC-Official/v1.2.0-logs/pull/1858

Delete PR for OLD RET10 (Grocery)

https://github.com/ONDC-Official/v1.2.0-logs/pull/1857

Note-1:

Please process the Delete PR followed by Upload PR.

Note-2:

1) As “mandated” for us, we have added codes (EAN).

2) Please ignore < 5 secs error, as this happens due to constraints in our staging environment. (Our Live Environment does NOT have this issue)

3) Return Liquidated is NOT supported and hence not included.

4) On_status (Pending) – this is included, as if we omit this we get an error from the validation tool; also, this is a solicited call, as buyers can request for status anytime.

5) All other issues have been fixed / verified. The validation tool was run for all the flows without any other issues.

Thanks

On Wed, Jun 12, 2024 at 12:40 PM Sahil Sharma @.***> wrote:

  1. · forward fulfillment/pickup timestamp missing (required)

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2162273551, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XGKB3MBVNZ3ILFGXWLZG7YAFAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRSGI3TGNJVGE . You are receiving this because you were mentioned.Message ID: @.***>

Tjsvaradhan commented 2 months ago

Hi Sandeep / Sahil,

We are submitting RET10 Logs as detailed below. Please check and approve.

Upload PR for all categories that GlobalLinker is Participating:

https://github.com/ONDC-Official/v1.2.0-logs/pull/1879

Note:

a) We have implemented codes as per the feedback (and also as confirmed by Supriyo) – refer to the details below:

For RET 10, 13, 16, 18

1-EAN

RET12

4:HSN

RET14, RET15

3:GTIN

b) Please ignore < 5 secs error, as this happens due to constraints in our staging environment. (Our Live Environment does NOT have this issue)

c) All other issues have been fixed / verified. The validation tool was run for all the flows without any other issues.

Thanks

On Mon, May 20, 2024 at 7:04 PM Sahil Sharma @.***> wrote:

RET 10, 16, 18 on_search (full catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

RET 12 on_search (full catalog)

  • code should have 4:HSN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
  • /message/catalog/bpp/providers/items/32/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
  • /message/catalog/bpp/providers/items/34/quantity must have required property 'unitized'
  • @.***/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_name'

RET 13 on_search (full catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • description changes should not be provided, item inventory changes, or price changes should be provided

RET 14 on_search (full catalog)

  • /message/catalog/bpp/providers/0/items/20/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
  • mandatory attributes tag fields are missing for Electronics item[3], item[9], item[12]
  • code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • matched, recommended provided in /on_search (full catalog) but not provided in inc_catalog
  • item should only be provided in case of any delta changes on item level

RET 15 on_search (full catalog)

  • code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • why parent_item_id has been removed

Note

  • short_desc and long_desc should not be provided same (provided catalog should be subset of production catalog)

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2120474026, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XFHAZN3PMAWXZQXH3TZDH3UVAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGQ3TIMBSGY . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 2 months ago

flow 1

on_search

flow 2

on_status_pending

on_status_picked

on_status_delivered

flow 5

on_cancel

flow 6

on_status_picked

on_status_delivered

@Tjsvaradhan

sahil-ondc commented 2 months ago

RET 12

on_search

RET 13

on_search

@Tjsvaradhan

Tjsvaradhan commented 2 months ago

Adding @Isha Kakkar @.> and @Badrinath Mishra @.> on their request

Best Regards Adnan Director – SME eCommerce Growth GlobalLinker Gurgaon, India View my business profile on GlobalLinker https://www.globallinker.com/network/profile/mohammad-adnan/240527 ☎ +91-9971217302

On Mon, Jun 17, 2024 at 7:34 PM Tjs Varadhan < @.***> wrote:

Hi Sandeep / Sahil,

We are submitting RET10 Logs as detailed below. Please check and approve.

Upload PR for all categories that GlobalLinker is Participating:

https://github.com/ONDC-Official/v1.2.0-logs/pull/1879

Note:

a) We have implemented codes as per the feedback (and also as confirmed by Supriyo) – refer to the details below:

For RET 10, 13, 16, 18

1-EAN

RET12

4:HSN

RET14, RET15

3:GTIN

b) Please ignore < 5 secs error, as this happens due to constraints in our staging environment. (Our Live Environment does NOT have this issue)

c) All other issues have been fixed / verified. The validation tool was run for all the flows without any other issues.

Thanks

On Mon, May 20, 2024 at 7:04 PM Sahil Sharma @.***> wrote:

RET 10, 16, 18 on_search (full catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

RET 12 on_search (full catalog)

  • code should have 4:HSN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code
  • /message/catalog/bpp/providers/items/32/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
  • /message/catalog/bpp/providers/items/34/quantity must have required property 'unitized'
  • @.***/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_name'

RET 13 on_search (full catalog)

  • code should have 1:EAN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • description changes should not be provided, item inventory changes, or price changes should be provided

RET 14 on_search (full catalog)

  • /message/catalog/bpp/providers/0/items/20/quantity/unitized/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)
  • mandatory attributes tag fields are missing for Electronics item[3], item[9], item[12]
  • code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • matched, recommended provided in /on_search (full catalog) but not provided in inc_catalog
  • item should only be provided in case of any delta changes on item level

RET 15 on_search (full catalog)

  • code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

on_search (inc catalog)

  • why parent_item_id has been removed

Note

  • short_desc and long_desc should not be provided same (provided catalog should be subset of production catalog)

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2120474026, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XFHAZN3PMAWXZQXH3TZDH3UVAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGQ3TIMBSGY . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 2 months ago

RET 15

on_search

RET 16

on_search

RET 18

on_search

Note

@Tjsvaradhan

Tjsvaradhan commented 2 months ago

Hi Sahil,

The feedback for RET18 (Health and Wellness), seems to be incorrect.

As per your earlier feedback, we have implemented EAN Code for RET18. (Refer to: https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2120474026 )

Supriyo also confirmed this recently – refer to the email (PDF file attached).

Hence, we are not changing the RET18 code. We will make the data corrections reported and will resubmit.

Thanks

On Wed, Jun 19, 2024 at 1:11 PM Sahil Sharma @.***> wrote:

RET 15 on_search

  • html tags shouldn't be used in long_desc for item_id: '5775914_6460838_9622756'
  • There shouldn't be any leading spaces in the long_desc for item_id: '5775914_6460829_9622736'
  • Why an extra ']' is there inside the type for item_id: '5775914_6460829_9622736'

RET 16 on_search

  • html tags shouldn't be used in long_desc for item_id: '5775911_6460860_9622789'

RET 18 on_search

  • code should have 3:GTIN as a value in /message/catalog/bpp/providers[0]/items[0]/descriptor/code

Note

  • long_desc, short_desc and name cannot be the same in the bpp/descriptor

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2177981942, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XFETVGDCKQRR4L6LMTZIEY3TAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZXHE4DCOJUGI . You are receiving this because you were mentioned.Message ID: @.***>

Tjsvaradhan commented 2 months ago

Hi Sandeep / Sahil,

We have submitted our logs (GlobalLinker – Retail, Seller App) for all domains (excluding the 2 domains we are not participating - RET11 & RET19, ), after incorporating your feedback.

Refer to the PR: https://github.com/ONDC-Official/v1.2.0-logs/pull/1906

Note: Please approve the delete request first to remove the old logs: https://github.com/ONDC-Official/v1.2.0-logs/pull/1904

Important – RET10:

1) We are not supporting Liquidation Flow and hence we are excluding this flow from our logs. Refer to the email confirmation from Supriyo on this.

2) In the staging environment there are constraints (due to server size/capacity, etc.) – however, in the live environment we do not have such constraints. Hence, we request to ignore any TAT > 5 secs issue.

3) Also, in staging, we create orders and complete all the steps (like packing, delivery, cancel, cancel-rto, etc.) manually for all the flows immediately in the required sequence. Hence, the timestamps may not be within the time ranges given.

4) On_status pending is included, even though the on_confirm status is “accepted”. If we omit it, we get an error. (Also, buyers can initiate status calls any time.)

Important – Other Domains:

As indicated earlier in a separate email, the feedback for RET18 (Health and Wellness), seems to be incorrect.

As per your earlier feedback, we have implemented EAN Code for RET18. (Refer to: https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2120474026 )

Supriyo also confirmed this recently (I have shared this too in my earlier email).

Thanks

On Tue, Jun 18, 2024 at 10:44 AM Sahil Sharma @.***> wrote:

flow 1 on_search

  • For the item_id: "5775276_6459949_9621821", In @ondc/org/statutory_reqs_prepackaged_food, The additive_info, nutritional_info can't be a placeholder

flow 2 on_status_pending

  • When the onConfirm Order State is 'Accepted', the on_status_pending is not required!

on_status_picked

  • The pickup timestamp is not in the range provided for 'Delivery' fulfillment

on_status_delivered

  • The delivery timestamp is not in the range provided for 'Delivery' fulfillment

flow 5 on_cancel

  • retry_count is missing in cancel_request in on_cancel

flow 6 on_status_picked

  • The total price is not updated in the invoice as compared to the quote price
  • The pickup timestamp is not in the range provided for 'Delivery' fulfillment

on_status_delivered

  • The delivery timestamp is not in the range provided for 'Delivery' fulfillment

@Tjsvaradhan https://github.com/Tjsvaradhan

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2175019438, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XCPDFFBM6Q222IQDA3ZH6627AVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZVGAYTSNBTHA . You are receiving this because you were mentioned.Message ID: @.***>

sahil-ondc commented 2 months ago

RET 13, 18

on_search

Tjsvaradhan commented 2 months ago

Hi Sahil / Sandeep,

We have fixed the code issues reported in your feedback below and resubmitted logs or RET 13 and RET18

The PR is: https://github.com/ONDC-Official/v1.2.0-logs/pull/1954

Please check and approve.

Thanks

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Fri, Jun 28, 2024 at 12:37 AM Sahil Sharma @.***> wrote:

RET 13, 18 on_search

  • code should provided in /message/catalog/bpp/providers[0]/items[2]/descriptor/code(781911223139) should be number and with either length 8 or 13

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2195484370, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XEYZBGIL6TIOWJB6JLZJRPFTAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGQ4DIMZXGA . You are receiving this because you were mentioned.Message ID: @.***>

BLR-0118 commented 1 month ago

RET10 - flow 2

  1. /on_confirm:

    • pls explain your calculation of pickup & delivery slots:
    • Order placed at 08:50 (20/6), time_to_ship is 2 days, pickup slot is 20/6 (11:00) - 21/6 (15:30), delivery slot is 21/6 (03:30) - 23/6 (15:30):
    • assuming pickup slot is correct & pickup happens at 11:00 (20/6) => corresponding delivery time is 03:30 (21/6);
    • assuming pickup slot is correct & pickup happens at 15:30 (21/6) => corresponding delivery time is 15:30 (23/6);
    • in the 1st case, delivery takes 16.5 hrs & in 2nd case 48 hrs for delivering between 560034 and 560053 (about 10km, takes at most 1 hr);
    • pls explain the calculation here;

  2. you should send routing type "P2P" when the order is accepted, so that buyer apps can easily process the fulfillment states received;

BLR-0118 commented 1 month ago

@Tjsvaradhan - clearing logs for RET10 but pls clarify / fix the issues raised above;

BLR-0118 commented 1 month ago

RET12

  1. colour_name required, wherever colour hex code provided;

RET13

  1. gender shows values "male", "Male", "female", "Female", check enum here for correct values;

RET14

  1. colour_name required, wherever colour hex code provided;
  2. ram/storage/weight/length/breadth/height seems same for all phones?

RET15

  1. colour_name required, wherever colour hex code provided;

RET16

  1. colour_name required, wherever colour hex code provided;
  2. material values are in lower case, e.g. "aluminium", "stainless" - check enum here;

RET18

  1. variant definition is invalid: a. prescription_required is always "no" until ONDC enables Rx drugs; b. usage_instruction is free text, hence not suitable for variant attr;
BLR-0118 commented 1 month ago

@Tjsvaradhan - all the above issues need to be looked at and clarified or fixed; pls update here for each point raised, after which your logs will be cleared; logs need not be resubmitted unless specifically requested;

Tjsvaradhan commented 1 month ago

Hi Supiryo,

Thaks for the feedback on the logs. I am providing below the clarifications requested. Please contact me if additional details are required.

*I. *Group A

RET10 - flow 2

  1. /on_confirm:

    • pls explain your calculation of pickup & delivery slots:
    • Order placed at 08:50 (20/6), time_to_ship is 2 days, pickup slot is 20/6 (11:00) - 21/6 (15:30), delivery slot is 21/6 (03:30) - 23/6 (15:30):
    • assuming pickup slot is correct & pickup happens at 11:00 (20/6) => corresponding delivery time is 03:30 (21/6);
    • assuming pickup slot is correct & pickup happens at 15:30 (21/6) => corresponding delivery time is 15:30 (23/6);
    • in the 1st case, delivery takes 16.5 hrs & in 2nd case 48 hrs for delivering between 560034 and 560053 (about 10km, takes at most 1 hr);
    • pls explain the calculation here;

Resp.:

· Currently we are using static rules to determine pick-up and delivery time estimates. Hence, the above situation occurs.

· We have started an initiative to enhance this ruleset - we are working with some of our delivery partners to implement a granulised rule-base system that will provide estimates closer to the actual pick-up and delivery times. Once implemented, this situation will not occur.

  1. you should send routing type "P2P" when the order is accepted, so that buyer apps can easily process the fulfillment states received;

Resp.:

In on_confirm, there is no “routing type”; however, we are sending, P2P when appropriate, in other places (on_status for example)

*II. *Group B

RET12

  1. colour_name required, wherever colour hex code provided;

Resp.:

· We submitted the logs for last 2 domains on 28-Jun-2024; however, on this date the colour name has been made mandatory (it was optional until then).

· However, we will add (fix) this at our end soon.

· There is one question: The API specs doc shows the colour names in InitCap, where as the actual enum values are small-letters. Can you please confirm if we need to send InitCap names?

RET13

  1. gender shows values "male", "Male", "female", "Female", check enum here https://github.com/ONDC-Official/protocol-network-extension/blob/main/enums/retail/gender.json for correct values;

Resp.:

GlobalLinker has an independent set of attributes which are mapped to ONDC attributes -enums. There are some residual issues in mapping, which is being revalidated and corrected.

RET14

  1. colour_name required, wherever colour hex code provided;

Resp.:

Colour – same as the response for RET12

  1. ram/storage/weight/length/breadth/height seems same for all phones?

Resp.:

This is are just test data created for testing purposes only. In Live, the actual product data, as uploaded by the sellers, will be shared.

Note: As a practice (as mandated for the financial institution we are partnering with), we do not download / copy our live data for testing. We create them independently for testing.

RET15

  1. colour_name required, wherever colour hex code provided;

Resp.:

Colour – same as the response for RET12

RET16

  1. colour_name required, wherever colour hex code provided;

Resp.:

Colour – same as the response for RET12

  1. material values are in lower case, e.g. "aluminium", "stainless" - check enum here https://github.com/ONDC-Official/protocol-network-extension/blob/main/enums/retail/material.json ;

Resp.:

GlobalLinker has an independent set of attributes which are mapped to ONDC attributes -enums. There are some residual issues in mapping, which is being revalidated and corrected.

RET18

  1. variant definition is invalid:

a. prescription_required is always "no" until ONDC enables Rx drugs;

b. usage_instruction is free text, hence not suitable for variant attr;

Resp.:

For the test data we created, we used some of the ONDC attributes as variant attributes for this category (domain). However, in Live we will use the actual variant attributes defined by the sellers for their products.

Thanks

On Wed, Jul 3, 2024 at 10:47 AM Supriyo Ghosh @.***> wrote:

@Tjsvaradhan https://github.com/Tjsvaradhan - all the above issues need to be looked at and clarified or fixed; pls update here for each point raised, after which your logs will be cleared; logs need not be resubmitted unless specifically requested;

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2205117412, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XGA7XLKELB27SJXYCTZKOCNHAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGEYTONBRGI . You are receiving this because you were mentioned.Message ID: @.***>

BLR-0118 commented 1 month ago

@Tjsvaradhan - attribute is init cap in the catalog taxonomy sheet, mapping of attributes to keys is as follows, e.g. "Size Chart" => "size_chart";

BLR-0118 commented 1 month ago

@Tjsvaradhan - I'm clearing the logs but pls make sure all the above issues are fixed before you rollout v1.2 in Prod;

Tjsvaradhan commented 1 month ago

Hi Supriyo,

Thanks for the confirmation.

Let me explain my query - refer to the screenshot below:

Appreciate your confirmation.

[image: image.png]

Thanks

On Wed, Jul 3, 2024 at 6:31 PM Supriyo Ghosh @.***> wrote:

@Tjsvaradhan https://github.com/Tjsvaradhan - attribute is init cap in the catalog taxonomy sheet, mapping of attributes to keys is as follows, e.g. "Size Chart" => "size_chart";

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#issuecomment-2206025569, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XDAWVMDVEBUG6TZQ33ZKPY3VAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWGAZDKNJWHE . You are receiving this because you were mentioned.Message ID: @.***>

BLR-0118 commented 1 month ago

@Tjsvaradhan - pls check here on how it's defined in the suggestive enum;

Tjsvaradhan commented 1 month ago

Hi Supriyo / Sandeep,

We have fixed a few mapping and other minor issues reported and are getting ready to go live with v1.2.

Please “whitelist” the following Domains for GlobalLinker:

References:

"bpp_uri": "https://httpapi.globallinker.com/gl/ondc", "bpp_id": "httpapi.globallinker.com/gl/ondc"

Domains: RET10/12/13/14/15/16/18 (excluding RET11 & 17)

Note: We are getting the following error in Production: “Domain or BPP not whitelisted”.

Thanks

On Wed, Jul 3, 2024 at 6:32 PM Supriyo Ghosh @.***> wrote:

Closed #805 https://github.com/ONDC-Official/v1.2.0-logs/issues/805 as completed.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#event-13380367748, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XCI7CIHPINHYW6HX7TZKPY6JAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM4DAMZWG43TIOA . You are receiving this because you were mentioned.Message ID: @.***>

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Tjsvaradhan commented 1 month ago

Supriyo / Sandeep, Please help with the Domain Whitelisting as requested below. Thanks

On Thu, Jul 18, 2024 at 4:29 PM Tjs Varadhan < @.***> wrote:

Hi Supriyo / Sandeep,

We have fixed a few mapping and other minor issues reported and are getting ready to go live with v1.2.

Please “whitelist” the following Domains for GlobalLinker:

References:

"bpp_uri": "https://httpapi.globallinker.com/gl/ondc", "bpp_id": "httpapi.globallinker.com/gl/ondc"

Domains: RET10/12/13/14/15/16/18 (excluding RET11 & 17)

Note: We are getting the following error in Production: “Domain or BPP not whitelisted”.

Thanks

On Wed, Jul 3, 2024 at 6:32 PM Supriyo Ghosh @.***> wrote:

Closed #805 https://github.com/ONDC-Official/v1.2.0-logs/issues/805 as completed.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#event-13380367748, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XCI7CIHPINHYW6HX7TZKPY6JAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM4DAMZWG43TIOA . You are receiving this because you were mentioned.Message ID: @.***>

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_-387535708723701650_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

Tjsvaradhan commented 1 month ago

Hi Rishi,

I hope you are well.

Reference to the trailing email, our request for whitelisting our domains has been pending since last week. I would appreciate it if you could request internally to expedite the process.

Thank you.

Best Regards Adnan Director – SME eCommerce Growth GlobalLinker Gurgaon, India View my business profile on GlobalLinker https://www.globallinker.com/network/profile/mohammad-adnan/240527 ☎ +91-9971217302

On Sun, Jul 21, 2024 at 10:50 PM Tjs Varadhan < @.***> wrote:

Supriyo / Sandeep, Please help with the Domain Whitelisting as requested below. Thanks

On Thu, Jul 18, 2024 at 4:29 PM Tjs Varadhan < @.***> wrote:

Hi Supriyo / Sandeep,

We have fixed a few mapping and other minor issues reported and are getting ready to go live with v1.2.

Please “whitelist” the following Domains for GlobalLinker:

References:

"bpp_uri": "https://httpapi.globallinker.com/gl/ondc", "bpp_id": "httpapi.globallinker.com/gl/ondc"

Domains: RET10/12/13/14/15/16/18 (excluding RET11 & 17)

Note: We are getting the following error in Production: “Domain or BPP not whitelisted”.

Thanks

On Wed, Jul 3, 2024 at 6:32 PM Supriyo Ghosh @.***> wrote:

Closed #805 https://github.com/ONDC-Official/v1.2.0-logs/issues/805 as completed.

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/805#event-13380367748, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGAI4XCI7CIHPINHYW6HX7TZKPY6JAVCNFSM6AAAAABDEL2L6CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM4DAMZWG43TIOA . You are receiving this because you were mentioned.Message ID: @.***>

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail Virus-free.www.avg.com http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail <#m_-4548841986376144044m-387535708723701650_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>