ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 274 forks source link

Wiggles - compliance check #83

Open sahil-ondc opened 1 year ago

sahil-ondc commented 1 year ago

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

select

on_init

confirm

on_confirm

on_status

common

@venkatramanm

venkatramanm commented 1 year ago
  • message/catalog/bpp~1providers/0/categories/0 must have required property 'tags'

The categories don't have any customizations.

  • context/city should be "*" while sending search_inc_catalog request The context/city would be what the buyer app sent. If you notice the buyer app sent for 'std:080'

  • location label (/bpp/providers/locations/time/label) for /on_search_inc_refresh should not be equal to /on_search_full_catalog_refresh.label If item price changes or item is disable, we send the catalog in inc_refresh. The data of location is what ever is current. We track if any item is changed or location changes and send the corresponding json. This asserting does not seem right, Can you please confirm.

  • gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init

Space should be trimmed before your assert. (Problem with the tool)

  • Tags should have same and valid gst_number as passed in /on_init

Reference buyer app bug

  • Tags/bap_terms and Tags/bpp_terms should have different gst number in /confirm

Reference Buyer app bug.

  • Tags should have same and valid gst_number as passed in /on_init and confirm

Reference Buyer app bug. there is some hardcoding.

  • message/order/payment/@ondc/org/settlement_details must have required property 'settlement_bank_account_no'
  • /message/order/payment/@ondc/org/settlement_details must have required property 'settlement_ifsc_code'
  • /message/order/payment/@ondc/org/settlement_details must have required property 'beneficiary_name'
  • /message/order/payment/@ondc/org/settlement_details must have required property 'bank_name'
  • /message/order/payment/@ondc/org/settlement_details must have required property 'branch_name'

When upi is sent, these are optional.

  • /message/order/payment/@ondc/org/settlement_details must have required property 'settlement_timestamp'

This is only filled in reconciliation by BAP. This check seems not applicable.

Will fix other issues shortly @sharmasahil0331

venkatramanm commented 1 year ago
  • bpp/fulfillments sent in payload shoulnd't be part of /on_search_inc_refresh api
  • bpp/descriptor sent in payload shoulnd't be part of /on_search_inc_refresh api

While I understand that it may not be required. I don;t understand why it should not be there. What is the issue if present? @BLR-0118 @sharmasahil0331

sahil-ondc commented 1 year ago

@bluecypher Can you please clarify why bpp/fulfillments and bpp/descriptor should not be present in on_search_inc