Mytra (Seller App) - compliance check

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• /message/catalog/bpp/descriptor/tags/bpp_terms must have property np_type (ISN, MSN)
• /message/catalog/bpp/providers/0/items/8/@ondc/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_name'
• /message/catalog/bpp/providers/0/items/8/@ondc/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_address'
• /message/catalog/bpp/providers/0/items/8/@ondc/org/statutory_reqs_packaged_commodities must have required property 'common_or_generic_name_of_commodity'
• /message/catalog/bpp/providers/0/items/8/@ondc/org/statutory_reqs_packaged_commodities must have required property 'month_year_of_manufacture_packing_import'
• /context/city should be as per provided area_code

on_search_inc

• bpp/descriptor sent in payload shoulnd't be part of /on_search_inc_refresh api

Flow 3

on_select (out-of-stock)

• /error/message should be exactly as per API contract error.message in the response should have the list of corresponding item ids referenced in stringified object notation, e.g. if items "I1" is out of stock, error.message would be encoded as: "[{\"item_id\":\"I1\",\"error\":\"40002\"}]"

Other Flows

on_select

• available count can't be greater than maximum count for item id: STO-ITEM-2023-00007-500 Gms:Manikonda - S, STO-ITEM-2023-00017-500 Gms:Manikonda - S

on_init

• gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init

on_confirm

• /message/order/quote must have required property 'ttl'
• /message/order/tags/0/list/0 must be object
• fulfillments[0].end.location gps is not matching with gps in /select

on_status

• /context must have required property 'ttl'
• /message/order/fulfillments/0 must have required property '@ondc/org/TAT'

@harshpwctech

[harshpwctech]

Other Flows

on_select

• available count can't be greater than maximum count for item id: STO-ITEM-2023-00007-500 Gms:Manikonda - S, STO-ITEM-2023-00017-500 Gms:Manikonda - S

Available count of 99 means the stock is available and maximum count of 33 means maximum 33 qty can be ordered in one order, then available count will be greater only. Please confirm if I am missing anything here ?

on_init

• gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init

In init request the buyer app has changed the fulfillments[0].end.location from select API, we as a seller app sent the GPS as received in init request

on_confirm

• /message/order/quote must have required property 'ttl'
• /message/order/tags/0/list/0 must be object
• fulfillments[0].end.location gps is not matching with gps in /select

1. "ttl" is already there in /message/order/quote
2. /message/order/tags/0/list/ is sent as received from the buyer app in confirm request
3. In confirm request the buyer app has changed the fulfillments[0].end.location from select API, we as a seller app sent the GPS as received in confirm request

@sahil-ondc, @bluecypher - Please check the reverts for the above and confirm..

[sandeepshahi]

• /on_select: The understanding is correct
• /on_init: The serviceability and inventory check must be performed before providing the response.
• /on_confirm:
  1. ttl must be PT30S. Ignore if already present.
  2. SNP must respond with a NACK if schema is incorrect
  3. Check the serviceability and inventory and in case of any change, cancel the order

@harshpwctech

[harshpwctech]

@bluecypher, @sahil-ondc, @BLR-0118

Please help in reviewing the logs...I have submitted the logs for flow 1 and flow 3 through Ref Buyer App. The other logs were tested through Mappls, since in their pre-prod instance they are facing some issues and hence we submitted the revised logs from Ref Buyer App.

Further the issue raised for on_search:

• /context/city should be as per provided area_code:

Here the area_code , i.e. 500089 belongs to Hyderabad which have a std code of 040, further the seller is servicing to std code 040, However as an edge case the official std code of 500089 isn't 040, hence we have enabled the seller with std code of 040 as well.

[sahil-ondc]

Other Flows

init

• gps coordinates in fulfillments[0].end.location mismatch in /select & /init

confirm

• /message/order/quote must have required property 'ttl'
• /message/order/tags/0/list/0 must be object

on_confirm

• /message/order/tags/0/list/0 must be object

on_status

• /message/order/fulfillments/0 must have required property '@ondc/org/TAT'

Flow 3

on_select_out_of_stock

• item.quantity.maximum.count and item.quantity.available.count is cannot be greater than zero if \"@ondc/org/item_quantity\" is 0

confirm

• /message/order/quote must have required property 'ttl'

[NishthaMonga]

Flow 1

on_search_full_catalog_refresh

• STD code does not match with correct area_code on /on_search

Flow 2

on_confirm

• mandatory fields like np_type,provider_tax_number,etc missing in message/order/tags/bpp_terms for ON_CONFIRM

Flow 4

on_cancel

• /context must have required property 'ttl'
• /message/order must NOT have additional properties (tags)
• order.created_at timestamp should match context.timestamp
• Pre Cancel is mandatory for on_cancel

Flow 5

on_cancel

• Same as Flow 4

@harshpwctech

[harshpwctech]

@BLR-0118, @sandeepshahi, @sahil-ondc, @NishthaMonga - Please help in clearing the logs as the revised logs are submitted in latest PR. And help in addressing the below queries.

on_search_full_catalog_refresh

• STD code does not match with correct area_code on /on_search

As mentioned above, the area_code, i.e. 500089 belongs to Hyderabad which have a std code of 040, further the seller is servicing to the buyer apps for std code 040, However as an edge case the official std code of 500089 isn't 040, hence we have enabled the seller with std code of 040 as well.

Flow 4

on_cancel

• order.created_at timestamp should match context.timestamp

The order.created_at timestamp wouldn't change and the same is provided by the buyer app during confirm API. Further order.updated_at should be less than or equal to context.timestamp

[NishthaMonga]

Flow 1

on_search_full_catalog_refresh

• STD code does not match with correct area_code on /on_search

Flow 3

on_confirm

• mandatory fields like np_type,provider_tax_number,etc missing in message/order/tags/bpp_terms for ON_CONFIRM

Flow 5

on_cancel

• /message/order must NOT have additional properties (documents)

Flow 6a

on_init

• gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init

on_confirm

• /message/order/tags/0/list/0 must be object
• mandatory fields like np_type,provider_tax_number,etc missing in message/order/tags/bpp_terms for ON_CONFIRM

on_update

• Logs incomplete.

Flow 6b

on_update_approval,on_update_picked

• /message/order/fulfillments/0/start/location must have required property 'id'
• /message/order/fulfillments/0/start/contact must have required property 'email'

NOTE

• Missing on_update logs

@harshpwctech

[BLR-0118]

Flow 1 is an edge case and what's being done is ok as long as the same store is not sent multiple times under different cities; @harshpwctech @NishthaMonga

[harshpwctech]

@BLR-0118, @sandeepshahi, @sahil-ondc, @NishthaMonga - Please help in clearing the logs as the revised logs are submitted in latest PR.

[sahil-ondc]

Flow 1

on_search_full_catalog_refresh

• Delivery and Self-Pickup should not be provided in the provider level fulfillments
• timming should be provided as per the construct provided in API contract on provider level

Flow 2

on_confirm

• mandatory_arbitration should not be provided in bpp_terms as phase 1 implementation

Flow 4

on_cancel

• updated_at provided in pre_cancel state should be correct as when order-state got updated

Flow 5

on_cancel

• invalid state (RTO should be initiated in on_cancel and then order should be disposed or delivered)

flow 6

on_init

• provider_tax_number must be present for on_init

confirm

• /message/order/quote must have required property 'ttl'

Note

• Flow 6 should be provided within a single order with part-cancellation, reverse-qc and liquidation

@harshpwctech