ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 248 forks source link

NDHGO (RET10) - compliance check #859

Closed BLR-0118 closed 6 months ago

BLR-0118 commented 7 months ago

Flow 1

  1. /on_search (full catalog):

    • remove accept_bap_terms (until static terms are enabled);
    • pls use proper street, locality (instead of complete address) in locations.address as this is displayed by buyer apps in the CLP;
    • for item MTMyNjIyXzc5ODM0OTBfM19Q, descriptor.code isn't an EAN code;
    • use non-deprecated category id from this list;
    • item unitized qty should be correctly defined e.g. for item MTMyNjIyXzc5ODM0OTBfM19Q (milk shake), unitized qty should be a volumetric measure (millilitre, litre);
    • for item MTMyNjIyXzgwNTI4NjFfM19Q, name shows "100 g" but unitized qty is "1 unit"?
    • pls add store timings in new format (under "timing");
  2. /on_search (incremental):

    • only full item update supported;
    • for provider - disable, location - disable / close / open supported;

Flow 2

  1. /on_select:

    • provider.locations required;
  2. /on_init:

    • provider_location to be removed;
    • provider.locations to be added;
  3. /on_confirm:

    • fulfillment TAT to be added;
  4. /on_status (all):

    • invoice to be added at order pickup (not earlier) since merchant cancellations may happen prior to that;
    • fulfillment tracking was false in /on_confirm but true in /on_status APIs; however, no tracking logs provided;
    • to optimize tracking processing by buyer apps, pls add routing.type, gps_enabled or (url_enabled, url) in /on_status when tracking has actually been enabled;
BLR-0118 commented 7 months ago

Flow 4

  1. /on_cancel:
    • precancel_state required;

Flow 5

  1. /on_cancel:
    • same issues as above;
    • additional attrs are required in cancel_request as per contract;

Flow 6

flows a & b to be provided for RET10

BLR-0118 commented 7 months ago

@rajib-senrysa - pls fix & resubmit for flows 1, 4, 5, 6

rajib-senrysa commented 7 months ago

@BLR-0118 Can you clarify what are the additional attrs required in cancel_request for Flow 5? Except precancel_state. We will include that.

BLR-0118 commented 6 months ago

Flow 1

  1. /on_search:
    • can we have realistic data in catalog e.g. item MTMyNjIyXzc4MDA2MzZfM19Q - 250ml mango shake, with price of 2000?
    • pls use proper values for unitized qty e.g. item MTMyNjIyXzc4MDA2MzZfM19Q - unitized qty should be 60g (as in product desc);
    • for item MTMyNjIyXzgxMDQwMzVfM19Q (Chicken Burger), shouldn't category_id be "Frozen Snacks"?

Flow 4

  1. /on_select:
    • pls remove quote.type as no buyer app has enabled yet (will break buyer app);
  2. /on_init:
    • since fulfillment id for delivery is selected in /init, the quote shouldn't have entry for self-pickup;
  3. /on_confirm:
    • routing.routing is invalid, should be routing.type;
    • why is url_enabled set to "yes" here, when the order hasn't even been accepted? what will the buyer track? (this should be moved to /on_status when tracking is actually enabled; typically at Agent-assigned for hyperlocal, Order-picked-up for intercity);
    • provider_tax_number is required;

Flow 5

  1. both states RTO_Initiated, RTO_Disposed should be sent;

Flow 6a

  1. /on_update_cancelled:
    • many of the attr keys in cancel_request aren't valid for cancellation e.g. ttl_approval / ttl_reverse_qc, etc;
    • /update_settlement can't have same message_id as this;
BLR-0118 commented 6 months ago

@rajib-senrysa - pls fix all issues above & resubmit for flow 6

rajib-senrysa commented 6 months ago

@BLR-0118

Need two clarifications:

  1. /update_settlement can't have same message_id as this; Since this is a BAP issue, can we ignore this?
  2. For Flow 5, Rto-Initiated will be sent in /on_cancel right?. After that should the Rto-Disposed be sent in an unsolicited /on_status or /on_cancel?
rajib-senrysa commented 6 months ago

@BLR-0118 Have fixed the issues and resubmitted flow 6.

Kindly check and review.

rajib-senrysa commented 6 months ago

@BLR-0118 Any update on this?

BLR-0118 commented 6 months ago

@rajib-senrysa - clearing logs for v1.2.0