ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0

9 stars 247 forks source link

Easy Pay (Seller App - RET10) - Compliance check #885

Open nishthamongaondc opened 6 months ago

nishthamongaondc commented 6 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp~1providers/0 must have required property '@ondc/org/fssai_license_no'
/message/catalog/bpp~1providers/0/categories/0 must have required property 'parent_category_id'
/message/catalog/bpp~1providers/0/items/1/@ondc~1org~1time_to_ship time to ship should be within PT0M-PT59M or PT1H

@ep-aws

sahil-ondc commented 6 months ago

flow 1

on_search

categories.tags missing code:type for variants ; please refer to api contract
item.tags.unitized.measure should be item.quantity.unitized.measure

on_search_inc

categories.tags missing code:type for variants ; please refer to api contract
item.tags.unitized.measure should be item.quantity.unitized.measure

@ep-aws

sahil-ondc commented 5 months ago

Transaction logs should be submitted with some other counterparty NP, whose logs has been approved.

@ep-aws

ep-aws commented 5 months ago

Hi Sahil,

Then what us the purpose of reference buyer App provided by ONDC? We have invested our so much time on making the flow and now you are saying that we need to do things all over again?

@Utkarsh Goswami @Rohit Garg , Please intervene here.

Regards,

Vijay

From: 'Sahil Sharma' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" @.> Date: Wednesday, 3 April 2024 at 1:21 AM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easy Pay (Seller App - RET10) - Compliance check (Issue #885)

Transaction logs should be submitted with some other counterparty NP, whose logs has been approved. @ep-aws

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

-- DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 5 months ago

+Sandeep Shahi @.***>: Please support

On Wed, 3 Apr 2024 at 12:17, Vijay yadav @.***> wrote:

Hi Sahil,

Then what us the purpose of reference buyer App provided by ONDC? We have invested our so much time on making the flow and now you are saying that we need to do things all over again?

@Utkarsh Goswami @.> @Rohit Garg @.> , Please intervene here.

Regards,

Vijay

From: 'Sahil Sharma' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" < @.> Date: Wednesday, 3 April 2024 at 1:21 AM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.**> Subject: *Re: [ONDC-Official/v1.2.0-logs] Easy Pay (Seller App - RET10)

Compliance check (Issue #885)

Transaction logs should be submitted with some other counterparty NP, whose logs has been approved.

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2032981073, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHOK6ML25LMQP4H7C3Y3MD23AVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHE4DCMBXGM . You are receiving this because you were mentioned.Message ID: @.***>

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 5 months ago

Hi Vijay,

As mentioned in the feedback, you are required to submit your logs testing with a counterparty NP that includes ONDC reference buyer app. Submitting logs with your own buyer app is not allowed. Please ensure to review the submission and perform a sanity check yourself before submitting the logs.

Being the third iteration, this must be clear that logs tested with reference buyer app are acceptable.

Regards, Sandeep

On Wed, 3 Apr 2024 at 12:19, Rohit Garg @.***> wrote:

+Sandeep Shahi @.***>: Please support

On Wed, 3 Apr 2024 at 12:17, Vijay yadav @.***> wrote:

Hi Sahil,

Then what us the purpose of reference buyer App provided by ONDC? We have invested our so much time on making the flow and now you are saying that we need to do things all over again?

@Utkarsh Goswami @.> @Rohit Garg @.> , Please intervene here.

Regards,

Vijay

From: 'Sahil Sharma' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" < @.> Date: Wednesday, 3 April 2024 at 1:21 AM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.**> Subject: *Re: [ONDC-Official/v1.2.0-logs] Easy Pay (Seller App - RET10)

Compliance check (Issue #885)

Transaction logs should be submitted with some other counterparty NP, whose logs has been approved.

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2032981073, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHOK6ML25LMQP4H7C3Y3MD23AVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHE4DCMBXGM . You are receiving this because you were mentioned.Message ID: @.***>

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 5 months ago

Hi Sandeep,

Only Flow - 1 is from another buyer that is our buyer app only as we didn't get an incremental search from the reference app. Other flows we generated from preprod buyer reference apps only. Also we validate all our logs via postman utility for sanity tests.

Or else kindly suggest the suitable buyer or any other approach for Flow-1.

On Wed, Apr 3, 2024 at 1:43 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Hi Vijay,

As mentioned in the feedback, you are required to submit your logs testing with a counterparty NP that includes ONDC reference buyer app. Submitting logs with your own buyer app is not allowed. Please ensure to review the submission and perform a sanity check yourself before submitting the logs.

Being the third iteration, this must be clear that logs tested with reference buyer app are acceptable.

Regards, Sandeep

On Wed, 3 Apr 2024 at 12:19, Rohit Garg @.***> wrote:

+Sandeep Shahi @.***>: Please support

On Wed, 3 Apr 2024 at 12:17, Vijay yadav @.***> wrote:

Hi Sahil,

Then what us the purpose of reference buyer App provided by ONDC? We have invested our so much time on making the flow and now you are saying that we need to do things all over again?

@Utkarsh Goswami @.> @Rohit Garg @.> , Please intervene here.

Regards,

Vijay

From: 'Sahil Sharma' via Easy Pay AWS @.> Reply to: "ONDC-Official/v1.2.0-logs" < @.> Date: Wednesday, 3 April 2024 at 1:21 AM To: "ONDC-Official/v1.2.0-logs" @.> Cc: ep-aws @.>, Mention @.**> Subject: *Re: [ONDC-Official/v1.2.0-logs] Easy Pay (Seller App - RET10) - Compliance check (Issue #885)

Transaction logs should be submitted with some other counterparty NP, whose logs has been approved.

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2032981073, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHOK6ML25LMQP4H7C3Y3MD23AVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZSHE4DCMBXGM . You are receiving this because you were mentioned.Message ID: @.***>

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

Jagannath-wits commented 5 months ago

Flow 1

Prices should only be upto 2 decimal points

on_search_full_catalog_refresh

invldAreaCode: STD code does not match with correct area_code on /on_search
item/descriptor/code missing and should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others
bpp/descriptor/accept_bap_terms: accept_bap_terms is not required in bpp/descriptor/tags for now

on_search_inc_refresh

provider id: 2 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh, so how can there be an update for a provider which wasnt present in on_search_full_catalog

Flow 2

on_select

priceErr: Warning: Quoted Price in /on_select INR 1159 does not match with the total price of items in /select INR 586.77 i.e price for the item mismatch in on_search and on_select

on_init

buyerFF: Buyer app finder fee can't change in /on_init, i.e its 0 here but it was 3 in on_search
quantErr: Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

confirm

quantErr: Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

on_confirm

Same as above

Flow 3

on_select_out_of_stock

priceBreakup: Item's unit and total price mismatch for id: 161

select

txnId: Transaction Id should be same as in previous APIs

on_select

priceErr: Warning: Quoted Price in /on_select INR 1159 does not match with the total price of items in /select INR 586.77 i.e price for the item mismatch in on_search and on_select

on_init, confirm and on_confirm

Same as flow 2

Flow 4

Same as above

on_cancel

invldQuotePrices: item quote breakup prices for on_cancel should be equal to the total price.
invalidPrice[162]: Price mismatch for [162] provided in quote object '[290.4]'. Should be same as in quote of on_select.
sttlmntdtls: payment settlement_details mismatch in /on_init & /confirm.
orderCrtd: order.created_at timestamp should match context.timestamp of confirm.

Flow 5

on_cancel

invldQuotePrices: item quote breakup prices for on_cancel should be equal to the total price.
invalidPrice[156]: Price mismatch for [156] provided in quote object '[578.16]'. Should be same as in quote of on_select.
invalidPrice[160]: Price mismatch for [160] provided in quote object '[791.12]'. Should be same as in quote of on_select.
orderCrtd: order.created_at timestamp should match context.timestamp of confirm.

Flow 6

missing flow 6

@ep-aws

ep-aws commented 5 months ago

Hi Team,

We have submitted updated logs on last Friday with below pull request :

https://github.com/ONDC-Official/v1.2.0-logs/pull/1373

Please find below understanding / clarification for some of the earlier raised points : Flow 1

invldAreaCode: STD code does not match with correct area_code on /on_search

We received a search request from "std:08288" and the seller's details we sent with on_seller is serviceable to PAN India and located at Pune (411006) location so that "area_code" : "411006" we set.

Flow 2on_select

priceErr: Warning: Quoted Price in /on_select INR 1159 does not match with the total price of items in /select INR 586.77 i.e price for the item mismatch in on_search and on_select

In on_serach we pass a net selling price ( MRP - Discount ) and in on_select quote price we need to pass (MRP - TAX) so that only we can see properly on the buyer reference app. Please consider the below example.

e.g. We have one products MRP is 899 ( Discount = 512.43 & Tax = 107.88 ) and net selling price is 386.57 ( We pass this is on_search)

[image: image.png] Flow 3select

txnId: Transaction Id should be same as in previous APIs

We pass the txnID we received from select, If any issue on select that this is an issue from buyer side. or please elaborate about this.

On Mon, Apr 8, 2024 at 11:51 AM 'Jagannath Padhy' via Easy Pay AWS < @.***> wrote:

Flow 1 Prices should only be upto 2 decimal points on_search_full_catalog_refresh

invldAreaCode: STD code does not match with correct area_code on /on_search

item/descriptor/code missing and should be in this format - "type:code" where type is 1 - EAN, 2 - ISBN, 3 - GTIN, 4 - HSN, 5 - others

bpp/descriptor/accept_bap_terms: accept_bap_terms is not required in bpp/descriptor/tags for now

on_search_inc_refresh

provider id: 2 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh, so how can there be an update for a provider which wasnt present in on_search_full_catalog

Flow 2 on_select

priceErr: Warning: Quoted Price in /on_select INR 1159 does not match with the total price of items in /select INR 586.77 i.e price for the item mismatch in on_search and on_select

on_init

buyerFF: Buyer app finder fee can't change in /on_init, i.e its 0 here but it was 3 in on_search

quantErr: Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object

confirm

quantErr: Extra attribute Quantity provided in quote object i.e not supposed to be provided after on_select so invalid quote object on_confirm

Same as above

Flow 3 on_select_out_of_stock

priceBreakup: Item's unit and total price mismatch for id: 161

select

txnId: Transaction Id should be same as in previous APIs

on_select

priceErr: Warning: Quoted Price in /on_select INR 1159 does not match with the total price of items in /select INR 586.77 i.e price for the item mismatch in on_search and on_select

on_init, confirm and on_confirm

Same as flow 2

Flow 4

Same as above

on_cancel

invldQuotePrices: item quote breakup prices for on_cancel should be equal to the total price.

invalidPrice[162]: Price mismatch for [162] provided in quote object '[290.4]'. Should be same as in quote of on_select.

sttlmntdtls: payment settlement_details mismatch in /on_init & /confirm.

orderCrtd: order.created_at timestamp should match context.timestamp of confirm.

Flow 5 on_cancel

invldQuotePrices: item quote breakup prices for on_cancel should be equal to the total price.

invalidPrice[156]: Price mismatch for [156] provided in quote object '[578.16]'. Should be same as in quote of on_select.

invalidPrice[160]: Price mismatch for [160] provided in quote object '[791.12]'. Should be same as in quote of on_select.

orderCrtd: order.created_at timestamp should match context.timestamp of confirm.

Flow 6

missing flow 6

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2041949153, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGDKPFBDGDFVO6M53H3Y4IZPRAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRHE2DSMJVGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

sahil-ondc commented 5 months ago

Flow 1

on_search (full_catalog)

/message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160)
/message/catalog/bpp/providers/location/area_code should be as per search request's context/city
@ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number'
importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values
/message/catalog/bpp/providers/items/descriptor/code should have valid length
in case of categories provided, those categories should be mapped to items to show variants

on_search (inc_catalog)

/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp

Flow 2

on_select

context/ttl should be PT30S as per the API Contract
invalid quote breakup as per provided on_search

on_init

provider_tax_number and tax_number should be provided in a valid format
only provider_tax_number, tax_number and np_type should be provided in bpp_terms
cancellation_terms should not be provided as those are not enabled yet

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms
cancellation_terms should not be provided as those are not enabled yet

on_status

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)
/message/order/fulfillments/0/start/time pickup time should not be present until order is picked
/message/order/fulfillments/0/end/time delivery time should not be present until order is delivered
on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

Flow 3

on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock
/error/message should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Note

Same issues as Flow 2
multiple items should be selected while in select, and flow should proceed with the items which are available in stock
Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility

@ep-aws

ep-aws commented 4 months ago

Hello Team,

We required few clarity in raised observations : Flow 1on_search (full_catalog)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city - We received search from "std:08288" and the seller we pass is serving on PAN india, and e.g. one seller settled at Pune (411006) that is why in seller's area-code pass as "411006".
in case of categories provided, those categories should be mapped to items to show variants - Can you please help us to understand how to map categories with Products.

Flow 2on_select

invalid quote breakup as per provided on_search - In on_search we are passing net selling price ( MRP - Discount ) and in on_select we pass quote node as below and working on buyer reference app so can we connect to check out.

"quote": { "price": { "currency": "INR", "value": "1414.33" }, "breakup": [ { @./org/item_id": "160", @./org/item_quantity": { "count": 2 }, "title": "Kashmiri Mamra Almonds", @./org/title_type": "item", "price": { "currency": "INR", "value": "1582.24" ( MRP - Tax ) Ordered Qty }, "item": { "price": { "currency": "INR", "value": "791.12" ( MRP - Tax ) }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "50" } } } }, { **@./org/item_id": "160", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "1024.86" } }, { @./org/item_id": "160", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "215.76" } }, { @./org/item_id": "165", @./org/item_quantity": { "count": 2 }, "title": "Arham Garam Masala", @./org/title_type": "item", "price": { "currency": "INR", "value": "528.0" }, "item": { "price": { "currency": "INR", "value": "264.0" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "5" } } } }, { @./org/item_id": "165", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "165", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "72.0" } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Packing charges", @./org/title_type": "packing", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @.***/org/title_type": "misc", "price": { "currency": "INR", "value": "41.19" } } ], "ttl": "PT60S" }

[image: image.png]

Order Number : 2024-04-11-596449 on_init

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing and in API contract np_type is not there that's why we are not passing here.
cancellation_terms should not be provided as those are not enabled yet
As per logs verification utility this tag we need to add so we added here.

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing.
cancellation_terms should not be provided as those are not enabled yet
As per logs verification utility this tag we need to add so we added here.

Flow 3on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock - As per the API contract here we need to pass the single item price.

Note

multiple items should be selected while in select, and flow should proceed with the items which are available in stock - Can we connect to understand this issue.

On Mon, Apr 15, 2024 at 5:43 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

Flow 1 on_search (full_catalog)

/message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city

@ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number'

importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values

/message/catalog/bpp/providers/items/descriptor/code should have valid length

in case of categories provided, those categories should be mapped to items to show variants

on_search (inc_catalog)

/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp

Flow 2 on_select

context/ttl should be PT30S as per the API Contract

invalid quote breakup as per provided on_search

on_init

provider_tax_number and tax_number should be provided in a valid format

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_status

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)

/message/order/fulfillments/0/start/time pickup time should not be present until order is picked

/message/order/fulfillments/0/end/time delivery time should not be present until order is delivered

on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

Flow 3 on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock

/error/message should be as per API contract

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Note

-

Same issues as Flow 2

multiple items should be selected while in select, and flow should proceed with the items which are available in stock

Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2056695516, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGDT25ALDXNN6U4V5DTY5O76VAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGY4TKNJRGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 4 months ago

++ @Nishtha Monga @.***>

On Wed, 17 Apr 2024 at 14:59, Anand Maheshwari @.***> wrote:

Hello Team,

We required few clarity in raised observations : Flow 1on_search (full_catalog)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city - We received search from "std:08288" and the seller we pass is serving on PAN india, and e.g. one seller settled at Pune (411006) that is why in seller's area-code pass as "411006".

in case of categories provided, those categories should be mapped to items to show variants - Can you please help us to understand how to map categories with Products.

Flow 2on_select

invalid quote breakup as per provided on_search - In on_search we are passing net selling price ( MRP - Discount ) and in on_select we pass quote node as below and working on buyer reference app so can we connect to check out.

"quote": { "price": { "currency": "INR", "value": "1414.33" }, "breakup": [ { @./org/item_id": "160", @./org/item_quantity": { "count": 2 }, "title": "Kashmiri Mamra Almonds", @./org/title_type": "item", "price": { "currency": "INR", "value": "1582.24" ( MRP - Tax ) Ordered Qty }, "item": { "price": { "currency": "INR", "value": "791.12" ( MRP - Tax ) }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "50" } } } }, { **@./org/item_id": "160", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "1024.86" } }, { @./org/item_id": "160", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "215.76" } }, { @./org/item_id": "165", @./org/item_quantity": { "count": 2 }, "title": "Arham Garam Masala", @./org/title_type": "item", "price": { "currency": "INR", "value": "528.0" }, "item": { "price": { "currency": "INR", "value": "264.0" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "5" } } } }, { @./org/item_id": "165", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "165", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "72.0" } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Packing charges", @./org/title_type": "packing", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @.***/org/title_type": "misc", "price": { "currency": "INR", "value": "41.19" } } ], "ttl": "PT60S" }

[image: image.png]

Order Number : 2024-04-11-596449 on_init

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing and in API contract np_type is not there that's why we are not passing here.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

Flow 3on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock - As per the API contract here we need to pass the single item price.

Note

-

multiple items should be selected while in select, and flow should proceed with the items which are available in stock - Can we connect to understand this issue.

On Mon, Apr 15, 2024 at 5:43 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

Flow 1 on_search (full_catalog)

/message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city

@ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number'

importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values

/message/catalog/bpp/providers/items/descriptor/code should have valid length

in case of categories provided, those categories should be mapped to items to show variants

on_search (inc_catalog)

/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp

Flow 2 on_select

context/ttl should be PT30S as per the API Contract

invalid quote breakup as per provided on_search

on_init

provider_tax_number and tax_number should be provided in a valid format

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_status

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)

/message/order/fulfillments/0/start/time pickup time should not be present until order is picked

/message/order/fulfillments/0/end/time delivery time should not be present until order is delivered

on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

Flow 3 on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock

/error/message should be as per API contract

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Note

-

Same issues as Flow 2

multiple items should be selected while in select, and flow should proceed with the items which are available in stock

Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2056695516, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGDT25ALDXNN6U4V5DTY5O76VAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGY4TKNJRGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 4 months ago

Adding Sandeep Shahi as logs is verified by him.

On Wed, Apr 17, 2024 at 3:38 PM Tech Support @.***> wrote:

++ @Nishtha Monga @.***>

On Wed, 17 Apr 2024 at 14:59, Anand Maheshwari @.***> wrote:

Hello Team,

We required few clarity in raised observations : Flow 1on_search (full_catalog)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city - We received search from "std:08288" and the seller we pass is serving on PAN india, and e.g. one seller settled at Pune (411006) that is why in seller's area-code pass as "411006".

in case of categories provided, those categories should be mapped to items to show variants - Can you please help us to understand how to map categories with Products.

Flow 2on_select

invalid quote breakup as per provided on_search - In on_search we are passing net selling price ( MRP - Discount ) and in on_select we pass quote node as below and working on buyer reference app so can we connect to check out.

"quote": { "price": { "currency": "INR", "value": "1414.33" }, "breakup": [ { @./org/item_id": "160", @./org/item_quantity": { "count": 2 }, "title": "Kashmiri Mamra Almonds", @./org/title_type": "item", "price": { "currency": "INR", "value": "1582.24" ( MRP - Tax ) Ordered Qty }, "item": { "price": { "currency": "INR", "value": "791.12" ( MRP - Tax ) }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "50" } } } }, { **@./org/item_id": "160", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "1024.86" } }, { @./org/item_id": "160", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "215.76" } }, { @./org/item_id": "165", @./org/item_quantity": { "count": 2 }, "title": "Arham Garam Masala", @./org/title_type": "item", "price": { "currency": "INR", "value": "528.0" }, "item": { "price": { "currency": "INR", "value": "264.0" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "5" } } } }, { @./org/item_id": "165", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "165", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "72.0" } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Packing charges", @./org/title_type": "packing", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @.***/org/title_type": "misc", "price": { "currency": "INR", "value": "41.19" } } ], "ttl": "PT60S" }

[image: image.png]

Order Number : 2024-04-11-596449 on_init

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing and in API contract np_type is not there that's why we are not passing here.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

Flow 3on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock - As per the API contract here we need to pass the single item price.

Note

-

multiple items should be selected while in select, and flow should proceed with the items which are available in stock - Can we connect to understand this issue.

On Mon, Apr 15, 2024 at 5:43 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

Flow 1 on_search (full_catalog)

/message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city

@ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number'

importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values

/message/catalog/bpp/providers/items/descriptor/code should have valid length

in case of categories provided, those categories should be mapped to items to show variants

on_search (inc_catalog)

/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp

Flow 2 on_select

context/ttl should be PT30S as per the API Contract

invalid quote breakup as per provided on_search

on_init

provider_tax_number and tax_number should be provided in a valid format

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_status

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)

/message/order/fulfillments/0/start/time pickup time should not be present until order is picked

/message/order/fulfillments/0/end/time delivery time should not be present until order is delivered

on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

Flow 3 on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock

/error/message should be as per API contract

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Note

-

Same issues as Flow 2

multiple items should be selected while in select, and flow should proceed with the items which are available in stock

Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2056695516, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGDT25ALDXNN6U4V5DTY5O76VAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGY4TKNJRGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 4 months ago

Hi Team,

Any update on trailed mail.

On Wed, Apr 17, 2024 at 6:07 PM Anand Maheshwari @.***> wrote:

Adding Sandeep Shahi as logs is verified by him.

On Wed, Apr 17, 2024 at 3:38 PM Tech Support @.***> wrote:

++ @Nishtha Monga @.***>

On Wed, 17 Apr 2024 at 14:59, Anand Maheshwari @.***> wrote:

Hello Team,

We required few clarity in raised observations : Flow 1on_search (full_catalog)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city - We received search from "std:08288" and the seller we pass is serving on PAN india, and e.g. one seller settled at Pune (411006) that is why in seller's area-code pass as "411006".

in case of categories provided, those categories should be mapped to items to show variants - Can you please help us to understand how to map categories with Products.

Flow 2on_select

invalid quote breakup as per provided on_search - In on_search we are passing net selling price ( MRP - Discount ) and in on_select we pass quote node as below and working on buyer reference app so can we connect to check out.

"quote": { "price": { "currency": "INR", "value": "1414.33" }, "breakup": [ { @./org/item_id": "160", @./org/item_quantity": { "count": 2 }, "title": "Kashmiri Mamra Almonds", @./org/title_type": "item", "price": { "currency": "INR", "value": "1582.24" ( MRP - Tax ) Ordered Qty }, "item": { "price": { "currency": "INR", "value": "791.12" ( MRP - Tax ) }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "50" } } } }, { **@./org/item_id": "160", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "1024.86" } }, { @./org/item_id": "160", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "215.76" } }, { @./org/item_id": "165", @./org/item_quantity": { "count": 2 }, "title": "Arham Garam Masala", @./org/title_type": "item", "price": { "currency": "INR", "value": "528.0" }, "item": { "price": { "currency": "INR", "value": "264.0" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "5" } } } }, { @./org/item_id": "165", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "165", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "72.0" } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Packing charges", @./org/title_type": "packing", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @.***/org/title_type": "misc", "price": { "currency": "INR", "value": "41.19" } } ], "ttl": "PT60S" }

[image: image.png]

Order Number : 2024-04-11-596449 on_init

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing and in API contract np_type is not there that's why we are not passing here.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing.

cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.

Flow 3on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock - As per the API contract here we need to pass the single item price.

Note

-

multiple items should be selected while in select, and flow should proceed with the items which are available in stock - Can we connect to understand this issue.

On Mon, Apr 15, 2024 at 5:43 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

Flow 1 on_search (full_catalog)

/message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160)

/message/catalog/bpp/providers/location/area_code should be as per search request's context/city

@ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number'

importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values

/message/catalog/bpp/providers/items/descriptor/code should have valid length

in case of categories provided, those categories should be mapped to items to show variants

on_search (inc_catalog)

/message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp

Flow 2 on_select

context/ttl should be PT30S as per the API Contract

invalid quote breakup as per provided on_search

on_init

provider_tax_number and tax_number should be provided in a valid format

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_confirm

only provider_tax_number, tax_number and np_type should be provided in bpp_terms

cancellation_terms should not be provided as those are not enabled yet

on_status

/message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter)

/message/order/fulfillments/0/start/time pickup time should not be present until order is picked

/message/order/fulfillments/0/end/time delivery time should not be present until order is delivered

on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress

Flow 3 on_select (out-of-stock)

/message/order/quote/breakup/item/price/value should be 0 in case of item out of stock

/error/message should be as per API contract

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit

Note

-

Same issues as Flow 2

multiple items should be selected while in select, and flow should proceed with the items which are available in stock

Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2056695516, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGDT25ALDXNN6U4V5DTY5O76VAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWGY4TKNJRGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 4 months ago

++ Nitin/Rohit

From: Anand Maheshwari @.> Date: Thursday, 18 April 2024 at 10:28 AM To: Sandeep Shahi @.> Cc: Nishtha Monga @.>, "ONDC-Official/v1.2.0-logs" @.>, "ONDC-Official/v1.2.0-logs" @.>, ep-aws @.>, Mention @.>, Tech Support @.>, Vijay Yadav @.>, Neha Lokhande @.>, Jay Upadhyay @.***> Subject: Re: [ONDC-Official/v1.2.0-logs] Easy Pay (Seller App - RET10) - Compliance check (Issue #885)

Hi Team,

Any update on trailed mail.

On Wed, Apr 17, 2024 at 6:07 PM Anand Maheshwari @.***> wrote:

Adding Sandeep Shahi as logs is verified by him.

On Wed, Apr 17, 2024 at 3:38 PM Tech Support @.***> wrote:

++ @Nishtha Monga

On Wed, 17 Apr 2024 at 14:59, Anand Maheshwari @.***> wrote:

Hello Team,

We required few clarity in raised observations :

Flow 1 on_search (full_catalog) · /message/catalog/bpp/providers/location/area_code should be as per search request's context/city - We received search from "std:08288" and the seller we pass is serving on PAN india, and e.g. one seller settled at Pune (411006) that is why in seller's area-code pass as "411006".

· in case of categories provided, those categories should be mapped to items to show variants - Can you please help us to understand how to map categories with Products. Flow 2 on_select · invalid quote breakup as per provided on_search - In on_search we are passing net selling price ( MRP - Discount ) and in on_select we pass quote node as below and working on buyer reference app so can we connect to check out.

"quote": { "price": { "currency": "INR", "value": "1414.33" }, "breakup": [ { @./org/item_id": "160", @./org/item_quantity": { "count": 2 }, "title": "Kashmiri Mamra Almonds", @./org/title_type": "item", "price": { "currency": "INR", "value": "1582.24" ( MRP - Tax ) Ordered Qty }, "item": { "price": { "currency": "INR", "value": "791.12" ( MRP - Tax ) }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "50" } } } }, { **@./org/item_id": "160", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "1024.86" } }, { @./org/item_id": "160", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "215.76" } }, { @./org/item_id": "165", @./org/item_quantity": { "count": 2 }, "title": "Arham Garam Masala", @./org/title_type": "item", "price": { "currency": "INR", "value": "528.0" }, "item": { "price": { "currency": "INR", "value": "264.0" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "5" } } } }, { @./org/item_id": "165", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "165", "title": "Tax", @./org/title_type": "tax", "price": { "currency": "INR", "value": "72.0" } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Packing charges", @./org/title_type": "packing", "price": { "currency": "INR", "value": "0.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @.***/org/title_type": "misc", "price": { "currency": "INR", "value": "41.19" } } ], "ttl": "PT60S" }

Order Number : 2024-04-11-596449 on_init · only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing and in API contract np_type is not there that's why we are not passing here.

· cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here. on_confirm · only provider_tax_number, tax_number and np_type should be provided in bpp_terms - As per API contract we also need to pass many other things that we are passing.

· cancellation_terms should not be provided as those are not enabled yet - As per logs verification utility this tag we need to add so we added here.
Flow 3 on_select (out-of-stock) · /message/order/quote/breakup/item/price/value should be 0 in case of item out of stock - As per the API contract here we need to pass the single item price. Note · multiple items should be selected while in select, and flow should proceed with the items which are available in stock - Can we connect to understand this issue.

On Mon, Apr 15, 2024 at 5:43 PM 'Sahil Sharma' via Easy Pay AWS @.***> wrote: Flow 1 on_search (full_catalog) /message/catalog/bpp/providers/items/price/value should be upto 2 decimal points (id: 160) /message/catalog/bpp/providers/location/area_code should be as per search request's context/city @ondc/org/contact_details_consumer_care should be in a format 'name, email, phone number' importer_FSSAI_license_no, brand_owner_FSSAI_license_no, other_FSSAI_license_no should not be provided as placeholder values /message/catalog/bpp/providers/items/descriptor/code should have valid length in case of categories provided, those categories should be mapped to items to show variants on_search (inc_catalog) /message/catalog/bpp/providers/items/time/timestamp cannot be greater than context/timestamp Flow 2 on_select context/ttl should be PT30S as per the API Contract invalid quote breakup as per provided on_search on_init provider_tax_number and tax_number should be provided in a valid format only provider_tax_number, tax_number and np_type should be provided in bpp_terms cancellation_terms should not be provided as those are not enabled yet on_confirm only provider_tax_number, tax_number and np_type should be provided in bpp_terms cancellation_terms should not be provided as those are not enabled yet on_status /message/order Invoice url must be present as part of documents objects (only in Order-picked-up state and thereafter) /message/order/fulfillments/0/start/time pickup time should not be present until order is picked /message/order/fulfillments/0/end/time delivery time should not be present until order is delivered on_status(pending) Order state should be accepted whenever Status is being sent 'Accepted'. Current state: In-progress Flow 3 on_select (out-of-stock) /message/order/quote/breakup/item/price/value should be 0 in case of item out of stock /error/message should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit Note Same issues as Flow 2 multiple items should be selected while in select, and flow should proceed with the items which are available in stock Multiple issues please run the log-validation-utility before submitting the logs https://github.com/ONDC-Official/log-validation-utility @ep-aws

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Thanks & Regards,

Anand Maheshwari

Java - Architect

Mo : +91 8734097448

DISCLAIMER

———————-

The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

Thanks & Regards,

Anand Maheshwari

Java - Architect

Mo : +91 8734097448

Thanks & Regards,

Anand Maheshwari

Java - Architect

Mo : +91 8734097448

sahil-ondc commented 4 months ago

You have provided locations with area_code 560011, but context.city is std:08288. which is wrong. only locations which are as per context.city should be provided.
As per the contract, you can map categories with products by keeping item.parent_item_id same as category.id https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.pyrkgbcknlii
Discount should be provided in - (negative) in the quote.breakup and there should not be exclusive taxes in case of grocery.
cancellation_terms are not enabled yet.
static_terms, np_terms are not enabled yet therefore no need to pass tags which accept_bap_terms.
in case of item out-of-stock, quote.breakup.item.price.value should be zero but provided "price": { "currency": "INR", "value": "343.2" },
multiple items should be selected in the select call, for example you have selected 2 items I1 and I2, and then in on_select you get to know that I1 is out-of-stock and I2 is in stock, then you will update the cart by removing I1 from cart and proceed the flow with I2 which was in stock.

In case of any query you can mail me on sahil.sharma@ondc.org @ep-aws

ep-aws commented 4 months ago

Hi Sahil,

For #1, Can you please describe PAN indian serviceability of products for sellers who want to sell their products PAN india. For #3, Can you please confirm below on_select request : { "context": { "domain": "ONDC:RET10", "country": "IND", "city": "std:020", "action": "on_select", "core_version": "1.2.0", "bap_id": "buyer-app-preprod-v2.ondc.org", "bap_uri": "https://buyer-app-preprod-v2.ondc.org/protocol/v1", "bpp_id": "sellerpreprod.easypay.co.in", "bpp_uri": "https://sellerpreprod.easypay.co.in/ecommerce/ondc/seller", "transaction_id": "0b408654-4087-4c17-a2f4-22b98864928e", "message_id": "94d9e735-8d38-4887-8670-8776c7780ea7", "timestamp": "2024-04-22T07:24:40.651Z", "ttl": "PT30S" }, "message": { "order": { "provider": { "id": "101", "locations": [ { "id": "52" } ] }, "items": [ { "id": "163", "fulfillment_id": "1" } ], "fulfillments": [ { "id": "1", "type": "Delivery", "tracking": false, "state": { "descriptor": { "code": "Serviceable" } }, @./org/provider_name": "Anand Super Mart", @./org/category": "Offline", @./org/TAT": "P2D" } ], "quote": { "price": { "currency": "INR", "value": "175.2" }, "breakup": [ { @./org/item_id": "163", @./org/item_quantity": { "count": 1 }, "title": "Cosmos Organic Sona Masoori Rice", @./org/title_type": "item", "price": { "currency": "INR", "value": "190.0" }, "item": { "price": { "value": "190.0", (We pass this as without deducting the discount, as discount is sent separately and by this node the flow works fine on buyer reference app ) "currency": "INR" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "3" } } } }, { @./org/item_id": "163", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR",

"value": "-20.9"* } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "1.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @./org/title_type": "misc", "price": { "currency": "INR", "value": "5.1" } } ], "ttl": "PT60S" } } } }

[image: Screenshot (87).png]

When we pass discount as negative value in logs verification utility we got error as below :

"/message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places",

[image: Screenshot (89).png]

Can you please look into it? It would be helpful for us if we can connect for 10-15 minutes and resolve/understand these things.

On Thu, Apr 18, 2024 at 12:20 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

1.

You have provided locations with area_code 560011, but context.city is std:08288. which is wrong. only locations which are as per context.city should be provided. 2.

As per the contract, you can map categories with products by keeping item.parent_item_id same as category.id

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.pyrkgbcknlii 3.

Discount should be provided in - (negative) in the quote.breakup and there should not be exclusive taxes in case of grocery. 4.

cancellation_terms are not enabled yet. 5.

static_terms, np_terms are not enabled yet therefore no need to pass tags which accept_bap_terms. 6.

in case of item out-of-stock, quote.breakup.item.price.value should be zero but provided "price": { "currency": "INR", "value": "343.2" }, 7.

multiple items should be selected in the select call, for example you have selected 2 items I1 and I2, and then in on_select you get to know that I1 is out-of-stock and I2 is in stock, then you will update the cart by removing I1 from cart and proceed the flow with I2 which was in stock.

In case of any query you can mail me on @.*** @ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2063145986, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGGAN6K66E4MIFX5XKDY55UMHAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGE2DKOJYGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 4 months ago

Hi Sahil,

We committed logs with required changes and while validating the new logs on postman utility we found below error on it :

In all flows :

"on_confirm": { "schemaErr0": "/message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places", - If we pass discount in negative we got this, Informed to ignore this by ONDC team. "schemaErr1": "/message/order/quote/breakup/3/price/value Price value should be a number in string with upto 2 decimal places", - If we pass discount in negative we got this, Informed to ignore this by ONDC team. "tags_bap_terms": "Tags should have same and valid gst_number as passed in /confirm", "message/order/tags/bpp_terms": "List of bpp_terms mismatched in message/order/tags/bpp_terms for on_init and on_confirm" - As per previous observation we only needs to pass "provider_tax_number", "tax_number" and "np_type" and if we only pass this we got such error }

Pull Request : https://github.com/ONDC-Official/v1.2.0-logs/pull/1501 https://github.com/ONDC-Official/v1.2.0-logs/pull/1501

On Mon, Apr 22, 2024 at 4:51 PM Anand Maheshwari @.***> wrote:

Hi Sahil,

For #1, Can you please describe PAN indian serviceability of products for sellers who want to sell their products PAN india. For #3, Can you please confirm below on_select request : { "context": { "domain": "ONDC:RET10", "country": "IND", "city": "std:020", "action": "on_select", "core_version": "1.2.0", "bap_id": "buyer-app-preprod-v2.ondc.org", "bap_uri": "https://buyer-app-preprod-v2.ondc.org/protocol/v1", "bpp_id": "sellerpreprod.easypay.co.in", "bpp_uri": "https://sellerpreprod.easypay.co.in/ecommerce/ondc/seller ", "transaction_id": "0b408654-4087-4c17-a2f4-22b98864928e", "message_id": "94d9e735-8d38-4887-8670-8776c7780ea7", "timestamp": "2024-04-22T07:24:40.651Z", "ttl": "PT30S" }, "message": { "order": { "provider": { "id": "101", "locations": [ { "id": "52" } ] }, "items": [ { "id": "163", "fulfillment_id": "1" } ], "fulfillments": [ { "id": "1", "type": "Delivery", "tracking": false, "state": { "descriptor": { "code": "Serviceable" } }, @./org/provider_name": "Anand Super Mart", @./org/category": "Offline", @./org/TAT": "P2D" } ], "quote": { "price": { "currency": "INR", "value": "175.2" }, "breakup": [ { @./org/item_id": "163", @./org/item_quantity": { "count": 1 }, "title": "Cosmos Organic Sona Masoori Rice", @./org/title_type": "item", "price": { "currency": "INR", "value": "190.0" }, "item": { "price": { "value": "190.0", (We pass this as without deducting the discount, as discount is sent separately and by this node the flow works fine on buyer reference app ) "currency": "INR" }, "quantity": { "available": { "count": "99" }, "maximum": { "count": "3" } } } }, { @./org/item_id": "163", "title": "Discount", @./org/title_type": "discount", "price": { "currency": "INR",

"value": "-20.9"* } }, { @./org/item_id": "1", "title": "Delivery charges", @./org/title_type": "delivery", "price": { "currency": "INR", "value": "1.0" } }, { @./org/item_id": "1", "title": "Convenience Fee", @./org/title_type": "misc", "price": { "currency": "INR", "value": "5.1" } } ], "ttl": "PT60S" } } } }

[image: Screenshot (87).png]

When we pass discount as negative value in logs verification utility we got error as below :

"/message/order/quote/breakup/1/price/value Price value should be a number in string with upto 2 decimal places",

[image: Screenshot (89).png]

Can you please look into it? It would be helpful for us if we can connect for 10-15 minutes and resolve/understand these things.

On Thu, Apr 18, 2024 at 12:20 PM 'Sahil Sharma' via Easy Pay AWS < @.***> wrote:

1.

You have provided locations with area_code 560011, but context.city is std:08288. which is wrong. only locations which are as per context.city should be provided. 2.

As per the contract, you can map categories with products by keeping item.parent_item_id same as category.id

https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.pyrkgbcknlii 3.

Discount should be provided in - (negative) in the quote.breakup and there should not be exclusive taxes in case of grocery. 4.

cancellation_terms are not enabled yet. 5.

static_terms, np_terms are not enabled yet therefore no need to pass tags which accept_bap_terms. 6.

in case of item out-of-stock, quote.breakup.item.price.value should be zero but provided "price": { "currency": "INR", "value": "343.2" }, 7.

multiple items should be selected in the select call, for example you have selected 2 items I1 and I2, and then in on_select you get to know that I1 is out-of-stock and I2 is in stock, then you will update the cart by removing I1 from cart and proceed the flow with I2 which was in stock.

In case of any query you can mail me on @.*** @ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2063145986, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGGAN6K66E4MIFX5XKDY55UMHAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGE2DKOJYGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

sandeepshahi commented 4 months ago

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags
Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"
store opening days in /locations/time/days should be in correct order and without spacing
delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?
unicode formatting should not be provided in the payload; eg: "\n"
available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"
what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"
placeholder values of back image should not be provided
mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy
for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description

/on_search (inc)

similar issues as in full catalog
push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search
EAN code should be provided in item/descriptor/code for branded grocery products

Flow 2

/on_select

"@ondc/org/category" in /fulfillments should be a valid category as per the delivery method and TAT
price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm
estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls
Agent-assigned state is missing
routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state
Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing
there should not be huge delay in the actual pickup/delivery and triggering of respective APIs
Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";
fulfillment_state in precancel_state is not captured correctly
quote_trail should only be provided for adjusted amount and not for value=0
tax is not provided in quote/breakup but available in quote_trail. how?
prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price
quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4
RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call
start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call
for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment
quote_trail should only include the adjusted values
price provided in quote_trail is incorrect;
convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url
refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;
items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)
start/end address for Return fulfillment should only be provided if the return is approved
fulfillment id of return can't change; should be the same as provided by BNP in /update
How can actual return pickup and delivery timestamps be provided in the interim state?
audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why?
quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)
calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above
quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)
returned quantity is changed for "P003" in reverseqc_input
answer can't be provided for "Q001" in reverseqc_input;

/on_update (picked)

similar issues as above
quote and quote_trail should be updated correctly
audit trail should be correctly maintained; invoice has reappeared
return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws

ep-aws commented 3 months ago

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 3 months ago

Hi Robin,

Can you please arrange a call with Sandeep to clear out some observations. So we can resubmit the logs.

On Sat, May 18, 2024 at 5:10 PM Anand Maheshwari @.***> wrote:

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 3 months ago

Hi Robin,

As discussed, Can you please arrange a call with Sandeep for logs issue clarification.

On Mon, May 20, 2024 at 12:46 PM Anand Maheshwari @.***> wrote:

Hi Robin,

Can you please arrange a call with Sandeep to clear out some observations. So we can resubmit the logs.

On Sat, May 18, 2024 at 5:10 PM Anand Maheshwari @.***> wrote:

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 3 months ago

Hi Anand,

Do you need clarification for all issue?

On Tue, May 21, 2024, 11:08 AM Anand Maheshwari @.***> wrote:

Hi Robin,

As discussed, Can you please arrange a call with Sandeep for logs issue clarification.

On Mon, May 20, 2024 at 12:46 PM Anand Maheshwari @.***> wrote:

Hi Robin,

Can you please arrange a call with Sandeep to clear out some observations. So we can resubmit the logs.

On Sat, May 18, 2024 at 5:10 PM Anand Maheshwari @.***> wrote:

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

ep-aws commented 3 months ago

Hi Robin,

Not all, I highlighted few of them in my previous mail here.

On Tue, May 21, 2024 at 11:32 AM Robin Kumar Chauhan < @.***> wrote:

Hi Anand,

Do you need clarification for all issue?

On Tue, May 21, 2024, 11:08 AM Anand Maheshwari @.***> wrote:

Hi Robin,

As discussed, Can you please arrange a call with Sandeep for logs issue clarification.

On Mon, May 20, 2024 at 12:46 PM Anand Maheshwari @.***> wrote:

Hi Robin,

Can you please arrange a call with Sandeep to clear out some observations. So we can resubmit the logs.

On Sat, May 18, 2024 at 5:10 PM Anand Maheshwari @.***> wrote:

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

ep-aws commented 3 months ago

Hi Robin,

Can you please help to connect with Sandeep for logs observation discussion.

On Tue, May 21, 2024 at 11:37 AM Anand Maheshwari @.***> wrote:

Hi Robin,

Not all, I highlighted few of them in my previous mail here.

On Tue, May 21, 2024 at 11:32 AM Robin Kumar Chauhan < @.***> wrote:

Hi Anand,

Do you need clarification for all issue?

On Tue, May 21, 2024, 11:08 AM Anand Maheshwari @.***> wrote:

Hi Robin,

As discussed, Can you please arrange a call with Sandeep for logs issue clarification.

On Mon, May 20, 2024 at 12:46 PM Anand Maheshwari @.***> wrote:

Hi Robin,

Can you please arrange a call with Sandeep to clear out some observations. So we can resubmit the logs.

On Sat, May 18, 2024 at 5:10 PM Anand Maheshwari @.***> wrote:

Hi Sandeep,

While looking into the observation provided by you, We have some doubts related to that in my inline comments, It would be helpful if you elaborate it.

On Tue, May 14, 2024 at 2:55 PM 'Sandeep Shahi' via Easy Pay AWS < @.***> wrote:

Flow 1

/on_search

duplicate objects for delivery timings and serviceability (for same store location) in /bpp/providers/tags

Order timings must also be provided in /bpp/providers/tags/timing; If the timings are same for delivery and order, use enum "All"

store opening days in /locations/time/days should be in correct order and without spacing

delivery timings provided in /bpp/providers/tags and store timings in /locations/time are different; Is this intended?

unicode formatting should not be provided in the payload; eg: "\n"

available count should be either 99 or 0 to indicate the availability and not the actual inventory count; eg: check for item: "157"

what does maximum count = 100 means. If there is no upper cap, please use "99" value; eg: check for item id: "169"

placeholder values of back image should not be provided

mapping of item and category_id must be correct;eg: baby cream can't be mapped to Bakery, Cakes & Dairy

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description - Let us know for which products you say. We see all products description and title and it's looks fine.

/on_search (inc)

similar issues as in full catalog

push based incremental must be supported; request should not be mocked, ref BNP doesn't initiate one time incremental search - We have implemented pushbased incremental for once scenario where we push item changes via inceremental search. We received call from BNP and sent the on_search and also get on_serach ACK.

EAN code should be provided in item/descriptor/code for branded grocery products. - Our all added products are branded and that's why we pass EAN code. Let me know if any is missed as we added this for testing purpose.

Flow 2

/on_select

@.***/org/category" in /fulfillments should be a valid category as per the delivery method and TAT

price of items in quote/breakup don't match with the catalog pricings; discount may be provided on top of the catalog pricing

/on_init

type, collected_by, uri, status, settlement_basis, settlement_window, withholding_amount should only be provided if seller app is intending to collect prepaid payment - If this not set by seller and also we from buyer side we are not getting @.***/org/settlement_basis" in confirm, then how settlement flow and withholding works that we didn't get.

/on_confirm

estimated pickup time range must be feasible and realistic

/on_status

sending /on_status (Accepted) call is optiona if the order is auto accepted in /on_confirm

estimated pickup and delivery time ranges must be feasible and realistic; the time ranges should not change in the subsequent API calls

Agent-assigned state is missing - This state is not in Utility that's why we didn't added. Although will sent on next submittion.

routing info must be provided in /fulfillments/tags/routing on or before Agent-assigned state - We are passing tracking as false and also this is optional as per API contract.

Invoice provided seems to be invalid; the amount calculation must be correct in the invoicing

there should not be huge delay in the actual pickup/delivery and triggering of respective APIs

Order-delivered: payment/time/timestamp is only required for CoD/PoD payments

Flow 3

similar issues as above

Flow 4

similar issues as above

/on_cancel

item: "165" is mapped to an undefined fulfillment id: "694";

fulfillment_state in precancel_state is not captured correctly

quote_trail should only be provided for adjusted amount and not for value=0

tax is not provided in quote/breakup but available in quote_trail. how?

prices of items in quote_trail are not provided correctly; should be the total price of the items and not the unit price

quote/price should be updated and total price of the items should be 0 along with the count

Flow 5

similar issues as above

/on_cancel

similar issues as in Flow 4

RTO must be initiated in /on_cancel and later status call (delivered or disposed) must be provided through /on_status call

start/end address must be provided for RTO fulfillment as mentioned in the contract

Flow 6

similar issues as above

/on_status (pending)

why is the quantity for item: 154 changed to "0" even before part cancellation is triggered?

/on_update (part cancel)

message_id should be unique for every unsolicited call

for part cancel, the ongoing forward shipment fulfillment should not be modified; cancel_request should be part of the new cancelled fulfillment

quote_trail should only include the adjusted values

price provided in quote_trail is incorrect;

convenience fee (misc) is changed in quote/breakup but not provided in quote_trail

/on_status

placeholder values should not be provided; eg: invoice url

refund related settlement_details (from /update FYI call) must be appended to the settlment_details object in the subsequent API calls

/on_update (interim reverseqc)

audit trail must be correctly maintained; check the previous APIs;

items should not be mapped to the new fulfillment until reverseqc is successful (ie. return is picked)

start/end address for Return fulfillment should only be provided if the return is approved

fulfillment id of return can't change; should be the same as provided by BNP in /update

How can actual return pickup and delivery timestamps be provided in the interim state?

audit trail is not maintained correctly for quote; quantity of part cancelled item has reappeared. why? - Does it mean we don't needs to sent the details of partial cancel products related to item and fulfillment node?

quote and quote/breakup for the returned item should not be updated until reverseqc is successful (ie. return is picked)

calculation of quote/breakup/item price and quote/breakup/price is not correct total price should be = unit price * count

/on_update (approval)

similar issues as above

quote and quote_trail should not be updated until reverseqc is successful (ie. return is picked)

returned quantity is changed for "P003" in reverseqc_input

answer can't be provided for "Q001" in reverseqc_input; - We passed the answer as Y. Do you means we should not need to pass answer here. If so where it will be passed.

/on_update (picked)

similar issues as above

quote and quote_trail should be updated correctly

audit trail should be correctly maintained; invoice has reappeared - When something is retured on order do we needs to update invoice also.?

return pickup and delivery timestamp should be provided at the correct states

update/on_update (liquidated flow)

similar issues as in reverseqc flow

@ep-aws https://github.com/ep-aws

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/885#issuecomment-2109712036, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBCZGGHM6UMZLBP4WIU7CSTZCHKCFAVCNFSM6AAAAABDRBAVA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZG4YTEMBTGY . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

DISCLAIMER ———————- The contents of this e-mail and any attachments are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e-mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or Easy Pay Pvt. Ltd.. If you have received this email in error, please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

-- Thanks & Regards, Anand Maheshwari Java - Architect Mo : +91 8734097448

sandeepshahi commented 3 months ago

Flow 1

/on_search

avoid using unicode formatting eg: \t

/on_search (inc)

enable/disable timestamp can't be future dated
what's the variant group id: 182? It's not a part of full catalog. New variant with no existing variant group shouldn't be provided in incremental pull

Flow 2

/on_select

TAT and fulfillment category mapping must be correct; Same Day delivery must be delivered within the same date as per the context timestamp; use "Next Day Delivery" or "Standard Delivery"

/on_confirm

bap_terms/tax_number is missing in /tags
max(time_to_ship) as per the catalog is 45mins, then why does pickup time range around 4 hours

/on_status

delivery time ranges must only start after the estimated pickup time ends
routing and other info should be maintained for audit purpose

Flow 3

unit price of OOS item must be non-zero; is the state not being maintained?

Flow 4

/on_cancel

why are 2 new logical cancellation shipment created; should be handled through single fulfillment
precancel_state is not captured correctly; should be the last fulfillment state (not order state)
all the adjusted price value in quote/breakup must be provided in quote_trail (eg: "misc" charges)

Flow 5

/on_status

some attribute values are changing in the APIs. check for email etc. and compare with previous APIs

/on_cancel

actual pickup timestamp should not be removed; audit trail must be maintained for the order
precancel_state is not captured correctly; enum value must be correct
terminal state for RTO must be provided through /on_status (disposed/delivered)

Flow 6

/on_status

why is part-cancelled item included in the invoice?

/on_update (part cancel)

quote_trail should include all the adjusted values

/on_update (interim rqc)

buyer requested for return of one item quantity; seller changed to 2. How is this being processed?

/on_update (approved)

pickup and delivery details (address and time ranges) must be provided in return fulfillment

/on_update (picked)

check the total quantity of returned item: 159
why is the return delivery timestmap provided here? should be provided later in the relevant call

is there any logic embedded in actual pickup/delivery timestamp?

@ep-aws

NishthaMonga commented 3 months ago

Flow 1

/on_search

for pack with multiple counts, the recommended unitized measure is 1 unit with the no. of counts mentioned in the SKU's description , check item if 111

@ep-aws

sahil-ondc commented 2 months ago

Flow 1

On Search

bpp/provider/ttl must have a valid value.
manufacturer_or_packer_address cannot be a placeholder for item_id "241".

@ep-aws

sandeepshahi commented 2 months ago

Flow 1

/on_search

item and category_id mapping must be correct; eg: gift hampers should not be mapped to gift vouchers
why is there inconsistency in the catalog data between full and incremental searches

/on_search (inc)

manipulated callback response; the timestamp of search is of 13th June, the txn must have expired already
invalid attributes in "@ondc/org/statutory_reqs_prepackaged_food" object; why is it changed from full catalog?
invalid value of back_image provided; should be a valid image; and why was it not provided in the full catalog?
are all the scenarios of incremental refresh supported?

Flow 5

/on_cancel

why are the estimated pickup/delivery time ranges changed for forward shipment? check the milliseconds values

/on_status (rto delivered)

"cancellation" object wasn't present in /on_cancel but added later in /on_status. Why? consistency must be maintained for "order" object
why is the pickup timestamp removed from forward shipment? Audit trail must be maintained
invalid precancel state; why is it changed when it was captured correctly in /on_cancel
is rto disposed state supported?

Flow 6

/on_update (part cancel)

cancel_request should be part of "Cancel" fulfillment; ongoing forward shipment should not be modified
the above point is correctly handled in subsequent APIs but not when it is triggered; discrepancies in the audit trail should be avoided

/on_update (approved)

start and end details are missing in Return fulfillment

/on_update (picked)

why is the invoice being sent/removed across the APIs?
return pickup time range and timestamp are missing; must also be provided in the subsequent APIs

/on_update (delivered /interim liquidated)

why is the delivery timestamp removed from forward shipment? audit trail must be maintained

/on_update (liquidated)

why are both pickup and delivery timestamps removed from forward shipment? audit trail must be maintained
timestamps should also be provided in return shipment: 66603d06a4c0e402f41fccc0
why is the end address provided in liquidated fulfillment? item(s)is not returned back to origin when liquidated; check the contract for correct schema

@ep-aws

sandeepshahi commented 2 months ago

Flow 1

/on_search

avoid using unicode formatting

Flow 5

/on_status

many attributes missing in /payment; check the contract

/on_cancel

RTO initiation timestamp can't be future dated (in fulfillments/start/time/timestamp for RTO shipment)
"id" must be string in fulfillments/end/location for RTO shipment

/on_status (rto delivered)

why is fulfillment id changing for RTO shipment?
id and descriptor were provided in /on_cancel for RTO shipment (fulfillments/end/location) but changed in /on_status; consistent info must be provided across the APIs

Flow 6

/on_update (return)

invalid value of images in return_request; why is the value converted to stringified array?
price calculation in invoice is incorrect; doesn't match with the quote/price
why is pickup timestamp of forward shipment getting changed?

/on_update (liquidated)

invalid mapping of items "170" and "177" with both the return shipments
start and end details are optional; start/time/timestamp for RTO captures the rto initiation timestamp and not when the return got liquidated

@ep-aws

sandeepshahi commented 2 months ago

Flow 1

/on_search (inc)

search request seems mocked
timestamp can't be the same as in /search

@ep-aws