search

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 287 forks source link

ShopEG - compliance check #92

Closed sahil-ondc closed 7 months ago

sahil-ondc commented 1 year ago

on_search_full_catalog_refresh

search_inc_refresh

on_search_inc_refresh

on_init

on_confirm

on_status_delivered

common

@BasanthVerma

BasanthVerma commented 1 year ago

@sharmasahil0331 All comments have been addressed except for the common payment fields, since reference buyer app doesn't send these fields. If buyer app sends them then it's included in our response.

/message/order/payment must have required property '@ondc/org/settlement_basis'
/message/order/payment must have required property '@ondc/org/settlement_window'
/message/order/payment must have required property '@ondc/org/withholding_amount'

Please check https://github.com/ONDC-Official/v1.2.0-logs/pull/115

sahil-ondc commented 1 year ago

search_inc_refresh

on_search_full_catalog_refresh

@BasanthVerma

BasanthVerma commented 1 year ago

search_inc_refresh

@sharmasahil0331

Will update search_inc_refresh on confirmation.

BasanthVerma commented 12 months ago

@sharmasahil0331 @bluecypher

search_inc_refresh feedback was corrected in #177

sahil-ondc commented 12 months ago

@BasanthVerma Reported issues are still not fixed.

BasanthVerma commented 11 months ago

@sharmasahil0331 @bluecypher, we've submitted Group B with all 5 flows in #280

sahil-ondc commented 11 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_catalog_refresh

Other Flows

@BasanthVerma

sahil-ondc commented 11 months ago

Group B

Flow 1

on_search_full_catalog_refresh

on_search_inc_refresh

Flow 2

on_select

on_init

on_status

Flow 3

on_select_out_of_stock

on_init

Flow 4

on_cancel

BasanthVerma commented 10 months ago

Hi @sahil-ondc @bluecypher , we've resubmitted Group B 1-5 flows and also added flow 6.

Please review: https://github.com/ONDC-Official/v1.2.0-logs/pull/606

sahil-ondc commented 10 months ago

Flow 1

on_search_full_catalog_refresh

on_search_inc_catalog_refresh

FLow 2

on_status

@BasanthVerma

BasanthVerma commented 10 months ago

FLow 2

on_status

/message/order/fulfillments/0/end/instruction - Please check the fulfillments/0/end/instruction/code in our log. We are using code 3, and according to the contract foot note 1145, short_desc is required for code 1 & 2 only .

Flow 1

on_search_full_catalog_refresh & on_search_inc_catalog_refresh - We will fix them

Please check our comment regarding on_status, and is it good if we submit only updated Flow 1 logs again? @sahil-ondc @bluecypher

sandeepshahi commented 10 months ago

@BasanthVerma,

Yes, both are fine.

BasanthVerma commented 10 months ago

@bluecypher Updated flow 1 logs, please check.

sahil-ondc commented 10 months ago

@BasanthVerma

There should not be any manual change in the submitted logs, as we can check there is one commit after you have resubmitted the Flow 1, can you please clarify ?

Screenshot 2024-02-04 at 3 58 50 PM
BasanthVerma commented 10 months ago

@sahil-ondc

I don't see our final commit here which shows the actual submission. 95c5386 and 69c0738 are our internal commits on the working branch of our fork. There can be n number of commits here. The final commit involves a merge from the working branch to our fork's master (which is missing in your screenshot). Then we make the actual submission by sending a PR from our fork's master to this repo's master.

Screenshot 2024-02-04 at 5 24 09 PM

648df20 is the submission commit and no commits/changes were made after this.

Please check the full history.

@bluecypher

sahil-ondc commented 9 months ago

Flow 1

on_search_full

on_search_inc

@BasanthVerma

BasanthVerma commented 9 months ago

@sahil-ondc @bluecypher resubmitted flow 1 new logs as per the above feedback here https://github.com/ONDC-Official/v1.2.0-logs/pull/768

Regarding the last point in on_search_full - I understand that some of products had "na" under nutritional info, additives info etc so they appear as placeholder values but they're not. They were manually entered by one of our team members when creating those test products. We don't have placeholder values for any of such fields. However, although contract doesn't specify min length for such strings, we will be enforcing a min length of maybe 64 characters.

sandeepshahi commented 9 months ago

Flow 1

/on_search

/on_search (inc)

Flow 2

/on_select

/on_init

/on_confirm

/on_status

Flow 3

/on_select (OOS)

Flow 4

/on_cancel

Flow 5

Flow 6

/on_update

/on_status

@BasanthVerma

BasanthVerma commented 9 months ago

placeholder images of SKUs should not be provided in the catalog; ensure that all images are loading properly, as some are not currently loading: These image links are from CAAS database and the CAAS image bucket appears to be down. Some images still might not load in our new submission, we are planning to remove all external image URLs and use our CDN in the coming weeks (before going to prod).

are all the scenarios of incremental pull supported? : All scenarios except offers increment pull is supported. We've included provider and location incremental update cases in the new submission.

@bluecypher resubmitted all 6 flows with fixes.

sahil-ondc commented 9 months ago

on_search_full_catalog_refresh

init

on_confirm

on_status

@BasanthVerma

BasanthVerma commented 9 months ago

on_search_full_catalog_refresh

init

address.building should be more than 3 chars - this is from buyer app

on_confirm

/message/order/tags/bpp_terms should have 'provider_tax_number' - We're MSN, in contract its says mandatory for ISN. Please confirm if it's still made necessary by buyer apps, we can add it.

on_status -Couldn't find any of these issues in the most of the on_status that I just checked. Please share the file path where these issues were found.

@sahil-ondc @bluecypher Please check and confirm if submitting only new on_search_full_catalog_refresh log will suffice

sandeepshahi commented 9 months ago

provider_tax_number is mandatory for all the SNPs

@BasanthVerma

BasanthVerma commented 9 months ago

@bluecypher can you check my other comments too?

BLR-0118 commented 9 months ago

Flow 1

  1. /on_search:
    • catalog should have meaningful info with proper name/unitized qty/price; in most cases, junk chars are used for name / desc;
    • we expect catalog provided here to be a subset of the production catalogs;

Flow 2

  1. /on_select:

    • fulfillment.type is required;
    • fulfillment start & end locations are the same pincode (560038); how does this result in TAT of 6 days?
    • tracking should be enabled for hyperlocal;

  2. /on_confirm:

    • provider_tax_number is required;

Flow 5

  1. /on_cancel:
    • quote_trail is incorrect: delivery & convenience fee are appearing in both quote_trail (for refund) & quote;

Flow 6

  1. /on_update (part cancel):
    • same message_id as /on_confirm;
  2. /update (settlement details):
    • same message_id as /on_update (1 above);
  3. /on_update (return picked) & /on_update (return delivered) have same message id;
BLR-0118 commented 9 months ago

@BasanthVerma - pls resubmit for flows 1 & 5 (expect above issues for flow 2 to be verifiable in flow 5);

BasanthVerma commented 9 months ago

@BLR-0118 please review our PR #949 , this includes the updates as per the feedback:

sahil-ondc commented 9 months ago

Flow 1

on_search_full_catalog

on_search_inc_catalog

@BasanthVerma

BasanthVerma commented 9 months ago

on_search_full_catalog - fixing on_search_inc_catalog - this appears to be correct. message_id's are unique in the submitted logs for catalog. But in store and provider it's not unique, fixing it.

@sahil-ondc

BasanthVerma commented 9 months ago

@BLR-0118 @bluecypher @sahil-ondc we've resubmitted flow 1 with feedback fixes

sandeepshahi commented 8 months ago

Flow 1

/on_search

/on_search (inc)

Flow 5

/on_init

/on_status (OFD)

/on_cancel

/on_status (RTO-Delivered)

@BasanthVerma

BasanthVerma commented 8 months ago

on_search

  1. range can be utilised instead of frequency and times in case of fixed timings - The logs already appear to have range, along with frequency & times. Are you suggesting we only use range and remove frequency & times?

  2. description of variant grouping should not point to a particular variant; eg: 200g is mentioned in the description of variant_group "vg2" - Contract example has "Variant Group 1". Is this something that is displayed to the end user on buyer apps? What is the recommended value to be used for the description? For ex: Surf excel 100 gm and 200 gm variants - can the description be "Quantity Measure based variant" or should it say "Surf excel" alone?

on_cancel

  1. delivery attempts (retry_count) is usually 3 as per the industry standards; Pls check if 2 is also followed - In our case it's off-network self-fulfilled logistics where the merchant would be making the delivery themselves. Usually the merchant will try to contact the buyer before going out for delivery to check their availability. In practice they might reach out more than 2-3 times before canceling (additionally our ops will also attempt to contact in case the merchant couldn't reach the buyer). So should we leave this to 2 or set it to 3?

@sandeepshahi @BLR-0118

sahil-ondc commented 8 months ago

Flow 1

on_search_full_catalog

Flow 5

on_cancel

Note

@BasanthVerma

BasanthVerma commented 8 months ago

on_search full catalog

  1. /message/catalog/bpp/descriptor/tags/bpp_terms should not have property ‘collect_payment’ as part of phase 1 Removing this

  2. timming should be provided in provider level tags as per the API contract Adding this as per the full contract

  3. Categories had some issues and are removed in the current logs, are those issues fixed (on_search) No categories are not removed. They’re fixed and are they’re part of the log that is submitted. (Provider ID nynGrPkGHzKUiR64S3Mw)

on_cancel

  1. if there is any additional charges added due to RTO, that should be mentioned in quote trail as well There are no additional charges. quote_trail and quote values are adding up in the log submitted. Original Order delivery fee and the convenience fee with respect to the delivery fee is left in quote, rest are refunded in quote_trail. What are we missing here?
BasanthVerma commented 8 months ago

@sahil-ondc

sahil-ondc commented 8 months ago
  1. Some amount of misc is refunded and some amount is not refunded, what is the logic behind that ?
BasanthVerma commented 8 months ago

@sahil-ondc it's the convenience fee w.r.t delivery fee that is remaining in quote, more details below:

Convenience fee / misc = (SUM of items + Delivery fee ) 3% convenience fee 18% GST

misc in on_confirm = (75+228+44.65) 0.03 1.18 = 12.31 as shown in quote

revised misc for RTO on_cancel = ( 0+0+44.65) 0.03 1.18 = 1.58 as shown in quote (Rest of the misc 10.73 with respect to items is is refunded in quote_trail)

sahil-ondc commented 8 months ago

ACK

BasanthVerma commented 8 months ago

@sahil-ondc fixed and resubmitted latest logs for on_search full catalog

BLR-0118 commented 8 months ago

Flow 1

  1. item unitized measure should be correctly defined (see comments on 23/2 above), e.g.:
    • item 2aa56627-4f4e-4803-8ce4-4543a012dfc7 should have unitized measure of 22 gram (as per descriptor), not 1 unit;
    • item 44ac7930-d8e3-4d26-8dc9-16a8b8461564 should have unitized measure of 500 gram;

Flow 5

  1. /on_status APIs:

    • to enable buyer apps to differentiate between hyperlocal & intercity fulfillment states, pls set routing.type to P2P (hyperlocal) or P2H2P (intercity), preferably when order is accepted;

  2. /on_cancel:

    • pls also send start & end locations for RTO fulfillment as many buyer apps have validations on that;
BLR-0118 commented 8 months ago

@BasanthVerma - request to pls resubmit for flow 1 & 5

BLR-0118 commented 8 months ago

@BasanthVerma - removed the comment on rto states, it's available in /on_cancel & /on_status

BasanthVerma commented 8 months ago

@BLR-0118 Fixed and resubmitted flow 1 and 5. Please review #1282

sahil-ondc commented 7 months ago

Flow 5

on_select

on_init

@BasanthVerma

BasanthVerma commented 7 months ago

on_select: If you are referring to the price of item 78dc6dba-f96f-4e0f-a832-def925fa41b6, it exists in incremental item on_search

on_init: Looks like new addition in on_init based on the comment in the contract, we'll add it and resubmit flow 5.

@sahil-ondc

sahil-ondc commented 7 months ago

ACK.

BLR-0118 commented 7 months ago

Flow 1

  1. full_catalog_on_search:

    • what does "open" for location 6879 mean? was this store closed previously? if so, where is it showing in logs?
    • item 7a7928e5-59b5-4503-8b4b-88c71ac4d230 has 8 digit EAN code?

  2. incremental search:

    • usecase for item going out-of-stock?
BLR-0118 commented 7 months ago

Flow 5

  1. You need to generate both events RTO-Initiated & RTO-Delivered (in your case) / RTO-Disposed;
  2. not clear from logs whether you're doing this;
BLR-0118 commented 7 months ago

@BasanthVerma - clearing logs for v1.2.0 (RET10), subject to the above being fixed;

BLR-0118 commented 5 months ago

@BasanthVerma - logs cleared for RET13;