Maaserp (Seller App - RET10) - Compliance check

ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0

8 stars 205 forks source link

Maaserp (Seller App - RET10) - Compliance check #936

Open nishthamongaondc opened 4 months ago

nishthamongaondc commented 4 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp~1providers/0/items/0/quantity/unitized/measure/value enter a valid number
/message/catalog/bpp~1providers/0/items/0/quantity/available/count available/count must be equal to one of the allowed values i.e 99 if in stock or 0 if not in stock
imported_product_country_of_origin in /message/catalog/bpp~1providers/0/items/0/@ondc/org/statutory_reqs_prepackaged_food not required
Origin tag fields are missing for Grocery item[0]
long_desc should not be provided as empty string \"\" in /message/catalog/bpp/providers[0]/items[0]/descriptor

on_search_inc_refresh

provider id: P1839 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh

Flow 2

on_select

City code mismatch in /search and /on_select
provider.id mismatches in /on_search and /on_select
item with id: F46796 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_init

Key 'breakup.2.@ondc/org/item_id' mismatch: F46796 !== I9178

on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
Provider Id mismatches in /on_search and /on_confirm
provider.locations[0].id mismatches in /on_search and /on_confirm
Key 'email','created_at', 'updated_at' mismatch for message/order/billing/email and message/order/fulfillments/end/contact/email
fulfillment id F46780 does not exist in /on_select

on_status_delivered

/message/order/id Should be alphanumeric upto 32 letters max
/message/order/fulfillments/1/agent/name and phone must be string
/message/order/quote/breakup/5/price/value must be string
/message/order/payment must have required property 'params' , 'status', 'type', 'collected_by' , '@ondc/org/buyer_app_finder_fee_type', '@ondc/org/buyer_app_finder_fee_amount'
delivery timestamp (/end/time/timestamp) can't be less than or equal to the pickup timestamp (start/time/timestamp)
"Fulfillment ID can't be different for items on flow on_status_delivery

Flow 4

on_cancel

/message/order/tags should have 'quote_trail' as per the API contract

@techopendhi

NishthaMonga commented 4 months ago

Flow 1

on_search_full_catalog_refresh

/message/catalog/bpp~1providers/0/items/0/quantity/unitized/measure/value enter a valid number
/message/catalog/bpp~1providers/0/items/0/quantity/available/count available/count must be equal to one of the allowed values i.e 99 if in stock or 0 if not in stock
item.quantity.available.count should be either 99 (inventory available) or 0 (out-of-stock) in /bpp/providers[0]/items[0]
Origin tag fields are missing for Grocery item[0]
short_desc and long_desc should not be provided as empty string \"\" in /message/catalog/bpp/providers[0]/items[0]/descriptor

on_search_inc_refresh

provider id: P1839 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh

Flow 2

on_select

City code mismatch in /search and /on_select
Invalid Item Id provided in /on_select: I9177, I9178
provider.id mismatches in /on_search and /on_select
provider.locations[0].id mismatches in /select and /on_select

on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
Key 'email' mismatch: prithvi@newforceltd.com !== test@gmail.com
fulfillment id F46780 does not exist in /on_select
tax on fulfillment level charges, to be included only if not 0

on_status_pending

/message/order/fulfillments/0/agent/phone must NOT have fewer than 10 characters
/message/order/quote/breakup/1/price/value must be string
/message/order/payment must have required property 'params'
/message/order/payment must have required property 'status'
/message/order/payment must have required property 'type'
/message/order/payment must have required property 'collected_by'
/message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_type'
/message/order/payment must have required property '@ondc/org/buyer_app_finder_fee_amount'

on_status_packed, on_status_out_for_delivery, on_status_delivered

Same as on_status_pending

on_status_picked logs missing

Flow 3

on_select_out_of_stock

quote.price.value 0 does not match with the price breakup 1600.00

on_select

item with id: F46812 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_init

Key 'breakup.2.@ondc/org/item_id' mismatch: F46812 !== I9178
Key 'breakup.2.title' mismatch: Delivery charges !== Tax
Key 'breakup.2.@ondc/org/title_type' mismatch: delivery !== tax

on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
Key 'email' mismatch: prithvi@newforceltd.com !== test@gmail.com

Flow 4

on_select

item with id: F46792 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_cancel

/message/order/fulfillments/0 must have required property 'tags'
/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled)
/message/order/fulfillments/0/start/location must have required property 'id'
/message/order/fulfillments/0/end must have required property 'person'
/message/order/quote/breakup/1/price/value must be string
Item count should be 0 for /on_cancel in forward shipment
precancel_state not found in fulfillments for on_cancel
Key length mismatch for address
payment settlement_details mismatch in /on_init & /on_cancel

Flow 5

on_cancel

/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled,RTO-Initiated,RTO-Delivered,RTO-Disposed)
/message/order/quote/breakup/0/@ondc~1org~1item_quantity/count must be integer
/message/order/quote/breakup/2/item must have required property 'price'
Key 'address.building' mismatch: 33 !== Prithvi when compared with init billing object
Key 'address.locality' mismatch: Unnamed Road !== 33 when compared with init billing object
RTO object is mandatory for on_cancel
Delivery state should be Cancelled for on_cancel

@techopendhi

techopendhi commented 4 months ago

looping @Gagandeep Singh @.***>

On Thu, Mar 7, 2024 at 7:20 PM NishthaMonga @.***> wrote:

Flow 1 on_search_full_catalog_refresh

/message/catalog/bpp~1providers/0/items/0/quantity/unitized/measure/value enter a valid number

/message/catalog/bpp~1providers/0/items/0/quantity/available/count available/count must be equal to one of the allowed values i.e 99 if in stock or 0 if not in stock

item.quantity.available.count should be either 99 (inventory available) or 0 (out-of-stock) in /bpp/providers[0]/items[0]

Origin tag fields are missing for Grocery item[0]

short_desc and long_desc should not be provided as empty string "" in /message/catalog/bpp/providers[0]/items[0]/descriptor

on_search_inc_refresh

provider id: P1839 in bpp/providers didn't matched for providers id of /on_search_full_catalog_refresh

Flow 2 on_select

City code mismatch in /search and /on_select

Invalid Item Id provided in /on_select: I9177, I9178

provider.id mismatches in /on_search and /on_select

provider.locations[0].id mismatches in /select and /on_select

on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)

Key 'email' mismatch: @. !== @.

fulfillment id F46780 does not exist in /on_select

tax on fulfillment level charges, to be included only if not 0

on_status_pending

/message/order/fulfillments/0/agent/phone must NOT have fewer than 10 characters

/message/order/quote/breakup/1/price/value must be string

/message/order/payment must have required property 'params'

/message/order/payment must have required property 'status'

/message/order/payment must have required property 'type'

/message/order/payment must have required property 'collected_by'

/message/order/payment must have required property @.***/org/buyer_app_finder_fee_type'

/message/order/payment must have required property @.***/org/buyer_app_finder_fee_amount'

on_status_packed, on_status_out_for_delivery, on_status_delivered

Same as on_status_pending

on_status_picked logs missing Flow 3 on_select_out_of_stock

quote.price.value 0 does not match with the price breakup 1600.00

on_select

item with id: F46812 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_init

Key @.***/org/item_id' mismatch: F46812 !== I9178

Key 'breakup.2.title' mismatch: Delivery charges !== Tax

Key @.***/org/title_type' mismatch: delivery !== tax

on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)

Key 'email' mismatch: @. !== @.

Flow 4 on_select

item with id: F46792 in quote.breakup[4] does not exist in items[] (should be a valid item id)

on_cancel

/message/order/fulfillments/0 must have required property 'tags'

/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled)

/message/order/fulfillments/0/start/location must have required property 'id'

/message/order/fulfillments/0/end must have required property 'person'

/message/order/quote/breakup/1/price/value must be string

Item count should be 0 for /on_cancel in forward shipment

precancel_state not found in fulfillments for on_cancel

Key length mismatch for address

payment settlement_details mismatch in /on_init & /on_cancel

Flow 5 on_cancel

/message/order/fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Cancelled,RTO-Initiated,RTO-Delivered,RTO-Disposed)

@.*** https://github.com/ondc1org1item_quantity/count must be integer

/message/order/quote/breakup/2/item must have required property 'price'

Key 'address.building' mismatch: 33 !== Prithvi when compared with init billing object

Key 'address.locality' mismatch: Unnamed Road !== 33 when compared with init billing object

RTO object is mandatory for on_cancel

Delivery state should be Cancelled for on_cancel

@techopendhi https://github.com/techopendhi

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/v1.2.0-logs/issues/936#issuecomment-1983547652, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEHZMWCO2PYGKMMJCCVZPGTYXBWBLAVCNFSM6AAAAABD2ALA6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGU2DONRVGI . You are receiving this because you were mentioned.Message ID: @.***>

techopendhi commented 4 months ago

Hi @nishthamongaondc For the above issue opened I have resubmitted PR https://github.com/ONDC-Official/v1.2.0-logs/pull/995. Please refer to below: https://github.com/techopendhi/v1.2.0-logs/tree/maaserp_v1_2_0_02_03_24/MaasErp/Retail_logs_02_03_24/RET10

sandeepshahi commented 3 months ago

The latest logs must be submitted for verification; The API timestamps indicate past dates and do not sync with the actual log submission dates.

Flow 1

/on_search

accept_bap_terms should not be provided until static terms sent by BAP are accepted by SNP; static terms are part of phase 2
collect_payment block is optional if "N" is provided as value
context/timestamp can't be the same as in /search
statutory reqs should be provided as per the mapping sheet here; placeholder values must not be provided
@ondc/org/mandatory_reqs_veggies_fruits is a deprecated property
Delivery and Self-Pickup is not a valid fulfillment type in /bpp/providers/fulfillments; all the items must be mapped to a default fulfillment type (eg: "Delivery")
invalid property /fulfillments in bpp/providers/items/fulfillments; should be at provider level instead of "items";
placeholder values should not be provided in items/descriptor;
mapping of item, category_id and images must be correct; avoid providing placeholder values
unitized measure of item must be provided correctly; net_quantity in statutory reqs shows different values
store timing (for all supported fulfillment types and order timings) must be provided in bpp/providers/tags
some items within the same category are cancellable while others are not; is this intended?
invalid close timing in bpp/providers/tags/close_timing; should capture the start and end timestamps
placeholder value of fssai should not be provided
store location (gps and address) mapping is incorrect

/on_search (inc)

incremental search request is an old request; must have already expired
city/code must be * as provided in incremental /search
message_id should be unique for unsolicited calls (for regular incremental pull)
image in tags should not be provided if back_image is not available
provider level tags (previous close_timing, min order value and serviceability) should only be updated through full catalog pull and not via incremental search

Flow 2

/on_search

why is this catalog inconsistent with the catalog provided in flow 1 even though the context information is same? eg: some items are not missing

/on_select

"Immediate Delivery" category can be used when delivery TAT <=2 hours in "@ondc/org/category"

/on_init

static/dynamic terms should not be provided (remove cancellation_terms from all the APIs); bpp_terms should only include provider_tax_number, tax_number and np_type; remove other properties till these terms are enabled and notified

/on_confirm

contact/phone number should be of 10 digits
why is the store information changed in /fulfillments/start; catalog shows different address
for above point; avoid using placeholder values and copying values from API contract
How can contact and person information be changed in /fulfillments/end/contact
provider_tax_number, tax_number and np_type must be provided in bpp_terms

/on_status

invalid time ranges pickup and delivery; don't even comply with the delivery TAT
how can actual pickup and delivery timestamp be provided when the order is just in pending state
what does door signify in delivery info (/fulfillments/end/location/address) and where is it getting picked from?
correct information should be retained in subsequent APIs; check delivery info, name and building are swapped, not sure where door info is captured froml locality mismatches
dummy values of start and end instructions provided. read contract for better clarity
invalid vehicle information; check contract
what refund information is captured in pending state (payment settlement details object)?
How can settlement status be PAID and settlement timestamp provided? should be provided once the settlement is initiated by collector
invoice must be provided once the order is picked and thereafter

Flow 3

invalid logs; why is the transaction id same for flow 2 and 3?
txn id for select (out of stock) and select should be same;
submit correct logs to verify

Flow 4

similar issues as above

/on_cancel

invalid subscriber id in "initiated_by"
updated_at of precancel_state is not captured correctly
incorrect calculation of quote; count should be 0 for the total price of item to be 0; total price = unit price * count
order/updated_at is not captured correctly
items must be mapped to the newly created cancelled fulfillment in /items

Flow 5

similar issues as above

/on_cancel

how can RTO flow and cancellation flow in Flow 4 be similar; same txn id, mssg id and timestamps;

Flow 6

entire logs seems to be fabricated
check contract before resubmitting logs; won't be able to check manipulated logs
all the 3 scenarios must be part of single order

several issues might have been missed; the APIs are in really bad shape; fix all the issues as mentioned above in all the flows before resubmitting the logs

@techopendhi

sandeepshahi commented 2 months ago

Multiple repeated issues in the payload; All the previously identified issues must be resolved before resubmitting the logs

Please use the log validation utility and rectify the issues before resubmitting the logs

Flow 1

/on_search

fssai license no is not required for grocery (packaged commodities)
value of locality and street should not be same for store location
is geocoding of store gps and area_code correct? reverse geocoding shows different area code
provided frequency and times in /locations/time shows overlapping store opening times
unicode formatting should not be present. eg: \r and \n
return window (@ondc/org/return_window) should be in correct ISO 8601 duration format
default fulfillment type for items should be of Delivery type instead of Self-Pickup
unitized measure should be correctly marked for the items;
description of items should be correct; placeholder values should not be provided
category_id of items should be mapped correctly; for eg: "dals and pulses" and "Car Washer" are mapped to Fruits and Vegetables, check for other SKUs
time_from and time_to can't be empty in timing block

/on_search (inc)

invalid TAT of callback response; why is the incremental catalog provided for the 2 months old request?
message_id should be unique for unsolicited calls (for regular incremental pull)
veg_nonveg categorization is not correct; value should be "yes" with correct categorization mapping? why is this categorization not present in fulll catalog?
category_id F&B is invalid for F&B domain

Flow 2

/on_select

line items with price = 0 need not be provided in quote/breakup (items and delivery prices are mandatory though)
fulfillment id should be provided in "@ondc/org/item_id" for fulfillment level taxes in quote/breakup
available count should be either 99 or 0 based on the availability; the logic is same as in /on_search

/on_init

tax_number and provider_tax_number can't be of the same entity in case of "MSN" seller app
price value in quote/breakup should be in string format; why is the schema changed from on_select?
Why are taxes changed from fulfillment level to item level

/on_confirm

provider_tax_number is missing in /bpp_terms

/on_status

message_id should be unique for each unsolicited call
invoice must be provided once the order is picked and thereafter
invalid mapping of order state and fulfillment state;eg: order state can't be "In-progress" when fulfillment state is "Pending"
estimated pickup/delivery time ranges are missing;
actual order pickup timestamp (in Order-picked-up) is incorrect; is even before the Agent is assigned
actual order delivery timestamp is missing in Order-delivered state

Flow 3

similar issues as above

/on_select (OOS)

quote/price should be equal to sum of quote/breakup/price
error message should be in correct JSON stringified format as mentioned in the contract
delivery TAT in "@ondc/org/TAT" can't be equal to time to ship provided in /on_search
invalid quote/breakup; why are the item quantities more than the selected quantity in /select (OOS)

Flow 4

similar issues as above
logs must be submitted after testing in preprod environment

/on_cancel

updated_at in precancel_state is not captured correctly; provided timestamp is even before the order is confirmed

Flow 5

similar issues as above
Invalid Flow; how can RTO be initiated in Pending state?

/on_cancel

message id should be unique for unsolicited calls; applicable for any unsolicited API called

Flow 6

part cancellation through /on_update call is missing
message_id should be unique for each unsolicited call
why are duplicate API calls provided; pls provide a sequence for verification
RTO and return are different scenarios; pls rename the files correctly for better clarity
why are separate fulfillment created for each item even when the delivery TAT, pickup and drop location are same
couldn't understand the post order cancelled fulfillment without any cancellation triggered and update in the quote

/on_update (Return Initiated)

item to be returned should not be mapped to the new fulfillment in /items until the return is picked or liquidated;
"item_quantity" in return_request should be in stringified integer format
why are the images provided in return_request changed? values should not change
"ttl_reverseqc" is missing;
refund related payment info once received must be appended to the settlement details object in /payment

/on_update (Return picked/Liquidated)

items mapped with forward shipment must move to the reverse shipment in /items (quantity in forward shipment will be updated)
quote must be updated and quote_trail must be provided in the "Return" shipment

@techopendhi

sahil-ondc commented 2 months ago

Flow 1

on_search (full_catalog)

/message/catalog/bpp/fulfillments/type must be equal to one of the allowed values (Delivery,Self-Pickup)
/message/catalog/bpp/providers/0/locations/0/time must have required property 'schedule'
code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
urls should be valid (provided: https:\/\/d1337r7n45xvmh.cloudfront.net\/maaserp\/images\/logo.webp)
phone number provided should not be placeholder (provided: 2298009090)
days are mentioned (1,2,3,4,5,6,7) in /message/catalog/bpp/providers/locations, but in timing tags its (1 to 5)

on_search (inc_catalog)

same as above
recommended and related are provided in on_search (full_catalog) but not provided in inc_catalog

Flow 2

select

Buyer selects multiple items (> 1 qty for each item) for checkout https://docs.google.com/spreadsheets/d/1JZV6ZQzXcHUsOwegGtArX3DdIXYIy3gxkhQ00q7kICc/edit#gid=1367601795

on_select

start and end is an optional property for /message/order/fulfillments
invalid range provided in /message/order/fulfillments

on_init

why @ondc/org/TAT has changed for fulfillment (F52172) from 'P1DT8M' to 'P1DT30M'

on_confirm

Again discrepancy in @ondc/org/TAT as in on_init
contact number should not be provided as placeholder (provided: 2298009090)
routing info should be provided at fulfillment level

on_status

pickup and delivery range should remain same as provided in /on_confirm

Flow 3

Same as above

on_select

/message/order/breakup/item/count should be zero in case of item is out of stock
/error/message should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

Flow 4

on_cancel

/message/order/fulfillment/tags precancel_state updated_at is not captured correctly
start and end range should remain same as provided in /on_confirm

Flow 5

rto-Delivered or rto-Disposed should be provided

on_cancel (rto)

/message/order/fulfillment/tags precancel_state fulfillment_state should be 'Out-for-delivery' (provided: out for delivery)
/message/order/fulfillment/tags precancel_state updated_at is not captured correctly

Flow 6

@ondc/org/settlement_details should have refund settlement details after any refund
return (reverse-qc) fulfillment should have start and end locations
return (reverse-qc) fulfillment should have expected start and end time range provided

Note

(on_search) in case of same day_to and day_from, and same timings use type 'All' in timing tags

@techopendhi

sahil-ondc commented 1 month ago

Logs with repeated issues has been submitted

Flow 1

on_search (full_catalog) (Transaction logs not submitted, therefore considering last submitted log)

/message/catalog/bpp/fulfillments/type must be equal to one of the allowed values (Delivery,Self-Pickup)
/message/catalog/bpp/providers/0/locations/0/time must have required property 'schedule'
code should provided in /message/catalog/bpp/providers[0]/items[0]/descriptor
urls should be valid (provided: https:\/\/d1337r7n45xvmh.cloudfront.net\/maaserp\/images\/logo.webp)
phone number provided should not be placeholder (provided: 2298009090)
days are mentioned (1,2,3,4,5,6,7) in /message/catalog/bpp/providers/locations, but in timing tags its (1 to 5)

on_search (inc_catalog)

same as above

Flow 2

on_select

/fulfillments[1]/@ondc/org/TAT (O2D) in /on_select can't be less than @ondc/org/time_to_ship (O2S) in /on_search
Takeaway, Kerbside are the enums for fulfillment/@ondc/org/category when type is Self-Pickup (provided: Same Day Delivery)
all the serviceable line items should be provided in quote/breakup
range should not be provided in /message/order/fulfillments

on_init

context/timestamp difference between /on_init and /init should be less than 5 sec

on_confirm

context/timestamp difference between /on_confirm and /confirm should be less than 5 sec

on_status (accepted)

fulfillment state cannot be 'Accepted', it should be 'Pending' when order/state is 'Accepted' https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ii1xl1f08zho

on_status (Agent-assigned)

routing tags should be provided on fulfillment level
fulfillment state cannot be 'Agent Assigned', it should be 'Agent-assigned' when order/state is 'In-progress' https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.ii1xl1f08zho

Flow 3

same as Flow 2

on_select (out-of-stock)

/error/message should be as per API contract https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.c6o4dr7q1ywl

Flow 4

same as Flow 2

on_cancel

updated_at provided in precancel_state is not captured correctly
tracking information is provided in on_confirm but missing in on_cancel

Flow 5

same as Flow 2 and Flow 4

Flow 6

on_status

any status being provided after part-cancellation should have settlement details appended in @ondc/org/settlement_details

@techopendhi

sahil-ondc commented 1 month ago

Flow 1

on_search

/message/catalog/bpp~1providers/0/items/0 must have required property '@ondc/org/return_window'
/message/catalog/bpp~1providers/0/items/3/quantity/maximum/count maximum count must be numbers only
item.quantity.available.count and item.quantity.maximum.count should be greater than or equal to 0 cannot be negative (item_id: I9441)
categories must be present in bpp/providers[0] (variants must be provided)
veg_nonveg should be mapped correctly (despite of being any item it is sent to veg:no)

on_search (inc catalog)

EAN code should not be changed for an item, as it is considered as item has changed (item_id: I9474, I9448)

Flow 2

on_select

all the fulfillment options which are serviceable should be mapped in breakup
provider_name should not be provided in case of 'Self-Pickup' https://docs.google.com/document/d/1brvcltG_DagZ3kGr1ZZQk4hG4tze3zvcxmGV4NMTzr8/edit#heading=h.qosny36ge6ai

on_init

context/timestamp difference between /on_init and /init should be less than 5 sec

on_confirm

pickup and delivery range is not as per provided TAT
start and end location is out of serviceability range defined in on_search (provided range: 3KM)

on_status

routing tags were provided till agent-assigned, but not provided in picked-up, out-for-delivery and delivered

Flow 3

on_track

tracking url should be publically accessible

Flow 5

on_cancel

precancel_state updated_at is not captured correctly

on_status (rto-delivered)

- precancel_state updated_at should remain same as provided in on_cancel

Flow 6

multiple JSONs provided in files, on_update (return initiated, return approved, return delivered)

@techopendhi

sahil-ondc commented 3 weeks ago

Flow 1

on_search (full catalog)

why catalog is falling under Grocery for ex: I51410, I51414, shouldn't it fall under BPC (item.name: santoor bathing soap, proposed category: Bath Soaps and Gels)
item/quantity/unitized/measure is not correctly mapped with item/name and item/desciption
categories has been provided but it's corresponding multiple variants should be provided

on_search (inc catalog)

items should only be provided when there is some change in delta (item.id: I51415, I51419)

Flow 2

on_select

context/timestamp difference between /on_select and /select should be less than 5 sec
/fulfillments[1]/@ondc/org/TAT (O2D) in /on_select can't be equal to @ondc/org/time_to_ship (O2S) in /on_search

on_init

context/timestamp difference between /on_init and /init should be less than 5 sec

Flow 4, 5

on_cancel

why C3419, C3432 has been added in quote/breakup

@techopendhi

techopendhi commented 2 weeks ago

@sahil-ondc I had a call with the ONDC team regarding the aforementioned issues and also communicated with them via email. They informed me that the following are false errors, as per my expectations:

Incorrect Mapping of item/quantity/unitized/measure with item/name and item/description
- Example: The product "surf excel matic front load liquid detergent 1 litre" has a quantity of 1.
- Their reply: "I have checked the payload. You can address this invalid error on the issue board. item/quantity/unitized/measure is not correctly mapped with item/name and item/description."
Mismatch of /fulfillments[1]/@ondc/org/TAT (O2D) in /on_select with @ondc/org/time_to_ship (O2S) in /on_search
- I have sent two fulfillment methods: delivery and self-pickup. In this case, the time_to_ship should be equal to O2S since it is a self-pickup. For self-pickup, only O2S needs to be sent, not O2D.
Addition of C3419, C3432 in quote/breakup
- Their reply: "For flow 4, new fulfillment charges should not be included; you can apply them in flow 5."
- Consequently, I have removed the delivery charges in Flow 4, as they were from the buyer's side, but retained the delivery charges in Flow 5.
cc: @techopendhi

techopendhi commented 2 weeks ago

New logs were submitted yesterday in MaasERP_Solutions/Retail/RET10/2024-06-20 according to the feedback given.

sahil-ondc commented 1 week ago

Flow 1

on_search

item named as:niine naturally soft sanitary napkin ultra thin 6 piece, shouldn't be in Health and Wellness (Feminine Care)
item.quantity.unitized.measure should be mapped correctly (ex: rin ala fabric whitener 500 milli litre, it should have unit as millilitre not unit 1)
is only Cleaning & Household supported ?

Other Flows

on_select

how an fulfillment is having @ondc/org/TAT as 6 minutes (P0DT6M) while time_to_ship is 5 minutes

on_confirm

pickup and delivery ranges should be as per @ondc/org/TAT

on_status (picked)

as per provided invoice, payment method is cash, but as per order details its prepaid (please explain)

@techopendhi

techopendhi commented 1 week ago

@sahil-ondc

We have gone through the issues that you have raised. Please find the resolutions and explanations below:

Flow 1 item named as:niine naturally soft sanitary napkin ultra thin 6 piece, shouldn't be in Health and Wellness (Feminine Care) Resolution: We will be removing this product and resubmit the logs as we are considering RET10 for now.

item.quantity.unitized.measure should be mapped correctly (ex: rin ala fabric whitener 500 milli litre, it should have unit as millilitre not unit 1) Explanation: This issue was already discussed with the ONDC logs team (POC- Jyoti Sharma) and they have acknowledged that our payload is correct and we can address this as invalid error. Please refer to the attached screenshot.

is only Cleaning & Household supported ? Explanation: No, we are supporting all the categories that fall under RET10 but for the logs submission we are using Cleaning and Household.

Other Flows on_select how an fulfillment is having @ondc/org/TAT as 6 minutes (P0DT6M) while time_to_ship is 5 minutes on_confirm pickup and delivery ranges should be as per @ondc/org/TAT

Explanation: The store’s pickup location and the customer’s delivery location are only 300m apart. That is the reason we have mentioned the TAT as 6 minutes. All the mentioned time ranges fall under the mentioned TAT.

on_status (picked) as per provided invoice, payment method is cash, but as per order details its prepaid (please explain) Resolution: We will resubmit the logs after resolving this issue.

So we will be resubmitting the Flow 1 and Flow 2 to address the category issue of the product that falls under Health and wellness and Invoice payment type issue.

sahil-ondc commented 1 week ago

item.quantity.unitized.measure should be mapped correctly (ex: rin ala fabric whitener 500 milli litre, it should have unit as millilitre not unit 1) => should be done
how an fulfillment is having @ondc/org/TAT as 6 minutes (P0DT6M) while time_to_ship is 5 minutes => still time_to_ship is 5min, TAT cannot be 6min

@techopendhi

techopendhi commented 1 week ago

@sahil-ondc

Thank you for your prompt reply.

As mentioned by you we will be rectifying the "item.quantity.unitized.measure".

For @ondc/org/TAT we need your assistance, our current approach is as follows:

Time to Ship: 5 min Store Location: 17.462485,78.365312 Delivery Location: 17.464141,78.366162

Formula: O2D TAT = max(O2S for all items) + S2D;

As per this formula, O2S is 5mins and S2D is 1min as we have calculated using the Google Places and the concluded values is 6 mins.

Please guide us whether we need to add any buffer value in the duration provided by the google API or are there any additional factors that we need to consider.

sahil-ondc commented 1 week ago

@techopendhi , Please provide realistic values of Pickup and Delivery time ranges. 6 minutes delivery does not seems realistic.

techopendhi commented 1 week ago

@sahil-ondc

We have considered such a short delivery distance for log creation only, as the time ranges needs to be between the provide TAT. But as mentioned by you we will be increasing the distance for the delivery location without making any changes in the existing formula.

Let me know if you have any suggestions.

techopendhi commented 1 week ago

@sahil-ondc

We are submitting the PR for Flow1 and Flow 2 by resolving the following points as per your feedback:

item.quantity.unitized.measure should be mapped correctly (ex: rin ala fabric whitener 500 milli litre, it should have unit as millilitre not unit 1) Explanation: We have updated the the product unit of measure.

is only Cleaning & Household supported ? Explanation: No, we are supporting all the categories that fall under RET10 but for the logs submission we are using Cleaning and Household.

Other Flows on_select how an fulfillment is having @ondc/org/TAT as 6 minutes (P0DT6M) while time_to_ship is 5 minutes on_confirm pickup and delivery ranges should be as per @ondc/org/TAT

Resolution: As discussed with you we will be increasing the distance for the delivery location without making any changes in the existing formula.

on_status (picked) as per provided invoice, payment method is cash, but as per order details its prepaid (please explain) Resolution: We have updated the payment type in the invoice.

sandeepshahi commented 1 week ago

Flow 1

/on_search

why are escape characters used in the code? string values should be provided without escape characters
why are veg/non_veg categorization provided for cleaning and household products
Are cleaning and household products going to be sold hyperlocally?

/on_search (inc)

delta changes must be provided in incremental call
are all the scenarios of incremental refresh supported, as mentioned in the contract?

Flow 2

/on_confirm

how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller?

/track

must be supported since tracking = "true"

Flow 6

/on_update (part cancel)

how can seller part cancel the order even before accepting it?

@techopendhi

sandeepshahi commented 1 week ago

@techopendhi, please fix the above issues and acknowledge here once fixed.

techopendhi commented 1 week ago

Hi @sandeepshahi ,

Feedback: Flow 1 /on_search why are escape characters used in the code? string values should be provided without escape characters: Explanation: Not able to replicate

Feedback: Flow 1 /on_search why are veg/non_veg categorization provided for cleaning and household products Explanation: According to the contract and as said in call, we need to provide this information in all cases of Grocery. Also, If it's not included, the utility will produce an error.

Feedback: Flow 1 /on_search Are cleaning and household products going to be sold hyperlocally? Explanation: Yes

Feedback: Flow 1 /on_search (inc) delta changes must be provided in incremental call Explanation: For item with id I51421 cancellable state was changed false->true

Feedback: Flow 1 /on_search (inc) are all the scenarios of incremental refresh supported, as mentioned in the contract? Explanation: Covered

Feedback: Flow 2 /on_confirm how can estimated pickup/delivery time ranges be provided even before the order is accepted by the seller? Explanation: We provide an estimated delivery time based on the location, pickup, and other factors. This is an optional field, but we're including it for your convenience.

Feedback: Flow 2 /track must be supported since tracking = "true" Explanation: Not required in logs

Feedback: Flow 6 /on_update (part cancel) how can seller part cancel the order even before accepting it? Explanation: We have provision to part cancel the order when order is "Created" as well as "Accepted"