ONDC-Official / v1.2.0-logs

Retail and Logistics Logs for 1.2.0
9 stars 248 forks source link

Channelier - LBNP - compliance check #984

Closed abhinavv245 closed 5 months ago

abhinavv245 commented 6 months ago

Multiple issues identified. Kindly use the log verification tool to test the logs and rectify the issues at your end before submitting.

Kindly provide complete flows with search, on_search for each flow for a transaction. Tracking needs to be implemented.

Also, please test with any other NP like MP2, shadowfax or Mahindra logistics as there are some issues with ref LSP app currently due to which the logs cannot be reviewed with it.

@itsRajatkumar

abhinavv245 commented 6 months ago

All Flows

/search

/confirm

/on_status

/track

@itsRajatkumar

BLR-0118 commented 6 months ago

Flow 1

  1. /search:

    • order prep time (provider.time.duration) of 48 hrs is not correct for hyperlocal; LSPs use this to schedule their rider allocation algos, hence, pls use realistic values for this;
  2. /init:

    • payment.collected_by should be "BAP" (i.e. LBNP collects from SNP & pays LSP); this is the only logistics payment mode available today;
  3. /confirm:

    • if pickup code is of type OTP ("3"), pls use the fulfillment.start.authorization struct;

Flow 3

BLR-0118 commented 6 months ago

@itsRajatkumar - pls fix the above & share logs for Flow 3 (cancellation by LBNP due to TAT breach);

BLR-0118 commented 5 months ago

Flow 3

  1. /search:

    • order preparation time (provider.time.duration) needs to be provided for hyperlocal;
  2. /confirm:

    • /search has request for LSP with OTP authorization (at pickup) but pickup confirmation code used here is not OTP (type of "3" - other);
    • for OTP to be used, the fulfillment.start (or end).authorization struct needs to be used (with time validity);
BLR-0118 commented 5 months ago

@itsRajatkumar - clearing logs for v1.2.0 but pls make sure the above are fixed;