ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board
21 stars 281 forks source link

Rapidor | B2B | v2.0.2 | Compliance Check #1336

Open tanyamadaan opened 8 months ago

tanyamadaan commented 8 months ago

Domestic flow 1:

{ "Message": { "search_0": { "RGC-end-Err": "Reverse Geocoding for end failed. Area Code 560001 not matching with 12.976594,77.599271 Lat-Long pair.", "CityCode-Err": "CityCode 0788 should match the city for the fulfillment end location 560001, 080" } } }

Domestic Flow 4:

{ "Schema": { "schemaErr0": "/confirm/0/message/order/quote/price/value must be equal to constant (42.83)", "schemaErr1": "/on_confirm/0/message/order/state must be equal to one of the allowed values (Created,Accepted,Cancelled)", "schemaErr2": "/on_confirm/0/message/order/quote/price/value must be equal to constant (42.83)" }, "Message": { "search_0": { "RGC-end-Err": "Reverse Geocoding for end failed. Area Code 560001 not matching with 12.976594,77.599271 Lat-Long pair.", "CityCode-Err": "CityCode 0788 should match the city for the fulfillment end location 560001, 080" } } }

Domestic Flow 5:

{ "Schema": { "schemaErr0": "/on_select/0/message/order/quote/breakup/0/item must have required property 'quantity'", "schemaErr1": "/on_select/1/context/message_id Message ID for on_action API should be same as action API: \"4731c6d6-e14e-43b8-ba69-2f5586503fbd\"", "schemaErr2": "/init/0/message/order/billing/name must NOT have fewer than 3 characters", "schemaErr3": "/confirm/0/message/order/quote/price/value must be equal to constant (9.06)", "schemaErr4": "/on_confirm/0/message/order/quote/price/value must be equal to constant (9.06)" }, "Context": { "on_select_0": { "tmpstmpErr": "Timestamp mismatch for /on_select " } }, "Message": { "search_0": { "RGC-end-Err": "Reverse Geocoding for end failed. Area Code 560001 not matching with 12.976594,77.599271 Lat-Long pair.", "CityCode-Err": "CityCode 0788 should match the city for the fulfillment end location 560001, 080" } } }

@rapidor @sanushilshad

tanya-ondc commented 8 months ago

Flow1

As discussed, kindly submit logs with a different NP.

/on_search:

/select:

/on_init:

/on_confirm:

abhinavv245 commented 8 months ago

Buyer App domestic

Flow 1

/on_search

/on_select

/init

/on_init

/confirm

/status

Flow 3

/on_confirm

Flow 4

/on_select (Reject)

sanushilshad commented 8 months ago

@abhinavv245 @ondc/org/item_quantity will be updated to the available quantity, subsequently price will be updated (@ondc/org/item_quantity/count * item/price/value)

can u elaborate on this point?

abhinavv245 commented 8 months ago

@sanushilshad The item quantity may either be 0, indicating it is completely out of stock, or a reduced quantity that is currently in stock (available). If the item quantity is 0, signifying it is completely out of stock, or if there is a reduced quantity available, the price will be adjusted accordingly based on the quantity.

abhinavv245 commented 8 months ago

Seller App

Flow 1 (Seller Domestic)

/on_select

/init

/on_init

/on_status

Flow 4

/on_select (Reject)

Is BAP collecting prepaid payment flow implemented?

sanushilshad commented 8 months ago

@abhinavv245 Include packing, tax, misc, discount charges in the quote breakdown unless their values are zero. The above fields in the quotes in flow, can u send the exact field which is not there?

abhinavv245 commented 8 months ago

@sanushilshad What I meant was include these charges only if their value is not zero. If the values is zero, that shall not be included except the delivery charge, that needs to be provided if the fulfillment is 'Serviceable'.

sanushilshad commented 8 months ago

@abhinavv245 is it mandatory to not include the values with zero?

abhinavv245 commented 8 months ago

@sanushilshad It is a suggestion.

sanushilshad commented 8 months ago

@abhinavv245 noted

sanushilshad commented 8 months ago

Are updates for other fulfillment states being sent? (Pending, Agent-assigned) @abhinavv245 no, we are only using three status for now picked-up, Out-for-delivery, and delivered

sanushilshad commented 8 months ago

@abhinavv245 BAP payment for RFQ flow is not yet implemented yet.

tanya-ondc commented 8 months ago

RFQ Flow Seller App

All flows

/on_search

/select

/on_select

/on_init

Flow 5

/on_select

Flow 6

@sanushilshad

abhinavv245 commented 8 months ago

Non RFQ Flow - Buyer App

/search

/init

/on_init

Flow 5

/on_select (Reject)

@sanushilshad

abhinavv245 commented 8 months ago

Non RFQ Domestic Buyer

Flow 1

/on_init

Flow 4

/on_select (Reject)

Flow 5

/select

/on_select (Reject)

Note: Kindly test with another seller NP and resolve all the previously identified issues. Also, RFQ Buyer app logs needs resubmission.

@sanushilshad

sanushilshad commented 8 months ago

@abhinavv245 can you point out the reasons for RFQ Seller App log rejection?

abhinavv245 commented 7 months ago

RFQ Domestic Seller

Flow 1

/on_select

/on_init

/on_select (Reject)

sanushilshad commented 7 months ago

@abhinavv245

abhinavv245 commented 7 months ago

@sanushilshad Yes, it is mandatory even if it is rejected. Only in case the location is non-serviceable, delivery charges will not be provided.

sanushilshad commented 7 months ago

@abhinavv245 -Total price of the item with item id BESAN-KP-30KG is not in sync with the unit price and quantity. "price": { "currency": "INR", "value": "245500.00" }, "@ondc/org/item_quantity": { "count": 100 }, "item": { "price": { "currency": "INR", "value": "2455.00" },

this is correct, right?

abhinavv245 commented 7 months ago

@sanushilshad this is for flow 6 : { "title": "LAXMI BHOG KADI PAKODA BESAN 30 KG", "@ondc/org/item_id": "BESAN-KP-30KG", "@ondc/org/title_type": "item", "price": { "currency": "INR", "value": "2455000.00" }, "@ondc/org/item_quantity": { "count": 100 }, "item": { "price": { "currency": "INR", "value": "2455.00" }, "quantity": { "available": { "count": "100" }, "maximum": { "count": "100" } } } },

sanushilshad commented 7 months ago

@abhinavv245 https://github.com/ONDC-Official/verification-logs/issues/1347

the above error in spicemoney issue board, can u specify in which status log is the issue happening?

abhinavv245 commented 7 months ago

@sanushilshad The issue is in /on_init API. Have updated the board.

abhinavv245 commented 7 months ago

@sanushilshad Catalog for construction and building looks fine.

abhinavv245 commented 7 months ago

@sanushilshad Please include the below for all transactions:

/on_init

/confirm

abhinavv245 commented 7 months ago

RFQ Seller App

Flow 1

/on_search

/on_init

Flow 5 & 6

/on_select (Reject)

Note: Kindly resolve all previous issues before submitting the logs again

@sanushilshad

tanya-ondc commented 7 months ago

RFQ Seller App

Flow1

/on_confirm:

/on_status:

"@ondc/org/settlement_basis", "@ondc/org/settlement_window", "@ondc/org/withholding_amount" missing in /on_status.

Flow4

@sanushilshad

sanushilshad commented 7 months ago

Supported payment options in /on_search includes pre-fulfillment (collected by BPP). However, this is not developed by Rapidor yet. How will you handle the select request, if a buyer selects pre-fulfillment payment option.

@tanya-ondc this will be removed in this production at seller side, and at buyer side at UI level. as this field is being used for Non-RFQ flow

tanya-ondc commented 7 months ago

shud be removed in pre-production itself, if its not supported for now.

tanya-ondc commented 7 months ago

Seller App Logs

Rapidor B2B RFQ Seller App logs Approved. Rapidor B2B Non-RFQ Seller App logs yet to be Submitted. Note - Prepaid payment, Cancellation flows not yet implemented.

Buyer App Logs

Yet to be re-submitted.

@sanushilshad

abhinavv245 commented 7 months ago

Non RFQ Flow Seller App

Flow 1

/on_search

/confirm

/on_status

Flow 3

/on_init

/confirm

Flow 4

Note: Flow 5 is missing

@sanushilshad

sanushilshad commented 7 months ago

@abhinavv245

for the above issue, from which api will the buyer app set the settlement_window, withholding_amount and settlement_basis.

and for the above issue can you elaborate a little

abhinavv245 commented 7 months ago

@sanushilshad

sanushilshad commented 7 months ago

https://github.com/ONDC-Official/ONDC-RET-Specifications/blob/release-2.0.2/api/components/Examples/B2B_json/on_init/on_init_domestic_payment_BPP_Non_RFQ.json

@abhinavv245 then the above example needs to remove the settlement details, right?

abhinavv245 commented 7 months ago

@sanushilshad in this example, the payment is collected by BPP, so it will set these details in on_init.

abhinavv245 commented 7 months ago

Non RFQ Flow Buyer App

Flow 2

/confirm

/on_status

Flow 3

/on_status

Note: Flow 5 is missing

@sanushilshad

abhinavv245 commented 7 months ago

All Flows (Non RFQ Buyer App)

/on_search

/on_select

/on_status

@sanushilshad

sanushilshad commented 7 months ago

@abhinavv245 Delivery charges are not required in quote/breakup when fulfillment is 'Non-serviceable' (Flow 5) this is optional right?

abhinavv245 commented 7 months ago

@sanushilshad delivery charge to be included only if fulfillment state code is "Serviceable"

sanushilshad commented 7 months ago

@abhinavv245 but we can add the delivery break up with value as 0, right?

tanyamadaan commented 7 months ago

Electronics catalog:

@sanushilshad

abhinavv245 commented 7 months ago

Non-RFQ Seller App (All Flows)

/on_search

@sanushilshad

sanushilshad commented 7 months ago

@abhinavv245 serviceability is selected as hyperlocal (Type 10), however the value is 2440 km (what is the logic behind this, either you support PAN india or use geojson polygon)

Can you elaborate on what is the issue?

abhinavv245 commented 7 months ago

@sanushilshad many of the buyer apps cap their serviceability upto few kms for hyperlocal, so in case you are sending your serviceability as hyperlocal and providing value as 2440km, your provider wont be visible. So choose the appropriate serviceability.

sanushilshad commented 7 months ago

@abhinavv245 ok noted. what is the maximum value that can be used for hyperlocal?

abhinavv245 commented 7 months ago

@sanushilshad Ideally should not be more than 50km.

sanushilshad commented 7 months ago

@abhinavv245 lets say I want the servicability to be entire rajasthan and gurjrat, then can't i set the the radius as 400km?

abhinavv245 commented 7 months ago

@sanushilshad Please update attributes in /on_search as per the taxonomy, ram and item condition are mandatory attributes, refer to on_search example for smartphones

sanushilshad commented 7 months ago

@abhinavv245 are all the fields mentioned smartphones mandatory or is the ram and item condition is the only ones missing from the attributes for the submitted electronics log?

abhinavv245 commented 7 months ago

Non RFQ Buyer App

/on_init

/confirm

/on_confirm

@sanushilshad