Bizom B2B BAP - compliance check

abhinavv245 commented 10 months ago

@samarthpatel-bizom Kindly submit logs for version 2.0.2 as per test cases.

samarthpatel-bizom commented 10 months ago

@abhinavv245 we have followed https://docs.google.com/document/d/10ouiTKLY4dm1KnXCuhFwK38cYd9_aDQ30bklkqnPRkM/edit#heading=h.b8pvm1qdqxa3 doc to generate logs.

Bizom BAP does not support prepaid order (flow-2) and RFQ (fllow-3) hence we have submitted flow-1 and flow4. Please let me know what is missing in here.

abhinavv245 commented 9 months ago

Flow 1 & 4

/search

intent/fulfillment must have required property 'type'
fulfillment/stops must have required property 'type'

/on_search

incorrect schema for tags (must have required property 'descriptor') (BAP should validate and send NACK)
Reverse Geocoding for location ID L1 failed for provider with id '10715f65-90bb-4d9c-9555-ee570ce6eb98'. Area Code 626201 not matching with 9.451750,77.833075 Lat-Long pair.

/select

order/provider must have required property 'ttl' (for RFQ, should be equal to context/ttl)
'id', 'type' are missing in /fulfillments and 'tags' are missing in /items
Provider with id 'e0984602-7df7-4a55-9990-69d90f6ec572' does not exist in the catalog provided in /on_search (Flow 1)
Item Id 'LALX0511001025' does not exist in /on_search (Flow 1)

/init

order/fulfillments/0 must have required property 'id'

/on_init

order/payments must have required properties '@ondc/org/settlement_basis','@ondc/org/settlement_window','@ondc/org/withholding_amount',"type',"collected_by"
settlement details will be sent by BAP, in case payment is collected by BPP
context/timestamp difference between on_init and init should be within 5 seconds

/confirm

order need NOT have additional properties (ttl)
order/quote/breakup must have required property '@ondc/org/item_id'
order/payments must have required properties '@ondc/org/settlement_basis','@ondc/org/settlement_window','@ondc/org/withholding_amount'
payments/@ondc/org/buyer_app_finder_fee_amount should match with the one provided in /search

/on_confirm

context/timestamp difference between on_confirm and confirm should be within 5 seconds
payments/params/transaction_id cannot be provided until the order is delivered for payment/type 'ON-FULFILLMENT'
settlement details provided by buyer app cannot be changed by BPP (BAP should validate and send NACK in such cases)

Note: looks like the testing has been done on version 2.0.1, Kindly test as per version 2.0.2. Also, provide the complete transaction logs for both the flows including search, on_search

@samarthpatel-bizom

samarthpatel-bizom commented 9 months ago

incorrect schema for tags (must have required property 'descriptor') (BAP should validate and send NACK) -> We have currently disabled schema validation.

@abhinavv245 have addressed your concerns please check. https://github.com/ONDC-Official/verification-logs/pull/1380

abhinavv245 commented 9 months ago

@samarthpatel-bizom Schema validation is mandatory and needs to be handled by sending NACK.

abhinavv245 commented 9 months ago

Non RFQ Buyer App

All flows

/search

fulfillment/stops/type must be equal to 'end'
is BAP charging 10 percent buyer finder fee?

/init

provider need not have additional properties (ttl)
payments/0 must have required property 'collected_by'

/on_init

fulfillments/0/id must be equal to constant (1) (should be validated by BAP)

**/confirm***

/payments must have required properties '@ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount' (currently, they are placed within the settlement details object)
order/tags must not have fewer than 3 items (bpp_terms, bap_terms are missing)
In /items, 'fulfillment_ids' mismatch from /select
Transaction ID in payments/params cannot be provided when the payment status is 'NOT-PAID'

/on_status

/payments must have required properties '@ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount'
Transaction ID in payments/params cannot be provided when the payment status is 'NOT-PAID'

@samarthpatel-bizom

abhinavv245 commented 9 months ago

Non RFQ Buyer App

Flow 1

/on_init

In /items, 'fulfillment_ids' mismatch from /on_select (BAP should validate)
order/fulfillments/0/id mismatch from /on_select

/on_confirm

settlement details should be of the buyer app when BPP is collecting the payment (BAP should validate)

Flow 4 & 5

similar issues

/init

/order/fulfillments must have required property 'id'

@samarthpatel-bizom

samarthpatel-bizom commented 8 months ago

@abhinavv245 issues addressed please check the updated logs https://github.com/ONDC-Official/verification-logs/pull/1431

abhinavv245 commented 8 months ago

/on_cancel

message/order must have required property 'id'",
message/order must have required property 'state'",
message/order must NOT have additional properties (status)",
message/order must NOT have additional properties (order_id)",
message/order/items must have required property 'payment_ids'",
message/order/fulfillments must have required property 'state'",
message/order/quote price does not match the total breakup price
message/order/quote/breakup/price/value must be string",
message/order/payments must have required property 'id'

@samarthpatel-bizom

ONDC-Official / verification-logs