Rapidor B2B (Exports) - compliance check

abhinavv245 commented 7 months ago

All Flows

/on_search

quote realistic price for the items in catalog

/select

order/provider must have required property 'ttl'
order/items/0 must have required property 'fulfillment_ids'
order/fulfillments/0 must have required property 'id' ,'type'

/on_select

order/items/0 must have required property 'fulfillment_ids'
order/payments/0 must have required property 'collected_by'
Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'
tags (DELIVERY_TERMS) are missing in /fulfillments
Message Id cannot be same for different sets of APIs (for both on_select calls)

/init

order/provider need not have additional properties (ttl)
order/payments/0 must have required property 'collected_by'

/on_init

order/fulfillments/0/@ondc/org/TAT must be equal to constant (P2D)
order/payments/0 must have required property 'type', 'collected_by'
order/tags (bpp_terms) are missing

/confirm

/order/payments/0 must have required properties '@ondc/org/settlement_basis', '@ondc/org/settlement_window', '@ondc/org/withholding_amount'
Transaction ID in payments/params cannot be provided when the payment status is 'NOT-PAID'

/on_status

Transaction ID in payments/params cannot be provided when the payment status is 'NOT-PAID'

@sanushilshad

tanyamadaan commented 4 months ago

@sanushilshad @SignCatch-NP The logs were submitted without log utility report. All the issues are captured via log utility. Requesting to run the utility before submitting the next iteration.

sanushilshad commented 4 months ago

@abhinavv245 @tanyamadaan https://github.com/ONDC-Official/verification-logs/tree/main/B2B/Export-2.0.1/Rapidor/RFQ%20Seller%20App%20Export%20Flow this is the latest log that were submitted yesterday. The one you are looking at is the previously submitted logs (submitted a few months ago)

abhinavv245 commented 4 months ago

RFQ Seller APP

/on_search

enum to be used for veg or non_veg is 'yes' in items/tags

/on_select

on_select/0/context/ttl must be equal to constant (PT30S)
Delivery terms (INCOTERMS) are required for exports in /fulfillments/tags

@sanushilshad

sanushilshad commented 4 months ago

@abhinavv245

enum to be used for veg or non_veg is 'yes' in items/tags
By this do you mean that we can't use no as value?

abhinavv245 commented 4 months ago

@sanushilshad - correct. only 'yes' to be used, you may use veg or non_veg as the code.

tanyamadaan commented 4 months ago

@ashok-ai

I can see that proxtera buyer app is accepting the bpp_terms in /confirm API. I hope you are aware of what is being accepted over here. As confirm, on_confirm becomes the final digital contract. Refer here - https://github.com/ONDC-Official/verification-logs/blob/main/B2B/Export-2.0.1/Rapidor/RFQ%20Seller%20App%20Export%20Flow/Flow%201/confirm.json

tanyamadaan commented 4 months ago

Flow 6 (Item quantity unavailable)

/select

•⁠ ⁠both the select calls are for the same quantity? (ideally the available quantity for which the quote is provided should be selected)

/on_select

•⁠ ⁠on_select/0/context/ttl must be equal to constant (PT30S) •⁠ ⁠in select, the quantity selected is 101, but in on_select items/quantity is 99 (how is that changed?)

@sanushilshad

sanushilshad commented 4 months ago

@tanyamadaan

on_select/0/context/ttl must be equal to constant (PT30S)
In the logs for both on_select payloads the ttl is PT30S

abhinavv245 commented 4 months ago

@sanushilshad Please check for Flow 1

tanyamadaan commented 4 months ago

Logs cleared for Rapidor BPP - v2.0.2 B2B Exports.

abhinavv245 commented 3 months ago

RFQ Buyer App with Proxtera

Flow 1 & 5

Export License is required in creds in /providers (/on_search)
order must have required property 'cancellation_terms' (on_init, confirm, on_confirm)
Delivery proof (fulfillments/stops/end/instructions/images) is required once the order is delivered (/on_status)

Flow 6

similar issues
Error object with appropriate error code should be sent when the selected item quantity is not available (/on_select)

@ashok-ai

abhinavv245 commented 2 months ago

Buyer App

Seller App collecting payment flow is mandatory for Buyer apps

Flow 6

/on_select (reject)

why is items/selected/count changed? should be the one buyer selected (2000)

@sanushilshad

sanushilshad commented 2 months ago

@abhinavv245 https://github.com/ONDC-Official/verification-logs/tree/main/B2B/Export-2.0.1/Rapidor/RFQ%20buyer%20App%20Export%20Flow These are the logs that were submitted. I can't find the above errors in the above.

sanushilshad commented 2 months ago

@tanya-ondc @abhinavv245 , We have disabled the PRE-FULFILLMENT option for RFQ temporarily (until it's implementation).

ONDC-Official / verification-logs