Proxtera BPP v.2.0.2 - compliance check

abhinavv245 commented 8 months ago

Flow 1

/on_search

providers/location details are not correct
cancellation_terms must NOT have additional properties (refund_eligible)
return_location is not valid in return terms
providers/time is not a valid attribute
'POST-FULFILLMENT' is currently not enabled for B2B, should be removed from payments along with its mapping in /items
items/quantity/unitized/measure/value should be provided (why is it NA?), same goes for other 'value' fields
why are multiple g3 tags used in items/tags
num_price_slabs in g3 tag in /items has an invalid value
serviceability construct is not defined correctly (type, val, unit are not provided)
country of origin is missing in /items/tags
seller_terms tag is missing in providers/tags,
provide a valid 'seller_id_no' in 'seller_id' code
for domain RET10, why are category_ids used for RET15 in /items
FSSAI_LICENSE_NO is mandatory for RET10
items/cancellation_terms/fulfillment_state/descriptor/code must be equal to one of the allowed values (Pending,Searching-for-Agent,Agent-assigned,Order-picked-up, Out-for-delivery)

/select

In /items , fulfillment_ids should be mapped to the selected fulfillment mode
'POST-FULFILLMENT' is currently not enabled

/on_select

In /items, fulfillment_ids should be mapped to the fulfillment id generated by the seller app
fulfillments/tags (DELIVERY_TERMS) are missing

/on_init

all terms should be included in bpp_terms tags

/on_confirm

'confirmed' is not a valid fulfillments/state/descriptor/code (should be 'Pending)

/on_status

"picked_up" is not an appropriate label for 'Invoice' in /documents
order/updated_at should be updated w.r.t context/timestamp for each fulfillment state update

Flow 2

similar issues as above

/on_confirm

BPP should share the payment gateway link (payments/uri) along with TTL (payments/tags) for Prepaid order

Note: Flow 5 (Modified terms and conditions) needs to be provided as well

@ashok-ai

abhinavv245 commented 7 months ago

Flow 1

/on_search

items/payment_ids - 3 is not applicable as it is not defined in the payments array
providers/creds are required for exports
SGD is not a valid country code for Singapore (SGP)
country code to be used for country of origin in items/tags
Location id/s L1 in /items does not exist in /providers/locations
time_to_ship in g2 cannot be an empty string

/on_select

ttl should be kept constant PT30S in all /on_action APIs
provider_id is an invalid attribute in /fulfillments

/on_confirm

invalid bap_terms in order/tags, duplicate bpp_terms (all the terms should be listed under one bpp_terms tag if provided)
context/timestamp difference between on_confirm and confirm should be within 5 seconds
provider/ttl is not required (in on_status as well)

Flow 2

similar issues

/on_confirm

payments/uri (not URI) and payments/tags (dsa and signature as well) are required when BPP is collecting prepaid payment

@ashok-ai

abhinavv245 commented 7 months ago

Flow 1

/on_init

context/ttl must be equal to constant (PT30S)

/on_confirm

fulfillments/start/location/id - L1 is not matching with the provider location id - P_L1 provided in /on_search"

Flow 5

/on_select (reject)

Appropriate error code to be used for buyer terms not acceptable

@ashok-ai

tanyamadaan commented 6 months ago

How do you verify the zip codes. For ex. is "area_code": "0213280" a valid ghana zip code?
on_search - "platform_id" - invalid attribute in providers.items
on_search - provider.tags.seller_id - cannot be gst. Probably, it would be tin.
on_search - provider.tags.seller_terms.gst_credit_invoice - cannot be Y.
on_select - "@ondc/org/TAT" = P1D. Are you validating this?

Flow 2 and 4 are not valid as prepaid payment is not yet enabled for B2B Exports

@ashok-ai

srijit-prox commented 2 months ago

Hi @tanyamadaan the changes has been made and already merged. @abhinavv245 @ashok-ai

tanyamadaan commented 2 months ago

@srijit-prox I can see the latest logs from May7th only. Can you please submit the latest logs.

srijit-prox commented 2 months ago

@tanyamadaan can you check this PR? https://github.com/ONDC-Official/verification-logs/pull/1524

tanyamadaan commented 2 months ago

I have already checked this PR @srijit-prox Can you please test the flows and submit latest logs.

tanyamadaan commented 1 month ago

Flow1

/on_search:

Please use a valid UPC/EAN/any custom code for items.descriptor.code. Use

/on_select:

COMM_CHANNEL tag group should not be present in on_select.

/on_init:

Is proxtera sure of the cancellation terms being sent as part of on_search and on_init?

Flow 6

/on_select

•⁠ ⁠In /items, 'quantity' mismatch from /select for item with id 66fbfca90d808f50539f46be

@srijit-prox

tanyamadaan commented 1 month ago

BPP v2.0.2 Logs approved.

ONDC-Official / verification-logs