TRV10 - PreProd - Quick Ride - Logs for all flows

[sourabhsaini11]

@shobhanaquickride, logs are to be reviewed under 2.0.0 or 2.0.1?

[sourabhsaini11]

@shobhanaquickride, kindly get the below issues fixed common_issues

• instructions is missing in fulfillments.stops
• valid breakup title are BASE_FARE & DISTANCE_FARE only, remove additional titles from quote
• either remove empty tags from fulfillments or include ROUTE_INFO tag-group as well (/select onwards)
• tags should contain FARE_POLICY & INFO tag-group at items (/select onwards)
• missing tags in SETTLEMENT_TERMS tag-group
• provide.id should be a valid id instead of 'Quick Ride' (Warning)

on_search

• remove empty tags from items

• provide."id": "Quick Ride"?

on_init

• payment_ids is missing in items
• id is missing in payments

confirm

• billing in missing
• id is missing in payments

on_confirm

• payment_ids is missing in items
• status & valid_to is missing in stops.authorization
• id is missing in payments

on_update

• created_at should match /on_confirm created_at
• vehicle is missing in fulfillments
• payment_ids is missing in items
• status & valid_to is missing in stops.authorization
• id, params, type are missing in payments
• message_id should be different between unsolicated on_update calls

on_status

• payment_ids is missing in items
• make is missing in fulfillments.vehicle
• status & valid_to is missing in stops.authorization
• id, params, type & tags are missing in payments
• created_at should match /on_confirm created_at
• cancellation_fee value changed between /on_confirm & /on_status call in cancellation_terms

on_cancel

• payment_ids is missing in items
• make is missing in fulfillments.vehicle
• status & valid_to is missing in stops.authorization
• id, params, type & tags are missing in payments
• created_at should match /on_confirm created_at
• cancellation_fee value changed between /on_confirm & /on_status call in cancellation_terms
• CANCELLATION_CHARGES & REFUND are missing in quote.breakup

[shobhanaquickride]

All comments are fixed except for the following:

a) missing tags in SETTLEMENT_TERMS tag-group: All settlement terms which come from the buyer app will be relayed as-is in the subsequent responses since buyer app will decide how it needs to receive the settlement

b) billing in missing: id is missing in payments: Can't fix since this comes from BAP (Pramaan in our case from where logs are generated)

c) status & valid_to is missing in stops.authorization: Mobility specification doesn't explain this: https://ondc-official.github.io/mobility-specification/#attribute What are the valid values for status? As per one of the examples, updated to set the status as "CLAIMED" after the ride is started. Before that, the status is not set. What should it be set to?

[sourabhsaini11]

@shobhanaquickride, please fix the below issues as well common_issues

• additional attribute model sent in fulfillments.vehicle
• additional title's GST_ON_RIDE_FARE, SERVICE_FEES & GST_ON_SERVICE_FEES present in quote.breakup
• tags COURT_JURISDICTION, MANDATORY_ARBITRATION, SETTLEMENT_TYPE, SETTLEMENT_BASIS & SETTLEMENT_WINDOW are missing in SETTLEMENT_TERMS tag-group. Following tags needs to be defined by BPP (Please refer TLC-UI for more info)
• price/percentage/value should be precise upto 2 decimal places
• tag WAYPOINTS is missing in ROUTE_INFO tag-group
• tag NIGHT_SHIFT_START_TIME & NIGHT_SHIFT_END_TIME should be in HH:MM:SS format
• short_desc is missing in stops.instructions(/on_action calls only)
• on_status api capturing payment status as PAID is missing
• post on_update_driver_assigned, on_status should be used instead of on_update for following calls:- on_update_driver_enroute_pickup, on_update_driver_arrived_pickup, on_update_ride_completed & on_update_ride_started

on_confirm

• created_at & updated_at should be either equal or less than context.timestamp

on_update

• params is missing in payments
• tags are incomplete in payments
• vehicle is missing
• status is missing in stops.authorization (valid status values are CLAIMED/UNCLAIMED)

on_status

• state should be RIDE_ENROUTE_PICKUP instead of RIDE_ASSIGNED as on_status is being called post on_update_driver_enroute_pickup
• params & tags are missing in payments

Flow-2 on_cancel

• CANCELLATION_CHARGES value mismatch between soft & confirm on_cancel
• params & tags are missing in payments
• status is missing in stops.authorization

Flow-3

• params & tags are missing in payments
• status is missing in stops.authorization