ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board
22 stars 304 forks source link

LoadShare - Compliance Check #183

Open BLR-0118 opened 2 years ago

BLR-0118 commented 2 years ago
  1. /on_search & other APIs - timestamp not valid format;
  2. /on_search & other APIs - time.range.start/end not valid formats;
  3. /on_search - how's the price.value 0 for standard delivery?
  4. /on_search - TAT of "P1D" means 1 day turnaround time? Typically, TAT is calculated when order is marked "ready to ship";
  5. /on_init - how can the payment transaction id be the same as Context.transaction_id?
  6. /on_init - how can the payment transaction id be generated when payment not yet collected?
  7. /on_init - search request was for COD, so how's the payment having range of 1 month?
  8. /on_confirm - there's no fulfillment state of "Created";
  9. /on_status - fulfillment state isn't as per the updated list;
  10. /on_update - same as 9;
  11. All APIs have ttl of 5s which should be changed to 30s;
BLR-0118 commented 2 years ago

@Poornima-Aithal

Poornima-Aithal commented 2 years ago

@BLR-0118 /on_search & other APIs - timestamp not valid format; Fixed /on_search & other APIs - time.range.start/end not valid formats; Fixed /on_search - how's the price.value 0 for standard delivery? Price is 0 because PhonePe wanted it to be like that. This will apply only for PhonePe or any other Buyer/Seller NPs who have an offline agreement with LoadShare /on_search - TAT of "P1D" means 1 day turnaround time? Typically, TAT is calculated when order is marked "ready to ship"; P1D means 1 day turnaround. We had discussed this - When a logistics buyer searched for a provider then we give an approx TAT. After order is marked ready to ship, we send more accurate time range

For all the below payment related questions: As of now we support only off network payment settlements. So can we skip the payment object altogether in our on_init? /on_init - how can the payment transaction id be the same as Context.transaction_id? /on_init - how can the payment transaction id be generated when payment not yet collected? /on_init - search request was for COD, so how's the payment having range of 1 month?

/on_confirm - there's no fulfillment state of "Created"; Fixed /on_status - fulfillment state isn't as per the updated list; Fixed /on_update - same as 9; Fixed All APIs have ttl of 5s which should be changed to 30s; Fixed

BLR-0118 commented 2 years ago

@dashbitla-ib - logs here