ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board
21 stars 281 forks source link

Perfectfit Systems - compliance check #549

Open sandeepshahi opened 1 year ago

sandeepshahi commented 1 year ago

Flow 1

/on_search /message/catalog/bpp/providers must have required property 'tags' (for serviceability construct) /message/catalog/bpp/providers/descriptor/images/0 must match pattern "^(?!\s*$).+.(jpeg|jpg|jfif|gif|png|ico)$" Either one of fixed or split timings for store should be provided ((frequency and times) or range) category_id should be one of the non deprecated categories /message/catalog/bpp/providers/items/0/category_id must be equal to one of the allowed values (Fruits and Vegetables,Masala & Seasoning,Oil & Ghee,Gourmet & World Foods,Foodgrains,Eggs, Meat & Fish,Cleaning & Household,Beverages,Beauty & Hygiene,Bakery, Cakes & Dairy,Kitchen Accessories,Baby Care,Snacks & Branded Foods,Pet Care,Stationery,Continental,Middle Eastern,North Indian,Pan-Asian,Regional Indian,South Indian,Tex-Mexican,World Cuisines,Healthy Food,Fast Food,Desserts,Bakes & Cakes,Beverages (MTO),Home Decor,Home Furnishings,Furniture,Garden and Outdoor Products,Home Improvement,Cookware and Dining,Storage and Organisation) one of the FSSAI_license_no in statutory_reqs_prepackaged_food should be provided /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/importer_FSSAI_license_no must be string /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/brand_owner_FSSAI_license_no must be string /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/other_FSSAI_license_no must be string /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food must match exactly one schema in oneOf /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/importer_FSSAI_license_no must be string /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/brand_owner_FSSAI_license_no must be string /message/catalog/bpp/providers/items/0/@ondc/org/statutory_reqs_prepackaged_food/other_FSSAI_license_no must be string Context timestamp for /search api cannot be greater than or equal to /on_search api

/select Item Id addidas_ondc_002 does not exist in /on_search for provider IGO_Seller_0001

/on_select /quote/breakup/3/price/value must be string /quote/breakup/4/price/value must be string /quote/breakup/5/price/value must be string /quote/breakup/9/price/value must be string /quote/breakup/10/price/value must be string /quote/breakup/11/price/value must be string /fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Serviceable,Non-serviceable) /fulfillments/1/state/descriptor/code must be equal to one of the allowed values (Serviceable,Non-serviceable) Timestamp for /select api cannot be greater than or equal to /on_select api Pre-order fulfillment state codes should be used in fulfillments[].state.descriptor.code item with id: addidas_ondc_002 is not present in /on_search available count can't be greater than maximum count for item id: addidas_ondc_002 delivery with id: addidas_ondc_001 in quote.breakup[1] does not exist in fulfillments[] packing with id: addidas_ondc_001 in quote.breakup[2] does not exist in fulfillments[] misc with id: addidas_ondc_001 in quote.breakup[5] does not exist in fulfillments[] delivery with id: addidas_ondc_002 in quote.breakup[7] does not exist in fulfillments[] packing with id: addidas_ondc_002 in quote.breakup[8] does not exist in fulfillments[] misc with id: addidas_ondc_002 in quote.breakup[11] does not exist in fulfillments[] discount price should be negative quote.price.value 515.3 does not match with the price breakup 568.3 Warning: Quoted Price in /on_select INR 200.6 does not match with the total price of items in /select INR 170 O2D in on_select can't be equal to O2S in /on_search can't be equal

/init gps coordinates in fulfillments[0].end.location mismatch in /select & /init address.area_code in fulfillments[0].end.location mismatch in /select & /init

/on_init /fulfillments/0/end/location/address must have required property 'building' /fulfillments/1/end/location/address must have required property 'building' /quote/breakup/3/price/value must be string /quote/breakup/4/price/value must be string /quote/breakup/5/price/value must be string /quote/breakup/9/price/value must be string /quote/breakup/10/price/value must be string /quote/breakup/11/price/value must be string /payment/@ondc/org/buyer_app_finder_fee_type must be equal to one of the allowed values (percent,amount) fulfillment id 1 does not exist in /on_select gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init address.area_code in fulfillments[0].end.location mismatch in /select & /on_init fulfillment id 2 does not exist in /on_select gps coordinates in fulfillments[1].end.location mismatch in /select & /on_init address.area_code in fulfillments[1].end.location mismatch in /select & /on_init Quoted Price 515.3 does not match with Net Breakup Price 568.3 in /on_init Quoted Price in /on_init INR 515.3 does not match with the quoted price in /on_select INR 568.3 Quote object mismatches in /on_select and /on_init

/confirm /message/order/fulfillments/0/end/location/address must have required property 'building' /message/order/fulfillments/1/end/location/address must have required property 'building' /message/order/quote/breakup/3/price/value must be string /message/order/quote/breakup/4/price/value must be string /message/order/quote/breakup/5/price/value must be string /message/order/quote/breakup/9/price/value must be string /message/order/quote/breakup/10/price/value must be string /message/order/quote/breakup/11/price/value must be string /message/order/payment/status must be equal to constant (PAID) /message/order/payment/type must be equal to constant (ON-ORDER) /message/order/payment/collected_by must be equal to constant (BAP) /message/order/payment/params must have required property 'transaction_id' fulfillment id 1 does not exist in /on_select payment.status should be "PAID" in case of pre-paid order(ON-ORDER) payment.type is expected to be ON-ORDER payment.collected_by is expected to be BAP Quote Objects in /on_select and /confirm do not match Quoted Price in /confirm INR 515.3 does not match with the quoted price in /on_select INR 568.3

/on_confirm /fulfillments/0/end/location/address must have required property 'building' /fulfillments/1/end/location/address must have required property 'building' /quote/breakup/0/@ondc/org/item_quantity/count must be integer /quote/breakup/3/price/value must be string /quote/breakup/4/price/value must be string /quote/breakup/5/price/value must be string /quote/breakup/6/@ondc/org/item_quantity/count must be integer /quote/breakup/9/price/value must be string /quote/breakup/10/price/value must be string /quote/breakup/11/price/value must be string /payment/type must be equal to constant (ON-ORDER) /payment/collected_by must be equal to constant (BAP) /payment/params must have required property 'transaction_id' fulfillments[].start.location.address is not required Timestamp for /confirm api cannot be greater than or equal to /on_confirm api order.created_at timestamp mismatches in /confirm and /on_confirm fulfillment id 1 does not exist in /on_select fulfillments[0].end.location gps is not matching with gps in /select Quote Object in /on_select and /on_confirm do not match Quoted Price in /on_confirm 515.3 does not match with the quoted price in /on_select 568.3

No /status call for return initiation

No /on_status call for order completion

/on_status must have required property 'fulfillments' /quote/price/value must be string /quote/breakup/0/@ondc/org/item_quantity/count must be integer /quote/breakup/3/price/value must be string /quote/breakup/4/price/value must be string /quote/breakup/5/price/value must be string /quote/breakup/6/@ondc/org/item_quantity/count must be integer /quote/breakup/9/price/value must be string /quote/breakup/10/price/value must be string /quote/breakup/11/price/value must be string /payment/type must be equal to constant (ON-ORDER) /payment/collected_by must be equal to constant (BAP) /payment/params must have required property 'transaction_id' Message Id for /status and /on_status api should be same

/on_update must have required property 'payment' must have required property 'created_at' must have required property 'updated_at' /fulfillments/0 must have required property '@ondc/org/provider_name' /fulfillments/0 must have required property 'tracking' /fulfillments/0 must have required property 'end' /fulfillments/0/start must have required property 'location' /fulfillments/0/start must have required property 'contact' /quote must have required property 'ttl' /quote/breakup/0 must have required property 'price' /quote/breakup/0 must have required property 'title' /quote/breakup/0 must have required property '@ondc/org/title_type' Message Ids for /update and /on_update apis should be same

Flow 2

No serviceability error. In case of "Non-serviceable", fulfillment related charges should not be present

Flow 3

in case of change in delivery address, a /select should be called again

Flow 4

price values should be upto 2 decimal places in case of item out of stock, item's unit price should be present

Items can't be returned when order state is still "Created"

No /on_update to approve the return request

@taanjit

sandeepshahi commented 1 year ago

Flow 1

/on_search

/on_select

/on_init

/on_confirm

/on_status

/on_update

Flow 2

/on_select

suitable domain error should be provided in case of non-serviceability

seller cancellation through unsolicited /on_cancel flow is missing

Flow 3

No update flow for return rejection

Flow 5

/on_select

@taanjit

abhinavv245 commented 1 year ago

Flow 1

/on_search

/on_select

/on_init

/on_confirm

/on_status

/on_update

Flow 2

/on_select (non-serviceable)

/on_cancel

Flow 3

/on_select

/on_update

Flow 4

/on_select

Flow 5

@taanjit

sandeepshahi commented 1 year ago

Common Issues

/on_search

on_select

/on_confirm

/on_status

/on_update

/on_update (Approved)

/on_update (Return_Delivered)

Flow 2

Flow 5

@taanjit

sandeepshahi commented 1 year ago

/on_search

/on_select

Flow 5

@taanjit

sandeepshahi commented 12 months ago

/on_select

/on_status

/on_update

/on_update (Order-picked-up)

@taanjit