sandeepshahi commented 1 year ago

Flow 1

/on_search

/message/catalog/bpp/providers must have required property 'time'
/message/catalog/bpp/providers must have required property 'fulfillments'
/message/catalog/bpp/providers must have required property 'tags' (serviceability construct should be defined)
/message/catalog/bpp/providers/ttl must be string
/message/catalog/bpp/providers/@ondc/org/fssai_license_no must NOT have fewer than 14 characters
/message/catalog/bpp/providers/locations/circle/radius/value must be string
/message/catalog/bpp/providers/locations/circle is deprecated key
/message/catalog/bpp/providers/items/category_id must be equal to one of the allowed values (Fruits and Vegetables,Masala & Seasoning,Oil & Ghee,Gourmet & World Foods,Foodgrains,Eggs, Meat & Fish,Cleaning & Household,Beverages,Beauty & Hygiene,Bakery, Cakes & Dairy,Kitchen Accessories,Baby Care,Snacks & Branded Foods,Pet Care,Stationery,Continental,Middle Eastern,North Indian,Pan-Asian,Regional Indian,South Indian,Tex-Mexican,World Cuisines,Healthy Food,Fast Food,Desserts,Bakes & Cakes,Beverages (MTO),Home Decor,Home Furnishings,Furniture,Garden and Outdoor Products,Home Improvement,Cookware and Dining,Storage and Organisation)
/message/catalog/bpp/providers/0/items/0/descriptor/images must NOT have fewer than 1 items
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
items.fulfillment_id should be one of the static ids in bpp/fulfillments[]
locations[].time holidays should be provided (can be an empty array)
items[].tags required only for F&B categories
items[].tags.brand is an invalid attribute

/on_select

Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
/quote/breakup/item/quantity/maximum/count must be string
/quote/breakup/item/quantity/available/count must be string
/quote/breakup/3 must have required property '@ondc/org/item_id'
/quote/breakup/4 must have required property '@ondc/org/item_id'
/quote/ttl must match format "duration"
/fulfillments/0 must have required property '@ondc/org/provider_name'
/fulfillments/0 must have required property '@ondc/org/category'
Quote breakup Payment title "BAP charges" is not as per the API Contract
order id and state are invalid keys in /on_select

/on_init

/quote/breakup/3 must have required property '@ondc/org/item_id'
/quote/breakup/4 must have required property '@ondc/org/item_id'
/quote/ttl must match format "duration"
/payment/@ondc/org/buyer_app_finder_fee_type must be equal to one of the allowed values (percent,amount)
/payment/@ondc/org/buyer_app_finder_fee_amount must be string
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
Billing object mismatches in /init and /on_init
gps coordinates in fulfillments[0].end.location mismatch in /select & /on_init
Quoted Price in /on_init INR 645.9 does not match with the quoted price in /on_select INR 597.96
Buyer app finder fee can't change in /on_init
Discrepancies between the quote object in /on_select and /on_init
payment object is not as per the API contract (buyer app should be supporting COD)

/confirm

/message/order/quote/breakup/3 must have required property '@ondc/org/item_id'
/message/order/quote/breakup/4 must have required property '@ondc/org/item_id'
/message/order/quote/ttl must match format "duration"
/message/order/payment/status must be equal to constant (PAID)
/message/order/payment/type must be equal to constant (ON-ORDER)
/message/order/payment/collected_by must be equal to constant (BAP)
/message/order/payment/params must have required property 'transaction_id'
Billing object mismatches in /init and /confirm
fulfillments[0].end.location gps is not matching with gps in /select
payment.status should be "PAID" in case of pre-paid order(ON-ORDER)
Discrepancies between the quote object in /on_select and /confirm
Quoted Price in /confirm INR 645.9 does not match with the quoted price in /on_select INR 597.96

/on_confirm

items[] have many invalid keys (refer API contract for the mandatory keys)
/fulfillments/0 must have required property 'start'
/quote/breakup/3 must have required property '@ondc/org/item_id'
/quote/breakup/4 must have required property '@ondc/org/item_id'
/quote/ttl must match format "duration"
/payment must have required property 'collected_by'
/payment/status must be equal to constant (PAID)
/payment/type must be equal to constant (ON-ORDER)
/payment/params must have required property 'transaction_id'
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
order.created_at timestamp mismatches in /confirm and /on_confirm
Billing object mismatches in /init and /on_confirm
fulfillments[0] start and end locations are mandatory
fulfillments[0].end.location gps is not matching with gps in /select
Discrepancies between the quote object /on_select and /on_confirm
Quoted Price in /on_confirm 645.9 does not match with the quoted price in /on_select 597.96
payment object mismatches in /confirm & /on_confirm

/on_status (delivered)

/fulfillments/0 must have required property 'start'
/quote/breakup/3 must have required property '@ondc/org/item_id'
/quote/breakup/4 must have required property '@ondc/org/item_id'
/quote/ttl must match format "duration"
fulfillments[] start.time and end.time timestamps are mandatory
/payment must have required property 'collected_by'
payment type and status not as per the API contract
payment object is not as per the API contract
/payment/params must have required property 'transaction_id'
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
order.created_at should be the same as in /confirm
fulfillments[].state.descriptor.name is invalid key

/on_update

/fulfillments/0 must have required property 'start'
/quote/breakup/3 must have required property '@ondc/org/item_id'
/quote/breakup/4 must have required property '@ondc/org/item_id'
/quote/ttl must match format "duration"
/payment must have required property 'collected_by'
/payment/status must be equal to constant (PAID)
/payment/type must be equal to constant (ON-ORDER)
/payment/params must have required property 'transaction_id'
Timestamp not in RFC 3339 (YYYY-MM-DDTHH:MN:SS.MSSZ) Format
item with id: undefined in quote.breakup[3] does not exist in items[]
misc with id: undefined in quote.breakup[4] does not exist in fulfillments[]
quote.price.value 372.96 does not match with the price breakup 342.96
fulfillment_id for ReverseQC in items[] should not be created in return_initiated state
invalid quote price (price is not updated at return_initiated state)

/on_status (return approved)

invalid quote price (should be updated at return_picked state)
fulfillments[1] state.descriptor.code should be as per the API contract

Flow 2 (Not as per the API Contract)

In case of change of delivery address, a new /select call should be initiated

Invalid cancellation through /on_status

@krishna-mi

krishna-mi commented 1 year ago

@bluecypher Feedback implemented. Also updated the schema for all the other flows. https://github.com/ONDC-Official/verification-logs/pull/587

sandeepshahi commented 1 year ago

Flow 1

/on_search

/message/catalog/bpp/providers/0/locations/0/circle/radius/value must be string (circle attribute is optional)
/message/catalog/bpp/providers/0/items/0/descriptor must have required property 'symbol'
location value defined in serviceability construct should be the same as in locations[].id

/on_select

/quote/breakup/@ondc/org/item_quantity/count must be integer

/on_init

/items/quantity/count must be integer
/quote/breakup/@ondc/org/item_quantity/count must be integer
billing timestamps (created_at and updated_at can't change in on_init)
/fulfillments/end/loation/address/door is an invalid attribute
/payment -type, params, status, @ondc/org/return_window,@ondc/org/settlement_basis,@ondc/org/settlement_window,@ondc/org/withholding_amount are invalid properties

/on_confirm

order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
Billing object mismatches in /init and /on_confirm
fulfillments[0].end.location gps is not matching with gps in /select
start and end time.timestamp are optional in on_confirm

/on_status (shipped)

fulfillments[].state is not as per the API contract (should be "Order-picked-up")

/on_update

quote should not be updated in Return_Initiated state (updated either in Return_Picked or Liquidated state)
Reverse QC fulfillment is not created in Return_Initiated state

/on_status (after return_initated)

Reverse QC fulfillment is not created in Return_Initiated state
fulfillments states should be updated for reverse qc after Return_Approved state
item with id: SKU031836 should be removed from quote.breakup when state is Return_Picked

Flow 2

similar issues as Flow 1

Flow 3

/on_update

quote is not updated in Return_Initiated state (updated either in Return_Picked or Liquidated state)
Reverse QC fulfillment is not created in Return_Initiated state

/on_status (post return_initiated)

quote should not be updated when return is initiated or rejected
Reverse QC fulfillment should not be created

Flow 4

similar issues as Flow 1

/on_select (unavailable)

quote.breakup for item not available, quantity.available and maximum count can't be greater than the requested quantity

Flow 5

similar issues as Flow 1
complete out-of-stock scenario should be provided

@krishna-mi

krishna-mi commented 1 year ago

@bluecypher GPS

FLOW 1

You have commented "fulfillments[0].end.location gps is not matching with gps in /select" but I didn't find any issue, can you please check again

select - 12.993323, 77.5543200000001
on_confirm - fulfillments - "12.993323,77.5543200000001"

Contradicting comments

In flow-1 you have commented "quote should not be updated in Return_Initiated state (updated either in Return_Picked or Liquidated state)" In flow-3 you have commented "quote is not updated in Return_Initiated state (updated either in Return_Picked or Liquidated state)" As per the API v1.1.0 i.e. shared and my understanding

Quote is updated once return is approved and updated quote should be sent after return_picked and return_delivered
Reverse qc fulfillment will be created after return is approved and the same would be sent when return is picked and return is delivered Correct me if my understanding is in-correct

sandeepshahi commented 1 year ago

ignore GPS related warnings.
refer /on_update scenarios from the API contract

@krishna-mi

krishna-mi commented 1 year ago

@bluecypher Implemented feedback: https://github.com/ONDC-Official/verification-logs/pull/617

Please Note:

Flow - 1

Billing object mismatches in /init and /on_confirm Done(door field removed, reference buyer app sending door field)
fulfillments[0].end.location gps is not matching with gps in /select Issue not found
Reverse QC fulfillment is not created in Return_Initiated state Not Done. Contradicting to API contract(Reverse QC is created after return is approved)
fulfillments states should be updated for reverse qc after Return_Approved state Not Done. Contradicting to specs mentioned, New fulfillment will be created and updated once return is approved

Flow - 2

Flow - 3

quote is not updated in Return_Initiated state (updated either in Return_Picked or Liquidated state) Not Done. Contradicting to specs mentioned.
Reverse QC fulfillment is not created in Return_Initiated state Not Done. Contradicting to specs mentioned.

Flow - 5

Unable to do payment on reference buyer app, issue at the buyer app. Once it is fixed, I can submit

sandeepshahi commented 1 year ago

@krishna-mi, nothing is contradictory. The flows should be rectified as mentioned in the comments. https://github.com/ONDC-Official/verification-logs/issues/565#issuecomment-1498580918

krishna-mi commented 1 year ago

@bluecypher As per the API contract shared in all the on_update calls Reverse-QC fulfillment is present when return is approved, picked or delivered. So followed the same and implemented the changes.

In flow-1 you have commented /on_status (after return_initated)

Reverse QC fulfillment is not created in Return_Initiated state

In flow-3 you have commented /on_status (post return_initiated)

Reverse QC fulfillment should not be created

Can you please clarify regarding these two comments.

sandeepshahi commented 1 year ago

@krishna-mi, both comments are for "Return_Initiated" state where ReverseQC is not created.

krishna-mi commented 1 year ago

@bluecypher in the flow-1 it is mentioned as Reverse QC is not created in return initiated state, in flow-3 it is mentioned as Reverse QC should not be created, so which one is correct?

sandeepshahi commented 1 year ago

@krishna-mi, please refer to latest comment.

krishna-mi commented 1 year ago

@bluecypher updated with all the feedback https://github.com/ONDC-Official/verification-logs/pull/617 https://github.com/ONDC-Official/verification-logs/pull/622

sandeepshahi commented 1 year ago

timestamp difference between /action and /on_action calls should be less than 5s

Flow 1

/on_search

@ondc/org/contact_details_consumer_care should be in the format "name,email,contact no"

/on_init

/billing/email mismatches in /init and /on_init

/on_status (shipped)

end.time.timestamp is not required

/on_status (delivered)

pickup time (start.time.timestamp) and delivery time (end.time.timestamp) can't be same

/on_status (return_approved)

quote price should not be updated in return_approved state (updated either in Return_Picked or Liquidated state)

on_update should be used for relaying the part return states to the buyer app and the message_id should be kept same as in /update (temporarily) to track individual return state

Flow 2,3,4

similar issues as Flow 1

Flow 5

/on_select (out of stock)

@ondc/org/item_quantity count for item SKU032084 can't be 0 when available quantity count is 5

@krishna-mi

krishna-mi commented 1 year ago

@bluecypher Implemented the feedback. https://github.com/ONDC-Official/verification-logs/pull/631

sandeepshahi commented 1 year ago

/on_confirm

/fulfillments/start/time/timestamp is not required

/on_status (delivered)

/fulfillments/end/time/timestamp (delivery time) should match context.timestamp and can't be future dated.
fulfillments/start/time/timestamp (pickup time) can't change in /on_status (delivered) and on_status (shipped)

For Return Flows: on_update should be used to provide update of the return flow instead of /on_status

@krishna-mi

ONDC-Official / verification-logs

Migrocer - compliance check #565

Flow 1

Flow 2 (Not as per the API Contract)

Flow 1

Flow 2

Flow 3

Flow 4

Flow 5

@bluecypher GPS

FLOW 1

Contradicting comments

Flow - 1

Flow - 2

Flow - 3

Flow - 5

Flow 1

Flow 2,3,4

Flow 5