search

ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board
22 stars 306 forks source link

Snapdeal - compliance check #697

Open sandeepshahi opened 1 year ago

sandeepshahi commented 1 year ago

686

abhinavv245 commented 1 year ago

Flow 1

/on_search

/on_select

/on_init

/on_confirm

/on_status

/on_status (delivered)

/on_update

Flow 2

Flow 3

Flow 4

/on_select

/on_update

Flow 5

@ShikharSD

ShikharSD commented 1 year ago

Hi Abhinav,

Had questions on below points:

1 . Flow 4- Error object with domain error and code missing in case of required item quantity not available: Is the error code "40002" applicable also when stock quantity returned by BPP is less than the requested quantity? Or only when product is completely out of stock?

  1. Flow 1 - delivery (fufillments/end/time/timestamp) time should match the context.timestamp for fulfillment state 'Order-delivered' for unsolicited /on_status - Why should fulfillment end timestamp match context timestamp post Order-delivered. It should be the order delivery time instead?

On Fri, Apr 28, 2023 at 5:32 PM Abhinav Goyal @.***> wrote:

Flow 1

/on_search

  • /message/catalog/bpp/providers must have required property 'ttl'
  • /message/catalog/bpp/providers/items/quantity/maximum/count must be string
  • /message/catalog/bpp/providers/items/quantity/available/count must be string
  • /message/catalog/bpp/providers/items/category_id must be equal to one of the non deprecated categories enhanced sub-category list https://docs.google.com/spreadsheets/d/1ayRbp-WmXwwbzp7z1MgRO0NuKZM1AQk4GGZ8SE4NTnw/edit#gid=623321892
  • @.***/org/statutory_reqs_packaged_commodities must have required property 'month_year_of_manufacture_packing_import'
  • @.***/org/statutory_reqs_packaged_commodities/manufacturer_or_packer_name can't be empty string
  • @.***/org/statutory_reqs_packaged_commodities/manufacturer_or_packer_address can't be empty string
  • @.***/org/statutory_reqs_packaged_commodities/net_quantity_or_measure_of_commodity_in_pkg can't be empty string
  • /message/catalog/bpp/providers/tags must be an array (to define serviceability construct)
  • context/timestamp difference between /on_search and /search should be smaller than 5 sec
  • Either one of fixed (range) or split (frequency and times) timings should be provided in /bpp/providers/locations/time
  • available count of item should be smaller or equal to the maximum count (/bpp/providers/items/quantity)
  • @.***/org/contact_details_consumer_care' must be in the format 'name,email,contactno' in bpp/providers/items

/on_select

  • 'name' is an invalid key in fulfillments/state/descriptor
  • /quote/breakup/item/quantity/maximum/count must be string
  • /quote/breakup/item/quantity/available/count must be string
  • /fulfillments must have required property @.***/org/category'
  • @./org/TAT'(O2D) cannot be equal to @./org/time_to_ship'(O2S) in /on_search -'listed_value','maximum_value' are invalid keys in /quote/breakup in /on_select

/on_init

  • provider_location object is missing in /on_init
  • 'listed_value','maximum_value' are invalid keys in /quote/price in /on_init
  • item.quantity is not required in quote.breakup
  • payment.status is not required

/on_confirm

  • order.created_at timestamp cannot change in /on_confirm
  • order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)
  • Billing object cannot change in /on_confirm (created_at,updated_at timestamps are different)
  • item.quantity is not required in quote.breakup

/on_status

  • Billing object should not change in /on_status (address.building,address.locality are not present in /on_status and email is different)
  • /fulfillments/end/location must have required property 'gps'
  • /fulfillments/end/location/address must have required property 'building'
  • /fulfillments/end/location/address must have required property 'locality'
  • provider.locations[0].id mismatches in /on_confirm and /on_status
  • quote.ttl should not change
  • order.updated_at timestamp should be updated as per the context.timestamp (since default fulfillment state is added)

/on_status (delivered)

  • pickup (fuflillments/start/time/timestamp) and delivery(fuflillments/end/time/timestamp) time cannot be same for fulfillment state 'Order-delivered'
  • delivery (fufillments/end/time/timestamp) time should match the context.timestamp for fulfillment state 'Order-delivered' for unsolicited /on_status

/on_update

  • /fulfillments/end/location must have required property 'gps'
  • /fulfillments/end/location/address must have required property 'building'
  • /fulfillments/end/location/address must have required property 'locality'
  • Item's unit price missing in quote.breakup for item id SDL921569730_0cac8d
  • order.updated_at timestamp should match the context.timestamp
  • return status updates should be sent via unsolicited /on_update APIs (as defined in the API contract v1.1.0) with same message id to track that particular return flow

Flow 2

  • similar issues as Flow 1

Flow 3

  • similar issues as Flow 1

Flow 4

  • similar issues as Flow 1

/on_select

  • Error object with domain error and code missing in case of required item quantity not available

/on_update

  • ReverseQC is not required when /items/tags/status is 'Return_Initiated'
  • quote price should not be updated when /items/tags/status is 'Return_Initiated'

Flow 5

  • similar issues as Flow 1

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1527463265, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXNHUHRNJ4GFJXPIRTXDOWUNANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

abhinavv245 commented 1 year ago

Hi Shikhar,

  1. Error code 40002 is applicable for both the cases.
  2. The on_status (unsolicited) call for 'Order-delivered' state is triggered when the order is actually delivered. Henceforth, delivery time (fufillments/end/time/timestamp) should match the context.timestamp.

@ShikharSD

sandeepshahi commented 1 year ago

Flow 1

/on_search

/on_select

/on_init

/on_confirm

/on_status

  1. return state updates should be provided through unsolicited /on_update calls (instead of /on_status)
  2. all the unsolicited /on_update and /on_status should be provided for verification

Flow 2

Flow 3

on_status (rejected)

Flow 4

/on_select (limited quantity)

Flow 5

/on_select (OOS)

check Flow 2,3,4,5 for similar issues raised in Flow 1

@ShikharSD

ShikharSD commented 1 year ago

Hi Sandeep,

Have few queries here-

context/timestamp should be in valid RFC339 UTC format and difference between /on_action and /action should be smaller than 5 sec - We are using staging env hence response time is slow there and could take more than 5 sec to respond in some cases. Will it be a blocker ?

On Mon, Jun 5, 2023 at 1:28 PM Sandeep Shahi @.***> wrote:

Flow 1

  • context/timestamp should be in valid RFC339 UTC format and difference between /on_action and /action should be smaller than 5 sec

/on_search

  • incorrect mapping of gps and address of store location. (reverse geocding shows different pincode)
  • /message/catalog/bpp/providers/items/category_id category_id should be one of the valid categories as defined in enhanced sub-category list https://docs.google.com/spreadsheets/d/1ayRbp-WmXwwbzp7z1MgRO0NuKZM1AQk4GGZ8SE4NTnw/edit#gid=0
  • @.***/org/statutory_reqs_packaged_commodities must have required property 'month_year_of_manufacture_packing_import'
  • @.***/org/statutory_reqs_packaged_commodities/ values can't be empty
  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_select

  • @.***/org/item_quantity/count must be integer
  • packing charges should not be present if 0

/on_init

  • provider/locations property is not a required (already captured in provider_location)
  • /items/quantity/count must be integer
  • @.***/org/item_quantity/count must be integer

/on_confirm

  • gps coordinates of store location can't change (/fulfillments/start/location)
  • estimated time of pickup should be correctly mapped (max(time_to_ship) is 1 day)

/on_status

  • order/created_at timestamp can't change (should remain same as in /confirm)
  • billing timestamps can't change Delivered:
  • pickup timestamp should be captured correctly

  • must have required property 'documents' (for Invoice)

    1. return state updates should be provided through unsolicited /on_update calls (instead of /on_status)
    2. all the unsolicited /on_update and /on_status should be provided for verification

Flow 2

  • packing charges should not be present when 0 and delivery charges line item should only be present when location is serviceable
  • As per the flow, the cancellation should be initiated by seller

Flow 3

on_status (rejected)

  • invalid context/timestamp
  • delivery timestamp can't change

Flow 4

/on_select (limited quantity)

  • As per the /on_search, the inventory wasn't available for both the items. Was there any real-time update to the inventory between these calls?

Flow 5

/on_select (OOS)

  • item's unit price should not be zero in case of OOS

check Flow 2,3,4,5 for similar issues raised in Flow 1

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1576276303, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHTYHHAJJUO4ZBJYKB3XJWGUDANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

sandeepshahi commented 1 year ago
  1. What is meant by a staging environment? The counterpart NP used for testing is the reference buyer app in the pre-production environment.
  2. Please utilize the enhanced subcategory list provided in the log feedback or mentioned in the API contract. The one you mentioned is specifically for the B2B vertical.
  3. The field 'month_year_of_manufacture_packing_import' is a mandatory statutory requirement for packaged commodities.
  4. As previously stated, there will be multiple unsolicited /on_update calls for a specific /update request (instead of unsolicited /on_status calls). These calls occur due to changes in the entire order (instead of just the state updates), such as price modifications due to return/cancel and/or the creation of reverse QC fulfillment.
  5. All the timestamps should be in RFC3339 UTC format.

@ShikharSD

sandeepshahi commented 1 year ago

Common Issues

/on_search

/on_select

/on_init

/on_confirm

/on_status (Order-Delivered)

/on_update (Delivered)

Flow 2

/on_select

/on_cancel

Flow 3

/on_search

/on_update

Flow 4

/on_select

/on_update (Delivered)

Flow 5

@ShikharSD

ShikharSD commented 1 year ago

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

ShikharSD commented 1 year ago

Hi Sandeep,

Can you help with clarification on the above points. Also help with below point as well:

  1. /on_update (Delivered) - returned item should be present in quote/breakup with count and total price = 0. - This is not mentioned in the return flow in 1.1 spec. The spec is showing removing the returned items from quote breakup itself in the on_update flows. https://docs.google.com/document/d/1fefHfMoYIouN-QJTDJFFZm46dqHmFvwY-6ICoISJcUY/edit Also it was highlighted during previous development cycles to add Quotation breakup for non return and non cancellable. Can you confirm on this as well

On Mon, Aug 28, 2023 at 2:58 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

ShikharSD commented 1 year ago

Hi Sandeep,

Can you help with the points in the mail chain? @Badrinath Mishra @.***> Can you help here

On Tue, Aug 29, 2023 at 5:32 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with clarification on the above points. Also help with below point as well:

  1. /on_update (Delivered) - returned item should be present in quote/breakup with count and total price = 0. - This is not mentioned in the return flow in 1.1 spec. The spec is showing removing the returned items from quote breakup itself in the on_update flows. https://docs.google.com/document/d/1fefHfMoYIouN-QJTDJFFZm46dqHmFvwY-6ICoISJcUY/edit Also it was highlighted during previous development cycles to add Quotation breakup for non return and non cancellable. Can you confirm on this as well

On Mon, Aug 28, 2023 at 2:58 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

ShikharSD commented 1 year ago

Hi Sandeep/Badrinath,

Can you help with above points in mail chain?

On Fri, Sep 1, 2023, 10:59 Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with the points in the mail chain? @Badrinath Mishra @.***> Can you help here

On Tue, Aug 29, 2023 at 5:32 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with clarification on the above points. Also help with below point as well:

  1. /on_update (Delivered) - returned item should be present in quote/breakup with count and total price = 0. - This is not mentioned in the return flow in 1.1 spec. The spec is showing removing the returned items from quote breakup itself in the on_update flows. https://docs.google.com/document/d/1fefHfMoYIouN-QJTDJFFZm46dqHmFvwY-6ICoISJcUY/edit Also it was highlighted during previous development cycles to add Quotation breakup for non return and non cancellable. Can you confirm on this as well

On Mon, Aug 28, 2023 at 2:58 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

ShikharSD commented 1 year ago

++

On Mon, Sep 4, 2023 at 10:15 AM Shikhar Srivastava < @.***> wrote:

Hi Sandeep/Badrinath,

Can you help with above points in mail chain?

On Fri, Sep 1, 2023, 10:59 Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with the points in the mail chain? @Badrinath Mishra @.***> Can you help here

On Tue, Aug 29, 2023 at 5:32 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with clarification on the above points. Also help with below point as well:

  1. /on_update (Delivered) - returned item should be present in quote/breakup with count and total price = 0. - This is not mentioned in the return flow in 1.1 spec. The spec is showing removing the returned items from quote breakup itself in the on_update flows. https://docs.google.com/document/d/1fefHfMoYIouN-QJTDJFFZm46dqHmFvwY-6ICoISJcUY/edit Also it was highlighted during previous development cycles to add Quotation breakup for non return and non cancellable. Can you confirm on this as well

On Mon, Aug 28, 2023 at 2:58 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi < @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

ShikharSD commented 1 year ago

Adding Sandeep.

Regards, Badri

+91 7838513783

On Mon, 4 Sep 2023 at 10:18 AM, Lokesh Chhaparwal < @.***> wrote:

++

On Mon, Sep 4, 2023 at 10:15 AM Shikhar Srivastava < @.***> wrote:

Hi Sandeep/Badrinath,

Can you help with above points in mail chain?

On Fri, Sep 1, 2023, 10:59 Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with the points in the mail chain? @Badrinath Mishra @.***> Can you help here

On Tue, Aug 29, 2023 at 5:32 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with clarification on the above points. Also help with below point as well:

  1. /on_update (Delivered) - returned item should be present in quote/breakup with count and total price = 0. - This is not mentioned in the return flow in 1.1 spec. The spec is showing removing the returned items from quote breakup itself in the on_update flows. https://docs.google.com/document/d/1fefHfMoYIouN-QJTDJFFZm46dqHmFvwY-6ICoISJcUY/edit Also it was highlighted during previous development cycles to add Quotation breakup for non return and non cancellable. Can you confirm on this as well

On Mon, Aug 28, 2023 at 2:58 PM Shikhar Srivastava < @.***> wrote:

Hi Sandeep,

Can you help with below points:

1.billing object mismatches in /confirm and /on_confirm - this is because mismatch in init and confirm call being received from BAP. init has address.door while confirm does not. We are sending door in all calls from BPP.

  1. Flow 4 - /on_select - Item's unit and total price mismatch for id: SDL133546301_0cac8d - what is the issue in this case. The unit price is 553 and units are 2, so the total price sums to 1106 and overall order to 1659
  2. Flow 5 - unit price and total price in quote/breakup should not change in the APIs - Is it same as above point or something else

On Sat, Aug 26, 2023 at 10:27 AM Sandeep Shahi < @.***> wrote:

Common Issues

/on_search

  • search callback response should be less than 5 sec
  • "net_quantity_or_measure_of_commodity_in_pkg" must contain UOM along with quantity

/on_select

  • delivery charges should not be repeated for the same fulfillment in quote/breakup
  • why is it taking 9 days to deliver within 50km radius?

/on_init

  • discrepancies between the quote object in /on_select and /on_init; packing charges should not be present if 0
  • fulfillments/state is not required

/on_confirm

  • estimated pickup and delivery time ranges can't be the same
  • billing object mismatches in /confirm and /on_confirm

/on_status (Order-Delivered)

  • address/country, address/door mismatches in /billing in /confirm and /on_status
  • all the intermin states of /on_status should be provided for verification
  • why are 2 identical invoices provided in /documents?

/on_update (Delivered)

  • all the iterim states for return should be provided
  • invalid start and end location in "Reverse QC" fulfillment

Flow 2

/on_select

  • how can the same lcoation be serviceable and non-serviceable at the same time?

/on_cancel

  • cancellation_reason_id should be a valid cancellation id (unsolicited seller app initiated)

Flow 3

/on_search

  • @.***/org/statutory_reqs_packaged_commodities/imported_product_country_of_origin country of origin must be in ISO 3166-1 alpha-3 code format

/on_update

  • update callback response should not take long; use interim state Return_Initiated

Flow 4

/on_select

  • Item's unit and total price mismatch for id: SDL133546301_0cac8d

/on_update (Delivered)

  • returned item should be present in quote/breakup with count and total price = 0

Flow 5

  • unit price and total price in quote/breakup should not change in the APIs

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1694162569, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHXLLWPNA2AYU6MUCTTXXF64BANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

-- Thanks Shikhar Srivastava

sahil-ondc commented 1 year ago

Common

context/bap_uri should remain same in every call, it should not contain on_action

Flow 1

/on_update

/on_status

Flow 2

/on_select(non-servicable)

/on_status

Flow 3

Similar issues as above Flow 1

Flow 4

/on_select

/on_init

on_update

Flow 5

/on_select

@ShikharSD

ShikharSD commented 1 year ago

HI @sharmasahil0331,

Can you help with below queries:

  1. packaging charges were added in /on_update, but not sent in previous calls - do we have to include packing charge if they are 0 in on_status/on_update calls. As we removed them in previous calls because they were 0 and were asked to be removed in last review.

  2. FLOW 4- items[1].quantity.count for item SDL365501449_0cac8d mismatches with the items quantity selected in /select - The quantity is different in select and on_select/on_init because in this flow seller cannot fill the entire quantity for one of the items. Hence 1 quantity is returned for 1 item instead of 2 and user proceeds with available quantity. As per test case scenarios- https://docs.google.com/document/d/1ttixilM-I6dutEdHL10uzqRFd8RcJlEO_9wBUijtdDc/edit

  3. For flows where difference between /on_select and /select should be smaller than 5 sec - Since we have to manually mark the items inventory in our preprod system during flow testing , it increases the response time. This is only happening in flow 4,5. In rest of the flows it is much less. Can we ignore this for flow 4,5 and go on ahead considering the rest flows as this will not happen on production which is visible in rest of the flows.

ShikharSD commented 1 year ago

HI @sharmasahil0331 https://github.com/sharmasahil0331,

Can you help with below queries:

1.

packaging charges were added in /on_update, but not sent in previous calls - do we have to include packing charge if they are 0 in on_status/on_update calls. As we removed them in previous calls because they were 0 and were asked to be removed in last review. 2.

FLOW 4- items[1].quantity.count for item SDL365501449_0cac8d mismatches with the items quantity selected in /select - The quantity is different in select and on_select/on_init because in this flow seller cannot fill the entire quantity for one of the items. Hence 1 quantity is returned for 1 item instead of 2 and user proceeds with available quantity. As per test case scenarios- https://docs.google.com/document/d/1ttixilM-I6dutEdHL10uzqRFd8RcJlEO_9wBUijtdDc/edit 3.

For flows where difference between /on_select and /select should be smaller than 5 sec - Since we have to manually mark the items inventory in our preprod system during flow testing , it increases the response time. This is only happening in flow 4,5. In rest of the flows it is much less. Can we ignore this for flow 4,5 and go on ahead considering the rest flows as this will not happen on production which is visible in rest of the flows.

On Mon, Sep 25, 2023 at 6:49 PM sharmasahil0331 @.***> wrote:

Flow 1

/on_update

  • Discrepancies between the quote object in /on_select and /on_update(packaging charges were added in /on_update, but not sent in previous calls)

/on_status

  • Discrepancies between the quote object in /on_select and /on_status(packaging charges were added in /on_update, but not sent in previous calls)

Flow 2

/on_select(non-servicable)

  • why there are two different fullfillments object if fullfillments id is same

/on_status

  • Same as Flow 1

Flow 3

Similar issues as above Flow 1 Flow 4

/on_select

  • context/timestamp difference between /on_select and /select should be smaller than 5 sec.

/on_init

  • items[1].quantity.count for item SDL365501449_0cac8d mismatches with the items quantity selected in /select

on_update

  • Same issues as Flow 1

Flow 5

/on_select

  • context/timestamp difference between /on_select and /select should be smaller than 5 sec.

@ShikharSD https://github.com/ShikharSD

— Reply to this email directly, view it on GitHub https://github.com/ONDC-Official/verification-logs/issues/697#issuecomment-1733697073, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4HROHQBP7FXQJVEQLLDHUDX4GAEJANCNFSM6AAAAAAXPEMHT4 . You are receiving this because you were mentioned.Message ID: @.***>

-- Thanks Shikhar Srivastava

sahil-ondc commented 1 year ago

  1. Quote should remain the same in the entire transaction, which you are sending on on_select.

  2. Noted.

  3. The behavior of pre-prod and production should be the same, apart from the payment flow. Therefore the time difference should not exceed 5 seconds in any flow.

@ShikharSD