Bizom B2B (BAP) - compliance check

ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board

21 stars 284 forks source link

Bizom B2B (BAP) - compliance check #822

Closed sandeepshahi closed 1 year ago

sandeepshahi commented 1 year ago

Flow 1

/search

Is the geocoding of gps and area_code correct? Reverse geocoding shows different pincode.
"buyer_id_no" is not a valid 15 digit GSTIN no.

/select

additional property /end/location/address/city is not required

/init

/message/order/billing/phone must NOT have fewer than 10 characters.
/message/order/fulfillments/0/end/contact/phone must NOT have fewer than 10 characters
fulfillments/end/contact/name is an optional attribute

Flow 2, 5

context/transaction_id should not change for select and select2 as per Flow 2 and 5

Flow 5

/cancel

004 is a deprecated cancellation_reason_id (use 006 instead)

@samarthpatel-bizom

samarthpatel-bizom commented 1 year ago

Flow 2 & 5:

As per the flow we can create new transaction id from /select call and hence we are creating new transaction id for all /select calls.

/init: if fulfillments/end/contact/name is optional BPP can avoid consuming or validating it.

For other flows have created the PR please check: https://github.com/ONDC-Official/verification-logs/pull/826

@bluecypher

sandeepshahi commented 1 year ago

/on_search

Invalid range of pack_size is provided in price_slab (where min>max). How is this catalog processed?

/init

address.name should be more than 3 chars

Please share complete transaction logs including the on_status calls

Flow 2, 5

Why is transaction_id changing in the select calls. The txn id should persist for the same txn and should not even change for the live search.
gstin validation, gps/area_code geocoding, phone number length validations issues still present

All these issues and the previously identified issues should be resolved across all the flows.

@samarthpatel-bizom

samarthpatel-bizom commented 1 year ago

@bluecypher have addressed your comments (keeping transaction_id same across all select)

here is the PR https://github.com/ONDC-Official/verification-logs/pull/868

sandeepshahi commented 1 year ago

/search

fulfillment/stops/location/gps must have atleast 6 digit of decimal precision

/init

address.name + address.building + address.locality should be less than 190 chars;
value of address.name, address.building and address.locality should be unique

Flow 2

/select2

is the geocoding of gps and area_code correct. Reverse geocoding shows different mapping

@samarthpatel-bizom

sandeepshahi commented 1 year ago

Tech Logs Approved (conditional sign off)

@samarthpatel-bizom