ONDC-Official / verification-logs

ONDC Pre-production issue & discussion board
21 stars 281 forks source link

Omuni - compliance check #932

Open sandeepshahi opened 1 year ago

sandeepshahi commented 1 year ago

/on_search

/on_select

/on_confirm

/on_status (Order-picked-up)

/on_status (Order-Delivered)

all the applicable return states should be provided for verification

Flow 2

Flow 3

Flow 4

Flow 5

@gowtham2307

gautham0703 commented 1 year ago

Hi @bluecypher @Rishabh-ondc Please find the latest PR attached below : https://github.com/ONDC-Official/verification-logs/pull/952 Flow 1 : /on_search

  1. invalid split timings for store provided (fixed timings can be used in this scenario)-> We are using fixed time as mentioned in the document : Log reference for the same : “time”: { “days”: “1,2,3,4,5,6,7”, “schedule”: { “frequency”: “PT24H”, “holidays”: [], “times”: [ “0000”, “2359" ] } } Fixed in the latest version : https://github.com/ONDC-Official/verification-logs/pull/952
  2. “@ondc/org/statutory_reqs_packaged_commodities” is mandatory for the provided category -> Updated in the latest version : https://github.com/ONDC-Official/verification-logs/pull/952
  3. name,building,door,country attributes are not required in /bpp/providers/locations/address -> Will be updated in the fix PR : https://github.com/ONDC-Official/verification-logs/pull/952

/on_select: “quantity” and “location_id” attributes are not required in order/items => Fixed in the updated version : https://github.com/ONDC-Official/verification-logs/pull/952 order/ttl is invalid attribute -> fixed in the updated version : https://github.com/ONDC-Official/verification-logs/pull/952 Standard Delivery from Delhi to Bengaluru can’t be fulfilled in 32 Hrs -> this is test environment, actual tat for the delivery will be picked from our courier partners. : https://github.com/ONDC-Official/verification-logs/pull/952 Why are 2 fulfillments created if delivery TAT and pickup location are same? -> each unique items will be created as a consignment at our end which will be shipped based on the best sourcing logic. -> As discussed this is the business construct. /on_confirm store name /fulfillments[1]/start/location/descriptor/name can’t change (check /on_search for provider name) -> provider descriptor is the seller, and the fullfilment start location would be the fulfilment location names present inside the seller. -> As discussed this is the business construct.

/on_status (Order-picked-up) /fulfillments/0/end/time/timestamp (delivery time) should not be present until order is delivered -> Fixed in the updated version : https://github.com/ONDC-Official/verification-logs/pull/952 /fulfillments/1/end/time/timestamp (delivery time) should not be present until order is delivered -> Fixed in the updated version : https://github.com/ONDC-Official/verification-logs/pull/952 Why are two invoices provided with same url? (only 1 invoice should be provided per order) -> Since if there are multiple shipments that are getting shipped based on sourcing, invoice for order can have at each shipment level. -> As discussed this is a business construct. /on_status (Order-Delivered) delivery timestamp (/end/time/timestamp) can’t be equal to the pickup timestamp (start/time/timestamp) -> Fixed in the updated version : https://github.com/ONDC-Official/verification-logs/pull/952

Flow 2 How can the same location be both serviceable/non-serviceable? -> if some of the items are not serviceable from the same store it is will be shown at item level. invalid cancellation flow; should be initiated by seller -> https://github.com/ONDC-Official/verification-logs/pull/952 Flow 3 invalid flow; seller rejection should be through /on_update call -> https://github.com/ONDC-Official/verification-logs/pull/952 Flow 4 unit price must be present for out-of-stock items in quote/breakup -> invalid flow; check test case scenario document (part fill flow is missing) -> https://github.com/ONDC-Official/verification-logs/pull/952 Flow 5 invalid flow; why every flow is shown as non-serviceable; refer to test case scenario document for exact requirements -> https://github.com/ONDC-Official/verification-logs/pull/952

sandeepshahi commented 1 year ago

Avoid using placeholder values; use cases must be realistic and feasible

/on_search

/on_select

/on_init

/on_confirm

/on_status

/on_update

Flow 2

Flow 3,4

Flow 4,5

/on_select

@gowtham2307

gowthamam0703 commented 1 year ago

Hi @bluecypher @Rishabh-ondc Please find the latest PR attached below : https://github.com/ONDC-Official/verification-logs/pull/1122

sandeepshahi commented 11 months ago

Common Issues

/on_search

/on_select

/on_update (Return_Picked)

Flow 5

@gowthamam0703

gowthamam0703 commented 11 months ago

Hi @bluecypher @Rishabh-ondc, As discussed, Flow 5 for partial quantity serviceability is not being supported by Business use case of Omuni, For rest of the issues will be updating the lates PR.

gowthamam0703 commented 11 months ago

Hi @bluecypher @Rishabh-ondc, As discussed, Flow 5 and 4 for partial quantity serviceability is not being supported by Business use case of Omuni, Lates PR attached with new flows of Flow1, Flow2 and Flow 3 with the below PR : https://github.com/ONDC-Official/verification-logs/pull/1201 Please verify and let us know if there are any issues.

sandeepshahi commented 11 months ago

@gowthamam0703, For Flows 4 and 5, you may include scenarios where one of the items is completely out of stock.

gowthamam0703 commented 11 months ago

https://github.com/ONDC-Official/verification-logs/pull/1216/files# Hi @bluecypher @Rishabh-ondc, Please find the above PR where we have updated the latest logs.

sandeepshahi commented 11 months ago

@gowthamam0703, all the previously identified issues must be resolved before resubmitting logs.

gowthamam0703 commented 11 months ago

Hi @bluecypher @Rishabh-ondc All the issues have been resolved as per disucssion and updated the latest PR : https://github.com/ONDC-Official/verification-logs/pull/1239 Please verify and let us know if any issue. Thanks & Regards.

sandeepshahi commented 10 months ago

/on_search

/on_select

/on_update (Return_Approved)

/on_update (Return_Picked)

@gowthamam0703