Mystore B2B - compliance check

[abhinavv245]

"schemaErr0": "/on_search/0/message/catalog/payments/0/type must be equal to one of the allowed values (PRE-FULFILLMENT,ON-FULFILLMENT,POST-FULFILLMENT)", "schemaErr1": "/on_search/0/message/catalog/providers/0/rating must be string", "schemaErr2": "/on_search/0/message/catalog/providers/0/ttl must be string", "schemaErr3": "/on_search/0/message/catalog/providers/0/items/0/quantity/unitized/measure/value must be string", "schemaErr4": "/on_search/0/message/catalog/providers/0/items/0/quantity/maximum/measure/unit must be equal to one of the allowed values (unit,dozen,gram,kilogram,tonne,litre,millilitre)", "schemaErr5": "/on_search/0/message/catalog/providers/0/items/0/quantity/maximum/measure/value must be string", "schemaErr6": "/on_search/0/message/catalog/providers/0/items/0/tags/4/list//value must be string", "schemaErr8": "/select/0/message/order/items/0 must have required property 'location_ids'", "schemaErr9": "/select/0/message/order/payments must be array", "schemaErr10": "/on_select/0/message/order/quote must have required property 'ttl'", "schemaErr11": "/init/0/message/order/provider must have required property 'ttl'", "schemaErr12": "/init/0/message/order/billing must have required property 'state'", "schemaErr13": "/init/0/message/order/billing must have required property 'city'", "schemaErr14": "/init/0/message/order/billing must have required property 'tax_id'", "schemaErr16": "/init/0/message/order/billing must NOT have additional properties (tax_number)", "schemaErr17": "/init/0/message/order/billing must NOT have additional properties (created_at)", "schemaErr18": "/init/0/message/order/billing must NOT have additional properties (updated_at)", "schemaErr15": "/init/0/message/order/billing/address must be string", "schemaErr16": "/init/0/message/order/fulfillments/id must be string", "schemaErr17": "/init/0/message/order/payments must be array", "schemaErr18": "/on_init/0/message/order must have required property 'provider_location'", "schemaErr34": "/confirm/0/message/order/fulfillments/0/stops/0/contact must have required property 'email'", "schemaErr45": "/confirm/0/message/order/created_at created_at does not match context timestamp - \"2023-08-01T17:58:06.321Z\"", "schemaErr46": "/confirm/0/message/order/updated_at updated_at does not match context timestamp - \"2023-08-01T17:58:06.321Z\"", "schemaErr53": "/on_update/0/message must have required property 'order'", "schemaErr54": "/on_status/0/message/order must have required property 'documents'", "schemaErr65": "/on_status/0/message/order/state must be equal to one of the allowed values (Created,Accepted,In-progress,Cancelled,Completed)",

@mystore-in

[tanya-ondc]

search:

• Item being searched is "testt". Can we have a real item being searched and test the actual end to end transaction flow.
• The reverse geo coding for delivery gps and area code does not match. GPS location of Delhi and area code of Gurgaon.

on_search:

• If the buyer is in India, why are we sending export license in creds. - /on_search/message/catalog/providers/0/creds
• provider.id and provider.location.id is same. How is this being handled at seller app end?
• category under provider.tags.serviceability should match the codes defined under enums - category.yaml.
• provider.tags.seller_id - Use a valid gst number.
• provider.items.tags.g3.pack_size is 0. Pack size cannot be zero. The value should be string.
• provider.items.tags.g3.num_price_slabs is 0. Mystore seller app does not support price slabs? The value should be string.

select:

• provider.id does not match any provider.ids sent in /on_search. How did buyer select provider which is not sent in /on_search.
• provider.location.id does not match any provider.location.ids sent in /on_search.
• provider.ttl to be sent in /select only when select is used for RFQ. Please share the buyer journey as discussed.
• items.id does not match any items returned in /on_search.
• message.order.fulfillments.stops.location.gps does not match the gps sent in /search.
• message.order.fulfillments.stops.location.gps - Reverse geo coding of gps does not match the area code.
• Why would buyer send import license when buying for India location. Customer.creds contains import license.

on_select:

• quantity.available.count is 6 in /on_search and 564 in /on_select. Is this a genuine use case.

init:

• message.order.billing.tax_id does not match the seller_id sent in /on_search. How are these two different.

on_init:

• What is the difference between select and init. Please confirm the buyer journey at Mystore.

confirm:

• Payment is made as part of /confirm. Please confirm the buyer journey

Flow 1

• The logs submitted in Flow 1 does not match the test cases of B2B.
• status and update calls missing in logs submitted.

Flow 3

• The logs submitted in Flow 1 does not match the test cases of B2B.
• status and update calls missing in logs submitted.

Flow 2, 4 missing

[tanya-ondc]

@mystore-in

Below are the Schema check failures:

• /search/0/message/intent/tags/0/list must have required property 'descriptor'

• /search/0/message/intent/tags must have required property 'descriptor'

• /on_search/0/message/catalog/providers/0/tags/list must have required property 'descriptor'

• /on_search/0/message/catalog/providers/0/items/tags must have required property 'descriptor'

• /select/0/message/order/items/0 must have required property 'location_ids'

• /select/0/message/order/tags/0/list must have required property 'descriptor'

• /on_init/0/context/message_id must be equal to constant (66100e48-ad4a-483c-a8fa-0eeb29785526)

• /on_init/0/message/order must have required property 'payments'

• /on_init/0/message/order/items/0 must have required property 'fulfillment_ids'

• /on_init/0/message/order/billing/phone must be equal to constant (9871123754)

• /confirm/0/message/order/billing/phone must be equal to constant (9871123754)

• /confirm/0/message/order/tags/0/list/ must have required property 'descriptor'

• /on_confirm/0/context/message_id must be equal to constant (22c14bcd-9b0c-4c4e-8da0-c00916a8325b)

• /on_confirm/0/message/order/billing/phone must be equal to constant (9871123754)

• /on_confirm/0/message/order/fulfillments/0/stops/0 must have required property 'instructions'

• /on_confirm/0/message/order/fulfillments/0/stops/1 must have required property 'instructions'

• /on_confirm/0/message/order/tags/0/list/0 must have required property 'descriptor'

• /on_confirm/0/message/order/tags/0/list/1 must have required property 'descriptor'

• /on_confirm/0/message/order/created_at order/created_at should remain same as in /confirm - "2023-08-14T09:57:37.616Z"

• /on_confirm/0/message/order/updated_at order/updated_at should be updated as per context/timestamp - "2023-08-14T10:02:58.382Z"

• /update/0/message/order/payments/0 must have required property 'uri'

• /update/0/message/order/payments/0 must have required property 'tl_method'

• /on_update/0/message must have required property 'order'

• /on_status/0/message/order/fulfillments/0/stops/1/location must have required property 'id'

• /on_status/0/message/order/fulfillments/0/stops/1/location must have required property 'descriptor'

• /on_status/0/message/order/created_at order/created_at should remain same as in /confirm - "2023-08-14T09:57:37.616Z"

• /on_status/1/message/order/fulfillments/0/stops/1/location must have required property 'id'

• /on_status/1/message/order/fulfillments/0/stops/1/location must have required property 'descriptor'

• /on_status/1/message/order/created_at order/created_at should remain same as in /confirm - "2023-08-14T09:57:37.616Z"

Also, as discussed, please have a valid provider's catalog in preprod and test based on that. Tested with test data is expected in staging environment and not in Preprod. Also, please test with a different counter NP for logs submission.

[mystore-in]

@tanya-ondc there is no descriptor in the select tag list in reference Json also in confirm tag list data is in descriptor and same for on_confirm

[tanya-ondc]

@mystore-in Please check the Examples once. This was discussed 2 weeks back. There are more examples and flows added for domestic and exports for better clarity as well.

[mystore-in]

Tanya submitted logs with correction also we are still using test seller as we don't onboard real seller on preprod

[tanya-ondc]

The logs are manipulated. How few API logs got updated 2 days ago and few yesterday. Please submit actual logs and this is why I requested for a review with a different NP.

/on_search

1. location.circle is not part of the API specs of v2.0.1. The serviceability is actually being calculated based on the serviceability tag group.
2. tags.origin.country value should be valid country code, i.e. IND.
3. /on_search/0/message/catalog/providers/0/items/0/tags/2/list/0 must have required property 'descriptor'
4. /on_search/0/message/catalog/providers/0/items/0/tags/5 must have required property 'descriptor'
5. /on_search/0/message/catalog/providers/0/items/0/tags/6 must have required property 'descriptor'

/select

1. ttl between /on_search and /select is too high.

/confirm

1. When payment_type is ON_FULFILLMENT, how can collected_by is BAP.
2. /confirm/0/message/order/items/0 must have required property 'fulfillment_ids'

/update

1. /update/0/message/order/payments/0/params/transaction_id must be string
2. Tell me how payment is made before delivery, when payment type is ON_FULFILLMENT.

/on_update

1. incorrect 'action' in context
2. /on_update/0/message/order/items/0 must have required property 'fulfillment_ids'
3. /on_update/0/message/order/items/0/quantity must have required property 'count'
4. Please confirm what is on_update used for?

/on_status

1. fulfillment.stops.start.time should have timestamp.
2. fulfillment.start and fulfillment.end should not be present.
3. /on_status/message/order/fulfillments/0/stops/1/location must have required property 'id'
4. /on_status/message/order/fulfillments/0/stops/1/location must have required property 'descriptor'
5. /on_status/message/order/payments/0/params/transaction_id must be string

@mystore-in

[mystore-in]

Hi @tanya-ondc because there is some small changes in api that's why I just paste the message body due to which some api's showing updated yesterday. Will submit everything again if there's any small changes also.

[mystore-in]

Hi @tanya-ondc please review our logs as we have submitted our logs yesterday

[mystore-in]

https://github.com/ONDC-Official/verification-logs/pull/1136 merge this pull request which updated one into Mystore logs before reviewing

[tanya-ondc]

Merged. Will update on this.

[tanya-ondc]

Issues with Mystore BAP tested with Signcatch:

/select:

• The fulfillment.end location changes from search to select. How is serviceability handled in such a case?

/init:

• fulfillments.stops.country.code should be IND.
• /init/0/context/ttl should match provider ttl - "P6D"
• /init/0/message/order/fulfillments/0 must have required property 'id'
• /init/0/message/order/fulfillments/0 must have required property 'type'

@mystore-in

[tanya-ondc]

Issues with Mystore BAP tested with Signcatch:

/select:

• /select/0/context/transaction_id Transaction ID should be same across the transaction: "5112b220-c071-41de-8f1b-eff810dc95c4"
• /select/0/message/order/fulfillments/0/stops/0/location/gps Incorrect gps value - gps should be 6 decimal precision.

/confirm:

• /confirm/0/message/order/provider/locations must be equal to location object in /init.
• /on_confirm/0/context/message_id Message ID for on_action API should be same as action API: "600cbc38-42e1-4ac9-898a-580ff58c1936"

[tanya-ondc]

Mystore BAP logs looks good to go ahead for ops validation. Mystore BPP logs still need to be fixed.

[abhinavv245]

Mystore BPP

/init

• /init/0/context/ttl should match provider ttl - "P6D"
• /init/0/message/order/fulfillments/0 must have required property 'id'
• /init/0/message/order/fulfillments/0 must have required property 'type'

/on_init

• /on_init/0/message/order/provider_location/id must be equal to constant (LM64c8a8220357056a595060be)

/on_confirm

• /on_confirm/0/context/message_id Message ID for on_action API should be same as action API: "21a3c1a5-9bc0-48d5-8e6b-55e24beebc9c"
• /on_confirm/0/message/order/updated_at should be updated as per context/timestamp - "2023-08-27T17:17:31.255Z"

/on_update

• /on_update/0/message/order/provider/id must be equal to constant (64c8a8220357056a595060be)
• /on_update/0/message/order/items/0/quantity must have required property 'count'
• /on_update/0/message/order/fulfillments/0/stops/1 must have required property 'instructions'

/on_status

• /on_status/0/message/order/tags are not required

[tanya-ondc]

/search:

• intent.item is testt. Please use valid products.

/on_search:

• Payments - Do you only support on_fulfillment and not pre-fulfillment?
• providers.locations.circle - Is this used for serviceability?
• Please use valid data - seller and seller products for testing. All the data in catalog is testt data.
• providers.serviceability - Additional attribute - not defined in protocol.
• "Reverse Geocoding for end failed. Area Code 122050 not matching with 28.355510,76.940971 Lat-Long pair."

/on_confirm:

• "/on_confirm/0/message/order/fulfillments/0 must have required property 'stops'"
• "context/timestamp difference between on_confirm and confirm should be within 5 seconds"

/on_status:

• "/on_status/0/message/order must have required property 'documents'",
• "/on_status/0/message/order/fulfillments/0 must have required property 'stops'",
• "/on_status/1/message/order must have required property 'documents'",
• "/on_status/1/message/order/fulfillments/0 must have required property 'stops'"
• "Order state should be 'Completed' for fulfillment state - Order-delivered"

@mystore-in