search

ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems
https://platform.onearmy.earth
MIT License
1.14k stars 390 forks source link

[bug] howto filtering by tags persists after going back in history browser #1358

Closed jparadasb closed 2 years ago

jparadasb commented 2 years ago

Describe the bug When using the how-to filter by tags after selecting at least two and then going back forward in the browser history, the filters still appear selected although not present in the URL.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'How-to'
  2. Select one or more filters tags
  3. Press the history back button on the browser
  4. The content still is filtered and it appears selected in the SelectBox

Expected behavior When the filter by tags is selected if I go one time back in the browser history the last tag selected shouldn't appear and the content shouldn't be filtered by that tag, should have consistency with what the URL is showing.

Screenshots gif

Additional context Add any other context about the problem here.

thisislawatts commented 2 years ago

Thanks for raising this issue @jparadasb as discussed in #1238. Okay if I assign it to you?

jparadasb commented 2 years ago

Yes, please

Ulian commented 2 years ago

The tag filter doesn't exist anymore. This behavior happens to category and search filters as well, do I create a new issue or can I take this one?

davehakkens commented 2 years ago

well spotted @Ulian, you can take this one and replace tags with categories

onearmy-bot commented 1 year ago

:tada: This issue has been resolved in version 1.31.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: