search

ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems
https://platform.onearmy.earth
MIT License
1.14k stars 394 forks source link

[bug] Actually limit tags to four #3347

Closed benfurber closed 1 month ago

benfurber commented 8 months ago

Describe the bug Research, how-tos and questions all use the TagsSelectField component which says only four tags should be allowed...but, eeerrr, it doesn't actually limit it to four

Screenshot 2024-03-14 at 13 41 31

Expected behaviour Using react-final-form's validation behaviour and the existing error handling approaches, please fix this!

simontree commented 8 months ago

Hey @benfurber, this could be my first issue where I think I have a working idea already - just need finetune the styling of the error-message. Do you need to assign me? Best wishes

benfurber commented 8 months ago

That's great, thanks @simontree - it's yours!

V24039 commented 5 months ago

Hi @benfurber I would take up this issue if it is still open

benfurber commented 5 months ago

Thanks @V24039. Please do!

V24039 commented 5 months ago

@benfurber thank you for assigning it to will try to complete it ASAP

V24039 commented 5 months ago

@benfurber After analysis I think the validations can added only at the page level (validation for each page which uses the tags), because the tag is developed as a custom component like text field so adding validation at the component will not restrict the user to submit. Will be waiting for your analysis and reply to move forward