ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems
https://platform.onearmy.earth
MIT License
1.07k stars 357 forks source link

(DRAFT) Comment Textarea UI Improvements #3679

Open elideg opened 2 weeks ago

elideg commented 2 weeks ago

PR Checklist

PR Type

Description

Our current "Submit a comment" UI falls short when viewing on mobile devices.

Git Issues

Closes #3655

Screenshots/Videos

In-progress UI:

Screenshot 2024-06-19 at 10 47 46 PM Screenshot 2024-06-19 at 10 47 43 PM Screenshot 2024-06-19 at 10 47 35 PM


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

elideg commented 2 weeks ago

Still need to setup ESLint in my IDE, will fix the messed up formatting in a later commit. I just wanted to open this PR for transparency & discussion purposes as I'm using some patterns I want input on.

github-actions[bot] commented 2 weeks ago

Visit the preview URL for this PR (updated for commit 274af86):

https://onearmy-next--pr3679-feat-cleanup-comment-9kasofp5.web.app

(expires Sat, 20 Jul 2024 12:19:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

davehakkens commented 2 weeks ago

works nice! Got two remarks:

  1. Still a few funky things on mobile

    afbeelding
  2. Any reason you've changed the font? -it's now different from the original

benfurber commented 1 week ago

Exciting work @elideg, thank you. Looking forward to seeing it finished!