[e2e] Cypress scripts improvements

ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems

https://platform.onearmy.earth

MIT License

1.07k stars 357 forks source link

[e2e] Cypress scripts improvements #3681

Closed tuliobluz closed 4 hours ago

tuliobluz commented 2 weeks ago

PR Checklist

[X] - Commit messages are descriptive, it will be used in our Release Notes

PR Type

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X] Developer experience (improves developer workflows for contributing to the project)

Description

This PR is to improve the Cypress scripts

Make sure the queryDoc gets the right test doc using the generated usernametriggeredBy.userId === visitor.username,. for the discussions scenarios.
Add to how to write scenarios dynamic generate title then we can query the right document based on the dynamic title
Use should(be.visible) instead should(exist)
Removed duplicate cy.clearServiceWorkers() that was in after() and also in before() on hooks.ts
Remove cy.wait(500) and used .focus() to type the intro description on research/write.ts

cypress[bot] commented 2 weeks ago

2 flaky tests on run #5925 ↗︎

Details:

Merge branch 'master' into 3475-cypress-improvements
Project: onearmy-community-platform	Commit: `8207e302f8`
Status: Passed	Duration: 04:33 💡
Started: Jul 5, 2024 7:44 AM	Ended: Jul 5, 2024 7:48 AM

howto/write.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[How To] > [Create a how-to] > [By Authenticated]		`Test Replay` `Screenshots` `Video`

notifications.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[Notifications] > [are generated by clicking on useful for how-tos]		`Test Replay` `Screenshots` `Video`

Review all test suite changes for PR #3681 ↗︎

benfurber commented 1 week ago

@tuliobluz Looks like the current cypress fails might be related to your changes? Will leave you to confirm/work on before reviewing again.

tuliobluz commented 1 week ago

Hello @benfurber I just pushed new commits that might fix all the scenarios. Can you please retry the unit tests? Hopefully, if everything passes in the CI you can review.

tuliobluz commented 2 days ago

Please don't merge, I am still investigating the flaky regarding the delete step on howto/write.spec

benfurber commented 9 hours ago

@tuliobluz Are you sure this can't be merged in @tuliobluz, howto/write is already a little annoying.

tuliobluz commented 9 hours ago

@benfurber Lets merge, and I will continue working on it