feat: updated settings - new form wrapper

benfurber commented 3 days ago

PR Checklist

[x] - Commit messages are descriptive, it will be used in our Release Notes

PR Type

[x] New feature (non-breaking change which adds functionality)

Description

First part of #3724. This creates a new wrapper for settings forms.

Video

https://github.com/ONEARMY/community-platform/assets/16688508/a81e63fe-0cb7-43ec-a91a-1bddf68df39b

benfurber commented 2 days ago

@davehakkens Hard for you to review as I've put this only on storybook for the moment. Any obvious feedback from you from the video? Once this has been deployed you can play with it better on the live storybook.

benfurber commented 2 days ago

Oh and when only one tab exists (like when I implement this in the next PR), no tab select displays:

e.g.:

cypress[bot] commented 2 days ago

1 failed and 1 flaky tests on run #5923 ↗︎

1

71

1

0

1

Details:

feat: update wrapper for mobile
Project: onearmy-community-platform	Commit: `e0eac744cf`
Status: Failed	Duration: 14:55 💡
Started: Jul 4, 2024 7:44 PM	Ended: Jul 4, 2024 7:59 PM

src/integration/howto/write.spec.ts • 1 failed test • ci-chrome

View Output Video

Test		Artifacts
[How To] > [Create a how-to] > [By Authenticated]		`Test Replay` `Screenshots` `Video`

src/integration/settings.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test		Artifacts
[Settings] > Focus Plastic Collection Point > [Edit a new profile]		`Test Replay` `Screenshots` `Video`

Review all test suite changes for PR #3725 ↗︎

davehakkens commented 2 days ago

Oe nice! Nope nothing to add, looking forward to test

ONEARMY / community-platform