refactor: remix migration

mariojsnunes commented 4 months ago

PR Checklist

[x] - Commit messages are descriptive, it will be used in our Release Notes
[ ] - Unit and e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Refactoring (no functional changes)
[x] Build related changes
[x] CI related changes
[x] Documentation changes

What is the current behavior?

Frontend static files.

What is the new behavior?

We need a server for the frontend.
First steps towards server-side rendering.
This goal of this PR is to do the minimum changes necessary for Remix to work, the App is still rendered on the browser.

docs/remix.md for more details :)

TODO

[ ] update ci/cd scripts
[x] fix unit and e2e tests
[x] localStorage/sessionStorage/window usage might need a refactor

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Git Issues

Closes #

cypress[bot] commented 3 months ago

onearmy-community-platform Run #6290

Run Properties: Passed #6290 • 7667593671: chore: merge

Project	`onearmy-community-platform`
Branch Review	`feat/remix`
Run status	`Passed #6290`
Run duration	`04m 29s`
Commit	`7667593671: chore: merge`
Committer	`Mário Nunes`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`65`
View all changes introduced in this branch ↗︎

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.59%. Comparing base (c6c37cb) to head (7667593).

Files with missing lines	Patch %	Lines
src/config/config.ts	75.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3789 +/- ## ========================================== + Coverage 72.39% 72.59% +0.20% ========================================== Files 43 43 Lines 1362 1361 -1 Branches 274 274 ========================================== + Hits 986 988 +2 + Misses 352 349 -3 Partials 24 24 ``` | [Flag](https://app.codecov.io/gh/ONEARMY/community-platform/pull/3789/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ONEARMY) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/ONEARMY/community-platform/pull/3789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ONEARMY) | `72.59% <96.15%> (+0.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ONEARMY#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

Visit the preview URL for this PR (updated for commit 7abad30):

https://onearmy-next--pr3789-feat-remix-4gk4or5v.web.app

_{(expires Sun, 13 Oct 2024 15:41:24 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59}

benfurber commented 2 months ago

@mariojsnunes Looking on https://community-platform-aged-violet-4527.fly.dev/research?sort=LatestUpdated. The page title isn't set for some reason. Fine for research articles (https://community-platform-aged-violet-4527.fly.dev/research/more-draft-checking) but not the index.

mariojsnunes commented 2 months ago

@mariojsnunes Looking on https://community-platform-aged-violet-4527.fly.dev/research?sort=LatestUpdated. The page title isn't set for some reason. Fine for research articles (https://community-platform-aged-violet-4527.fly.dev/research/more-draft-checking) but not the index.

Thanks, should be fixed on the next deploy

benfurber commented 2 months ago

Bug on https://community-platform-pk.fly.dev/settings Errors given when setting a profile image.

Content-Security-Policy: The page’s settings blocked the loading of a resource (img-src) at blob:https://community-platform-pk.fly.dev/cbddf9d2-ec83-430b-9602-b08064974d01 because it violates the following directive: “img-src 'self' data: https://google.com/ https://*.openstreetmap.org https://firebasestorage.googleapis.com/ https://onearmy.github.io/ https://cdn.jsdelivr.net/”

Double annoying as it shouldn't block the page from re-rendering the form with a user notification of the error.

(Dave if reading: unrelated to the other upload issue we've been discussing).

benfurber commented 2 months ago

Can't set a map pin.


Content-Security-Policy: The page’s settings blocked the loading of a resource (connect-src) at https://nominatim.openstreetmap.org/reverse?lat=-40.33793329207486&lon=-184.36747303772862&format=json&accept-language=en because it violates the following directive: “connect-src 'self' https://*.run.app https://securetoken.googleapis.com/ https://firestore.googleapis.com/ https://identitytoolkit.googleapis.com/ https://localhost:24678/ ws://localhost:24678 https://web/ https://socket/ https://url/”```

benfurber commented 2 months ago

Issue connecting patreon: