feat: add map v2.0.0 - Githubissues

ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems

https://platform.onearmy.earth

MIT License

1.14k stars 397 forks source link

feat: add map v2.0.0 #3829

Closed benfurber closed 2 months ago

benfurber commented 3 months ago

PR Checklist

[x] - Commit messages are descriptive, it will be used in our Release Notes
[x] - Unit and e2e tests for the changes that have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix (fixes an issue)
[x] Feature (adds functionality)
[ ] Code style update
[x] Refactoring (no functional changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation changes
[ ] Other... Please describe:

What is the new behavior?

https://github.com/user-attachments/assets/62277900-dd03-4cba-b503-349ca0b4f3f3

The first release of the new map design. Yay! The feature is setup as a public beta with a banner on the top of the current map which let's users which between the two.

Adds a banner for the component library - refactor for two exist, plus one new banner
Adds a CardList and CardListItem for the component library, needed for the new map
Tidies up some typing into the shared space - I wanted to go further into enum stuff for the profile type typing but it caused more problems
Removed the unused setMapBoundingBox method from the map store.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

benfurber commented 3 months ago

Mainly adding now as I'm wanting to test out what the map displays for the remote e2e test run.

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit cd31b1c):

https://onearmy-next--pr3829-feat-new-map-add-v2-c0myh1v7.web.app

_{(expires Wed, 25 Sep 2024 13:57:00 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59}

cypress[bot] commented 3 months ago

onearmy-community-platform Run #6173

Run Properties: Passed #6173 • cd31b1c5d3: chore: update from feedback

Project	`onearmy-community-platform`
Branch Review	`pull/3829`
Run status	`Passed #6173`
Run duration	`04m 18s`
Commit	`cd31b1c5d3: chore: update from feedback`
Committer	`Ben Furber`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`1`
Pending	`0`
Skipped	`0`
Passing	`65`
View all changes introduced in this branch ↗︎

davehakkens commented 2 months ago

Very nice! One remark on the banner. It already links to the new map, but that is still very basic and raw. It's not interesting enough to be a test for users, but also no information for developers to help.

I would either:

Not show the banner yet. Make the page accessible by url so we can try internally with live data until its a bit more developed to test for users.
Adjust the wording of the banner from: "🗺 This is our new map interface. Go back to the old one!" to: "🗺 We're making a new map interface. Help to develop it or go back to the old one!" "

onearmy-bot commented 2 months ago

:tada: This PR is included in version 1.211.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: