search

ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems
https://platform.onearmy.earth
MIT License
1.14k stars 397 forks source link

feat: update design of zoom controls on new map #3880

Closed JoseAConcepcion closed 1 month ago

JoseAConcepcion commented 1 month ago

PR Checklist

PR Type

What kind of change does this PR introduce?

What is the current behavior?

The zoom controls for the new map are currently the default design.

What is the new behavior?

The zoom controls were updated with the correct design. old_design new_design

Does this PR introduce a breaking change?

Git Issues

Closes #3872

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

cypress[bot] commented 1 month ago

onearmy-community-platform    Run #6338

Run Properties:  status check passed Passed #6338  •  git commit 4e1be1ea00: fix: padding and size of the zoom buttons
Project onearmy-community-platform
Run status status check passed Passed #6338
Run duration 04m 44s
Commit git commit 4e1be1ea00: fix: padding and size of the zoom buttons
Committer Jose
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 75
JoseAConcepcion commented 1 month ago

Hi @benfurber, the font size of the buttons already were 25px. Should it be higher still? Did you mean the general size of the actual buttons?

benfurber commented 1 month ago

Hi @benfurber, the font size of the buttons already were 25px. Should it be higher still? Did you mean the general size of the actual buttons?

@JoseAConcepcion Ha. I misread the code! Yes I mean the general size of the buttons. If it's 25px already, how's about 30px?

JoseAConcepcion commented 1 month ago

@benfurber its bigger now, increased the size and the padding of the element but I'm not sure it's the spacing of the other elements, for some reason modifying the parent doesn't do the trick :(

feedback_design

PD: While I was zooming in and out discovered that "the report a problem" button disappears, not sure to open an Issue because there are other user buttons to be added in the new design.

benfurber commented 1 month ago

Awesome! Thanks @JoseAConcepcion, I'll get this merged in now. Anything else on the issues list take your fancy?

benfurber commented 1 month ago

@all-contributors add @JoseAConcepcion for code

allcontributors[bot] commented 1 month ago

@benfurber

I've put up a pull request to add @JoseAConcepcion! :tada:

JoseAConcepcion commented 1 month ago

@benfurber happy to help :)
I will be back in two weeks give or take, got to finish some final projects and exams. For sure I will take another issue.

onearmy-bot commented 1 month ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: