ONEARMY / community-platform

A platform to build useful communities that aim to tackle global problems
https://platform.onearmy.earth
MIT License
1.14k stars 389 forks source link

feat: add profile tags to all profile types #3908

Open benfurber opened 1 week ago

benfurber commented 1 week ago

Many elements of the Precious Plastic specific profile types (workspaces, machine shop, etc.) are highly specifc. This makes extension for other projects more complex.

The main is to remove all the space fields for the PP specific profile types and replace them with a more generic profile tags field which can then also be added to the member and space profile types.

To-do:

davehakkens commented 1 week ago

Could we separate the implementation to members?

As i think this is not fully thought out yet since they have quite different 'tags' from the space profiles

benfurber commented 1 week ago

@davehakkens Do you mean have a seperate list of tag options?

davehakkens commented 1 week ago

@davehakkens Do you mean have a seperate list of tag options?

Could be. But not sure if that is worth the added complexity at this point? What do you think?

I do know that at minimum we needs tags for spaces

Members is a nice to have

benfurber commented 1 day ago

@davehakkens As community and members don't have any custom fields atm it's super easy to add them.

Can you please provide a list of labels for:

  1. PP members, PK members and FF members.
  2. PP community.
  3. PK space and FF space.

Happy receive 1, 2 and 3 whenever. Need all parts of 1 or 3 at the same time to make releasing simple.

benfurber commented 1 day ago

@davehakkens Do you mean have a seperate list of tag options?

Could be. But not sure if that is worth the added complexity at this point? What do you think?

I do know that at minimum we needs tags for spaces

Members is a nice to have

Sorry, @davehakkens I missed that the first setence was a question. I think it's worth doing all of this. I see the value from a product prospect, it's not that much more work to do it all and then the code is simplier at the end as we have one way of doing it all.

davehakkens commented 23 hours ago

@benfurber Why is PP Community (2) different from PK and FF Space (3), it would eventually all work the same right? -> All spaces on an instance use the same profile-tags

benfurber commented 20 hours ago

@davehakkens Yes, all ProfileTypes on an instance use the same profile tags. But there are different tags for PK, PP and FF right?

For 2 I mean the PP "COMMUNITY_BUILDER" profile type, it's coded differently to "SPACE". Should they be the same thing?

davehakkens commented 19 hours ago

@davehakkens Yes, all ProfileTypes on an instance use the same profile tags. But there are different tags for PK, PP and FF right?

Correct.

For 2 I mean the PP "COMMUNITY_BUILDER" profile type, it's coded differently to "SPACE". Should they be the same thing?

Strange, what is different between them? In my head that one was always the same as the others.

Regarding the tag list. Here is a document It's not 100% thought out, as we would still need to do this work for PK somewhere in the winter. But perhaps we could use it as a start and iterate as we go, or prefer to finalize first?