search

ONEcampaign / topic_health_financing

A repository for the Health Financing topic page
MIT License
0 stars 0 forks source link

BUG: Group aggregation #33

Closed lpicci96 closed 1 year ago

lpicci96 commented 1 year ago

aggregating values by group contains a 2 bugs in the calculation:

  1. After forward filling missing values should be dropped, so that country counts don't pick up missing values
  2. using the 95% coverage benchmark should compare country counts to total count of unique values per group rather than using a mean of counts.

function to fix:

https://github.com/ONEcampaign/topic_health_financing/blob/4b49a0361a9c0b7a6a7c7fe550856866da7696b9/scripts/tools.py#L141 https://github.com/ONEcampaign/topic_health_financing/blob/4b49a0361a9c0b7a6a7c7fe550856866da7696b9/scripts/tools.py#L318