ONLYOFFICE / CommunityServer

Free open source office suite with business productivity tools: document and project management, CRM, mail aggregator.
http://www.onlyoffice.com
Apache License 2.0
2.75k stars 621 forks source link

master branch inconsistency #359

Open sergey-239 opened 2 years ago

sergey-239 commented 2 years ago

the latest release commit is inconsistent. E.g. there are references to missing files or files that actually are in different places in file web/studio/ASC.Web.Studio/ASC.Web.Studio.csproj at rows 1065 onwards:

    <Content Include="Content\jQuery.FileUpload\css\jquery.fileupload-noscript.css" />
    <Content Include="Content\jQuery.FileUpload\css\jquery.fileupload-ui-noscript.css" />
    <Content Include="Content\jQuery.FileUpload\css\jquery.fileupload-ui.css" />
    <Content Include="Content\jQuery.FileUpload\css\jquery.fileupload.css" />
    <Content Include="Content\jQuery.FileUpload\img\loading.gif" />
    <Content Include="Content\jQuery.FileUpload\img\progressbar.gif" />
    <Content Include="Content\themes\base\images\ui-bg_flat_0_aaaaaa_40x100.png" />
    <Content Include="Content\themes\base\images\ui-bg_flat_75_ffffff_40x100.png" />
    <Content Include="Content\themes\base\images\ui-bg_glass_55_fbf9ee_1x400.png" />
    <Content Include="Content\themes\base\images\ui-bg_glass_65_ffffff_1x400.png" />
    <Content Include="Content\themes\base\images\ui-bg_glass_75_dadada_1x400.png" />
    <Content Include="Content\themes\base\images\ui-bg_glass_75_e6e6e6_1x400.png" />
    <Content Include="Content\themes\base\images\ui-bg_glass_95_fef1ec_1x400.png" />
    <Content Include="Content\themes\base\images\ui-bg_highlight-soft_75_cccccc_1x100.png" />

Also, build/msbuild/deploy.proj file contains a bug that causes less tool to be incorrectly invoked:

diff --git a/build/msbuild/deploy.proj b/build/msbuild/deploy.proj
index fc9e4270f..fe0512870 100644
--- a/build/msbuild/deploy.proj
+++ b/build/msbuild/deploy.proj
@@ -266,7 +266,7 @@
       <LessFiles Include="@(LessFilesInclude)" Exclude="@(LessFilesExlude)" />
     </ItemGroup>
     <Exec Command="$(NuGetCommand) install dotless -Version 1.5.2 -OutputDirectory $(RootDir)packages" />
-    <Exec Command="$(LessCommand) -m &quot;%(LessFiles.FullPath)&quot; &quot;%(LessFiles-&gt;%(RootDir)%(Directory)%(Filename).min.css&quot;" />
+    <Exec Command="$(LessCommand) -m &quot;%(LessFiles.FullPath)&quot; &quot;%(RootDir)%(Directory)%(Filename).min.css&quot;" />^M
   </Target>
   <Target Name="CssMinify">
     <ItemGroup>

It will be kind of you to bring the master branch into consistent state

Carazyda commented 2 years ago

Hello @sergey-239 Thank you for your interest in our product and attention. We will fix this issue in the next release.