search

ONLYOFFICE / ControlPanel

Tools for administrating self-hosted ONLYOFFICE.
http://www.onlyoffice.com
Apache License 2.0
18 stars 13 forks source link

Incorrect string on rebranding page. #9

Open fz0000 opened 4 months ago

fz0000 commented 4 months ago

When I go to https://<onlyoffice.mydomain.com>/controlpanel/rebranding/, I found that the description text of dark theme logo is "light":

rebranding

That's because they use the same variable LogoDarkAbout. https://github.com/ONLYOFFICE/ControlPanel/blob/99248d6b77e6f2fef87c59f7423bfce7a350476b/web/www/views/rebrandingPartial.pug#L14 https://github.com/ONLYOFFICE/ControlPanel/blob/99248d6b77e6f2fef87c59f7423bfce7a350476b/web/www/views/rebrandingPartial.pug#L29

By the way, you may have noticed that the text of LogoDarkAbout is "light". The root cause is the incorrect text in the resource file:

https://github.com/ONLYOFFICE/ControlPanel/blob/99248d6b77e6f2fef87c59f7423bfce7a350476b/web/www/public/resources/CPWhiteLabelResource.json#L6-L9

Maybe a lot of Dark/Light related variables also have to be swapped, to resolve this issue completely...

Carazyda commented 4 months ago

Hello @fz0000 yes you are right. We will fix this in future releases.