ONLYOFFICE / DesktopEditors

An office suite that combines text, spreadsheet and presentation editors allowing to create, view and edit local documents
https://www.onlyoffice.com
Other
2.93k stars 332 forks source link

Spell Checking Functionality #1124

Closed kojq closed 1 year ago

kojq commented 1 year ago

This issue is unique.

Operating System

Linux (DEB package)

Version information

7.2.1

Expected Behavior

It should correct spelling of words incorrectly spelled.

Actual Behavior

Certain contractions, proper nouns, compound words, simple words, complex words, and archaic words are all marked incorrectly. An example from each category: doesn't, Pranay, candytuft, relatable, otorhinolaryngologist, accouchement. Perhaps most of these can be corrected and perhaps the proper nouns could have a different indicator of being misspelled (maybe indicated by a different color and/or shape).

Reproduction Steps

Type some words in a document. There at least a few dozen others I have tried that are marked as incorrect.

Additional information

No response

ShockwaveNN commented 1 year ago

Hi, for words with ' we got issue https://github.com/ONLYOFFICE/DocumentServer/issues/576

For any other words you listed seems they are not in dictionaries we use (we do not create our own) so I think simpler solution we'll be just to add them to ignore list

kojq commented 1 year ago

Hi, for words with ' we got issue https://github.com/ONLYOFFICE/DocumentServer/issues/576

:+1:

For any other words you listed seems they are not in dictionaries we use (we do not create our own) so I think simpler solution we'll be just to add them to ignore list

I see. Personally, even if I choose to write the blandest of papers, the spell checking is more of a hindrance than not. Would it be feasible to use another set of dictionaries or multiple sets of dictionaries if the current one will not be modified? I think an ignore list would be fine, but how would that be approached, as such a list would basically become another dictionary if it were to be even modestly expanded while it would be relatively useless if too few words were contained.

ShockwaveNN commented 1 year ago

I think if we found some other set of dicts some problems with another words will arise

My only advice - since this is an opensource project you can always try to change our dicts yourself or find a better alternative with better wording

kojq commented 1 year ago

Okay. I do not understand the purpose of every file within each of the subfolders of dictionaries and the structure seems a bit inconsistent. Is there some documentation or concise explanation? I noticed helpcenter and api on the site, but those do not seem helpful for this scenario. Also, when you mention that I can change the dictionaries, pull requests regarding this are fine?

HectorB-2020 commented 1 year ago

Some time ago I attempted to propose integration with commercial spell-checking tools (https://github.com/ONLYOFFICE/DocumentServer/discussions/1882) but my idea didn't impress developers.

ShockwaveNN commented 1 year ago

Is there some documentation or concise explanation?

Those are hunspell dictonaries files

Sorry, we have no documentation Quite frankly - we are quite small team and cannot provide solutions and guides for every user problem, we try to, but simply cannot So you need to do your own research how it works if you really want to do so, because I'm not aware how those dictonaries works

HectorB-2020 commented 1 year ago

@ShockwaveNN, is there a limit on document size when spell-checker stops working? I've got a document with 200+ pages and seems like spell-checker gave up on doing its job.

ShockwaveNN commented 1 year ago

I've got a document with 200+ pages and seems like spell-checker gave up on doing its job.

This is definitely a bug, please create a new issue with file example

kojq commented 1 year ago

It seems we are done discussing, so this issue can be closed :+1:.

HectorB-2020 commented 1 year ago

This is definitely a bug, please create a new issue with file example

@ShockwaveNN, another concerned Only Office user raised the same issue ONLYOFFICE/DocumentServer#2326. I'll appreciate if you'll look into this.

maruacat commented 1 year ago

@ShockwaveNN, another concerned Only Office user raised the same issue ONLYOFFICE/DocumentServer#2326. I'll appreciate if you'll look into this.

Hello @HectorB-2020 Thank you for contacting. We took a look at the user's issue ONLYOFFICE/DocumentServer#2326 and created a bug. Unfortunately, we haven't news regarding this ONLYOFFICE/DesktopEditors/issues/1124, so I think it can be closed.

Rita-Bubnova commented 1 year ago

I close this issue. Feel free to comment or reopen it if you got further questions.