ONLYOFFICE / DesktopEditors

An office suite that combines text, spreadsheet and presentation editors allowing to create, view and edit local documents
https://www.onlyoffice.com
Other
2.74k stars 317 forks source link

Spelling check language reset when typing #273

Open Dremor opened 4 years ago

Dremor commented 4 years ago

Hi.

I started to write a document in English, changed the document language to English, but spelling keep changing back to French (my default language) every time I hit the any key.

Best regards

Dremor commented 4 years ago

Test was done on the following setup: Windows 10 1903 ONLYOFFICE Desktop Editors version 5.4.1.33

Rita-Bubnova commented 4 years ago

Hello, @Dremor. The spellcheck language depends on the keyboard layout language and changes automatically in ONLYOFFICE Desktop Editors. Do I understand correctly that in your case spelling keep changing back to French when you enter text in the French layout?

ShockwaveNN commented 4 years ago

This issue was closed due to no response.

frumbert commented 4 years ago

The spellcheck language depends on the keyboard layout language and changes automatically in ONLYOFFICE Desktop Editors.

Are you sure thats the case? My mac is installed in English (Australia) Screen Shot 2020-03-24 at 6 47 33 pm Yet ONLYOFFICE launches in English (United States) Screen Shot 2020-03-24 at 6 48 48 pm

I've seen documents revert back to English (United States) after I'd changed it to Australian after every incorrectly spelled word is entered - inconsistently.

Dremor commented 4 years ago

Hello, @Dremor. The spellcheck language depends on the keyboard layout language and changes automatically in ONLYOFFICE Desktop Editors. Do I understand correctly that in your case spelling keep changing back to French when you enter text in the French layout?

@Rita-Bubnova Sorry for the late response. Yes, When I'm using my AZERTY keyboard, spell checking revert back to French every time. Aren't I allowed to write in another language than my own ? ๐Ÿ˜…

Rita-Bubnova commented 4 years ago

@Dremor, to be clear - you want that your default document spellchek language to be different from your keyboard language?

Dremor commented 4 years ago

Yes

-------- Message d'origine -------- On 24 mars 2020 ร  09:50, Rita-Bubnova a รฉcrit :

@Dremor, to be clear - you want that your default document spellchek language to be different from your keyboard language?

โ€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Rita-Bubnova commented 4 years ago

@Dremor, as I wrote above in ONLYOFFICE Desktop Editors, the spellchecking language depends on the keyboard layout. Also implemented in MS Word.

However, the our team will consider adding a setting that disables this (issue 35911 in our internal issue tracker).

Rita-Bubnova commented 4 years ago

@frumbert, could you issue a separate issue with your problem?

Dremor commented 4 years ago

@Rita-Bubnova By default, yes, but when I change to another language, it stay like this for the whole document, and don't revert back every work I type.

mwadd commented 4 years ago

Having the same issue and it is really annoying.

Document language is set to English (United States) Text language is set to English (same as above) Keyboard layout is Swedish and as soon as I start typing the text language changes to Swedish as well. So either I'm left without spellcheck (not a huge deal) or I have to change keyboard layout and start mashing keys when I need to find a non alphanumerical character, or go via Insert > Symbol.

MS Office (at least not when I used it in the past) and LibreOffice don't do this. I Would love a setting that changes this behavior since I very much prefer OO.

florianHofherr commented 3 years ago

Has there been any progress on this issue? I do think this is a major drawback of the otherwise fabulous Only Office. Having to change my keyboard layout every time I want to use it makes using it very unattractive.

darwin-brandao commented 3 years ago

I'm having the same problem and it's really annoying. I have to write in English, but my keyboard layout is Brazilian and it keeps setting the document language back to Brazilian Portuguese every time I type something. I'd like to be able to use the Spell Check, as I'm not a native English speaker, but I can't. It feels like I have to buy an American keyboard to write in English.

Dremor commented 3 years ago

Tbh, I just stopped to use Onlyoffice. I don't understand how this is considered as a normal behaviour to automatically change a setting that you specifically set yourself.

@Rita-Bubnova : I may have misunderstood previously. It is not the default spellchecker language that is affected, but the per document spellcheck language setting, which is reset after each keystroke (this is the bug).

mtcruz commented 3 years ago

I think this is an essential enhancement. People must be capable of writing in any language they want and get the desired spellcheck language using any keyboard layout. Here I will detail what is the behavior of ONLYOFFICE, LibreOffice and MS office, and give my personal opinion on which behavior allows for most productivity and flexibility.

ONLYOFFICE's behavior is very similar to LibreOffice (LO), that is, changing the keyboard layout while editing changes the spellcheck language automatically. The difference is that, for example, your system is set at using a Portuguese layout and the you open LO and set the spellcheck to US English, it will keep the spellcheck at US English, whilst ONLYOFFICE changes the spellcheck language back to Portuguese once you start writing. This makes it possible to use a keyboard layout different from the spellcheck language in LO, but not in ONLYOFFICE. Note, however, that once you change the system's keyboard layout while LO is open, its behavior becomes identical to that of ONLYOFFICE, such that you must restart LO to be able to spellcheck in a language different from the keyboard layout. On the other hand, the default behavior of MS office is that if you change the layout while writing the document (for example, from English to Portuguese), it also changes the spellcheck (to Portuguese, in the example), but if you change the spellcheck language (back to English), it does not change the spellcheck if you begin typing (with the layout still set to Portuguese). This makes spellchecking in a language different from the layout even easier than LO. This is also similar to spellchecking provided in many applications, including web browsers and IDEs.

My suggestion is to make ONLYOFFICE's default behavior similar to work similar to MS office, since its the one that provides the most flexibility, and maybe add an option to use the current behavior. If changing the default behavior is not possible, simply adding the option will help a lot. Even not adding the option but using LO's behavior will be great. People that use multiple languages in the same keyboard layout (which are not rare, specially on academia and software development) will greatly benefit from this.

This was written using a Portuguese keyboard layout with US English spellcheck provided by Chrome

Edit This issue is also mentioned in:

607, #626, #527

ShockwaveNN commented 3 years ago

@mtcruz Thank you for your very detailed analysis, I've shown this message to our dev team

Gribichex commented 2 years ago

Still no change unfortunately

biva commented 2 years ago

I just tested it with the latest version 7.0.0.127 and the issue is still there.

For information, @zilexa suggested a workaround in https://github.com/ONLYOFFICE/DesktopEditors/issues/607#issuecomment-859524732, but I'm not sure if this modifies only the default language, or this solves the current issue (which is not about the default language for templates, but that the spellcheck languages keeps being changed back to the default language, even if we change it manually).

zilexa commented 2 years ago

After updating, my solution changes are undone. So it's useless. Really crap software when you force US English upon the world.

For 2 years now!!!

ShockwaveNN commented 2 years ago

@zilexa Sorry for this situation, I've brought attention of our dev team back to this situation but can promise any results

The situation seems really complex and there is no one perfect solution

biva commented 2 years ago

Hello @ShockwaveNN Thanks for pushing this :) I'm just not sure to understand "there's no one perfect solution"? Do you mean that technically it's complex to find a solution? I'm just highlighting this because on the browser version (onlyoffice online, integrated with Nextcloud), there's no such issue.

ShockwaveNN commented 2 years ago

browser version (onlyoffice online, integrated with Nextcloud), there's no such issue.

That's because in browser version there is no possibility to detect system language and in browser spellcheck language is always selected manually

biva commented 2 years ago

I understand, thanks for the feedback. I don't know if I'm the only one, but I prefer to have the "detect system language" disabled than to be unable to change the spellcheck language. Would it be possible to deactivate the "detect system language", before a better solution is found?

ShockwaveNN commented 2 years ago

Would it be possible to deactivate the "detect system language", before a better solution is found?

This is part of discussion in 35911 but I raise attention to it also

zilexa commented 2 years ago

That's because in browser version there is no possibility to detect system language and in browser spellcheck language is always selected manually

That is your explanation why it is not working and very complex in the Desktop version? You do realize that makes no sense right? First of all, in Browser you can absolutely detect languages (both via Httpheader for preferred languages or through JavaScript to get content language, perhaps even more options). But the fact that you can detect it via the Desktop version also means you can choose what to do with that information. Btw with OnlyOffice Community Server I can simply edit a script file to set default language.

Sorry for this situation, I've brought attention of our dev team back to this situation but can promise any results

The situation seems really complex and there is no one perfect solution

Are you trying to make us look like fools? This has been forwarded to dev team earlier, in the past 1.5 years. Also, I've already proven in a previous post it is possible to change the default language of DesktopEditors, without changing code. With that information it should be trivial to workout the solution or at least prevent updates to undo the solution.

It is simply false information what you are sharing. Either that or you are bluntly copying what your devteam shared.

ShockwaveNN commented 2 years ago

Ok, I agree that you might be right in some parts and yes, I'm sharing some information from the dev team, because I'm not that good at understanding language mechanics in our app, you got me

And seriously I don't like your tone, I've done all that I need to be done as QA team member and I'm out of this issue, sorry

If someone really needs this feature/bug fixed - feel free to contact sales@onlyoffice.com and they can change our feature/bugfix priorities, but I - cannot

zilexa commented 2 years ago

My tone changes because the last 12 months I've been quite disappointed by numerous responses from the OnlyOffice teams. It's nothing personal. I just really do not understand where this project is trying to go limiting itself to US English users only.

I would go as far to guess that OnlyOffice online version is more popular outside the US.

ShockwaveNN commented 2 years ago

is trying to go limiting itself to US English users only.

No, we are not trying to, sorry if we got that look

But we are a commercial organization, first of all We got no money source outside our paid customers - so our priorities dictated by paying customers first

And we simply cannot implement all the features everyone wants, we're not that big as a team

And I got good news - we really hope to add an option to disable auto-spellcheck detection in v7.0.1 https://github.com/ONLYOFFICE/desktop-apps/commit/acb5d6ba42a43171d3369139022a77f260250fe1

It was only implemented yesterday, so we haven't properly tested it so as usual - no promises ) And this solves not all the problems that raised in this issue, but this is rather simple solution we can implement right now

biva commented 2 years ago

Congrats @ShockwaveNN ! Thank you for this :)

@zilexa I understand your frustration, and I have expressed it myself in non-friendly words in the past, notably for other open-source projects. It was a mistake and I regret it ๐Ÿ˜•. I think that the OnlyOffice team does its best to create a great open source and free software. And even if it doesn't go in the direction I want sometimes, am I really legit to criticize or be impatient? I don't think so, and I try to stay on the constructive side ๐Ÿ˜‰.

GHagui commented 2 years ago

Here's an annoying problem too. I am Brazilian who speaks Portuguese and I use an American keyboard. When writing Portuguese, but OnlyOffice switches to English. Please fix this and it's been 2 years now.

biva commented 2 years ago

Hello @ShockwaveNN , I see that https://github.com/ONLYOFFICE/desktop-apps/commit/acb5d6ba42a43171d3369139022a77f260250fe1 should be implemented in 7.0.1 and that we are at 7.1.1. Was it implemented now?

I see this in the settings: image

Is it the solution?

ShockwaveNN commented 2 years ago

This issue has 30 comments ) This is an option to disable spelling detection. but there is still issues in spelling detection mentioned earlier

LudoTexx commented 1 year ago

End of November 2022 and I still have this problem. I set my document in French (AZERTY keyboard, US windows lang). Every time I press [ENTER] the document changes to US automatically. Someone in the dev team really think this could be a useful feature for peoples?

delcier commented 1 year ago

Just started using OnlyOffice and this is a deal breaker for me - I write in several different languages regularly. Will have to switch to another suite until this is resolved. Pity, because otherwise I really enjoyed using OO.

Euchale commented 1 year ago

Adding to the people here who write documents in multiple languages. I write documentation in english and regular text in German, and since my keyboard is German it keeps changing back to German. There is no reason why writing on my keyboard should overwrite an option I specifically selected. Why have "Set Text language" at all, if it just gets overwritten?

BrokenDraft commented 6 months ago

Hi !

Adding some noise to this feature requests.

The language barrier set by every single Office tool is a nightmare for me as I switch between French and English one document to another. All the Microsoft Office suite does it and I hate it.

I am quite surprised to read a lot of answers mentionning how "Microsoft Words does it like that too", when in fact, this feature is hated by any bilingual writer out there...

So yep, a single toggle to turn off the auto switch would be just enough. I just wanna set the language on a per document basis and it should STAY this way.

arek-b commented 1 month ago

Just installed the latest version and this bug is still here and is extremely infuriating. Please fix this, it makes OnlyOffice next to impossible to use!

Edit with more information: I am trying to type in Polish and my document language is set to Polish, yet whenever I type any character, the spellcheck language immediately changes back to English no matter what. My OS is Windows 11 and I'm using the English (United States) keyboard, albeit with the Polish (Programmers) layout. I managed to temporarily work around the issue by installing the Polish language for my OS and switching to the Polish keyboard. Now I can type in Polish and the spellcheck language doesn't switch back to English. This bug still needs a fix though.