Closed LeSuisse closed 1 year ago
Hi @LeSuisse, could you merge changes from release/v7.3.0
into you branch, I edited the PR and changed the branch to fit the development process.
Done, thanks for updating the PR.
Hum what am I supposed to do?
The PR was updated to target the branch release/v7.3.0
and this branch just got deleted.
The issue is still present in the master
and development
branches 🤷
Hi @LeSuisse, I'm so sorry for this situation, do you have a possibility of changing the PR branch to hotfix/v7.3.3? Then I could reopen the pull request and merge it immediately.
I have rebased the patch on top of hotfix/v7.3.3
branch https://github.com/LeSuisse/Docker-DocumentServer/commits/jwt-secret-too-small-hmac-sha256
Since the PR is closed I cannot change the target branch.
@LeSuisse, could you fire the new pull request into the ONLYOFFICE/hotfix/v7.3.3
branch?
Done in #582
The key that is automatically generated weaken the security strength. As noted in RFC7518 section 3.2:
Some JWT libraries are rejecting by default keys that are too small in a attempt to prevent misusages so generating a key that does not respect the minimal length can be problematic for OO integrations.