search

ONLYOFFICE / DocumentServer

ONLYOFFICE Docs is a free collaborative online office suite comprising viewers and editors for texts, spreadsheets and presentations, forms and PDF, fully compatible with Office Open XML formats: .docx, .xlsx, .pptx and enabling collaborative editing in real time.
https://www.onlyoffice.com
GNU Affero General Public License v3.0
4.87k stars 1.09k forks source link

WOPI discovery of onlyoffice supports embeddded param, but actually not works #1725

Closed zyf0330 closed 2 years ago

zyf0330 commented 2 years ago

Do you want to request a feature or report a bug? bug What is the current behavior? The urlsrc in the wopi hosting/discovery xml gives <e=EMBEDDED&> query param, but it doesn't work. Returned preview page is still desktop type. If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.

  1. use urlsrc given in the wopi hosting/discovery xml to construct a url
  2. set e param in the url to true
  3. do POST request with url
  4. preview returned doc page What is the expected behavior? The doc page should be previewed as embedded mode instead of desktop mode.

The type property at root level of the config in the response HTML of POST request is desktop which should be embedded.

Did this work in previous versions of DocumentServer? no DocumentServer version: 7.0 Operating System: Linux Ubuntu Browser version: Google Chrome v100

igwyd commented 2 years ago

Hello @zyf0330 We added embedded mode because our editors have it, but it's not fully implemented in wopi yet. We have issue 56772 in our private issue tracker.

igwyd commented 2 years ago

It's fixed at: https://github.com/ONLYOFFICE/server/commit/6331a5b672d04d807a50020f0200b8fffd0b3c07 https://github.com/ONLYOFFICE/web-apps/commit/92bb952875aaee5057f8b0e73faa08e648e78344 And will be released in the next major release

ShockwaveNN commented 2 years ago

DocumentServer v7.2 is released. This issue should be fixed

Feel free to comment or reopen it if you got further questions

zyf0330 commented 2 years ago

Ok. May I know When the feature will be released?

On Thu, Apr 21, 2022, 20:37 Igor Demin @.***> wrote:

Hello @zyf0330 https://github.com/zyf0330 We added embedded mode because our editors have it, but it's not fully implemented in wopi yet. We have issue 56772 in our private issue tracker.

— Reply to this email directly, view it on GitHub https://github.com/ONLYOFFICE/DocumentServer/issues/1725#issuecomment-1105156773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3HTAP7UPJOTMGWN6CHGZ3VGFDYLANCNFSM5TU5SVHQ . You are receiving this because you were mentioned.Message ID: @.***>

ShockwaveNN commented 2 years ago

It is released in v7.2.0 several weeks ago