search

ONLYOFFICE / DocumentServer

ONLYOFFICE Docs is a free collaborative online office suite comprising viewers and editors for texts, spreadsheets and presentations, forms and PDF, fully compatible with Office Open XML formats: .docx, .xlsx, .pptx and enabling collaborative editing in real time.
https://www.onlyoffice.com
GNU Affero General Public License v3.0
4.87k stars 1.09k forks source link

Document server key becomes invalid immediately after sending request to callbackUrl, while storage service is not ready #513

Open phandd opened 5 years ago

phandd commented 5 years ago

Do you want to request a feature or report a bug? Asking, if no solution then request a feature

What is the current behavior? Every time document server send a request (with status = 2) to storage service in order to save the document, the key becomes invalid in document server.

While the storage service is saving the file, there can be some users trying to open the file, and the key is not generated as anew until storage service saves the file successfully, so the key in payload send back to client browser still the old key, while the key already became invalid on document server => Error

What is the expected behavior? Have some config to decide when the key becomes invalid in document server (ex. by the response from callbackUrl request)

Did this work in previous versions of DocumentServer? No

DocumentServer version: 5.2.8

Operating System: Ubuntu 18.04

ShockwaveNN commented 5 years ago

@phandd Hi, we are planning to redone all key generation logic and we are aware of your problem and try to fix it in future, but currently have no ETA

phandd commented 5 years ago

@ShockwaveNN cool, thank you. Looking forward to it. I think for now I will have to prevent the user from accessing the document while it being saved to storage service. You guys have done a great work btw ;)