ONLYOFFICE / DocumentServer

ONLYOFFICE Docs is a free collaborative online office suite comprising viewers and editors for texts, spreadsheets and presentations, forms and PDF, fully compatible with Office Open XML formats: .docx, .xlsx, .pptx and enabling collaborative editing in real time.
https://www.onlyoffice.com
GNU Affero General Public License v3.0
4.75k stars 1.07k forks source link

Undo-Redo in fast co-edit mode #870

Open fangjialong2019 opened 4 years ago

fangjialong2019 commented 4 years ago

We are using your community version of OnlyOffice Document Server

We have some problems, as follows:

  1. It is impossible to undo and redo the multi-player collaboration in the fast mode.

2, the skin is not very beautiful, not friendly to the Chinese,It is best to be able to provide a UI similar to WPS or MS Office.

3, Use the mouse to move the scroll bar, can make the table move smoothly? Not move by row step.

If you can help us solve the above problems, we may consider buying the paid version.

If the above request can be solved, please tell us the price.

The same content was sent to sales@onlyoffice.com

fangjialong2019 commented 4 years ago

Hope to reply as soon as possible.

Rita-Bubnova commented 4 years ago

Hello, @fangjialong2019. Thank you for report.

  1. I can confirm - this is a enhancement, issues 45357, 45358, 45359, 45360 in our internal issue tracker.
  2. Would you report in more detail what it means "the skin is not very beautiful, not friendly to the Chinese"?
  3. To this question I answered you here https://github.com/ONLYOFFICE/DocumentServer/issues/736#issuecomment-627229111
fangjialong2019 commented 4 years ago

@Rita-Bubnova Excuse me, What does ETA mean?

To the second question,the people around us are used to using Google Doc and MS Office, so we want OnlyOffice to have a similar experience.

To the third question,You asked me to contact sales to speed up it.
it means we can paid for it to spped up?

fangjialong2019 commented 4 years ago

@Rita-Bubnova To the Undo-Redo question , This is my solution as follows. The following upgrade files enable Excel‘s undo-redo functionality. Usage: Place the file in the sdkjs.cell directory and compile it with the api files.And then modify the webapp. Spreadsheeteditor. Main. Js file, and start it in the function of onDocumentContentReady

Results: Most of cases have been supported Undo-Redo in fast co-edit mode.But in rare cases, data can be lost and we can't reproduce it

cell-api-upgrade.zip

Rita-Bubnova commented 4 years ago

@fangjialong2019. ETA this is the abbreviation for Estimated time of arrival, that is, we cannot tell the deadline for the implementation this enhancement.

To the second question,the people around us are used to using Google Doc and MS Office, so we want OnlyOffice to have a similar experience.

This is very general statement, I don't know that you really mean by this. And we can try to add feature you're missing, but we are separate product from MS Office and never be the same.

To the third question,You asked me to contact sales to speed up it. it means we can paid for it to spped up?

I think so, you should discuss any feature you want to pay with sales team, money questions is out of my responsibilities.

fangjialong2019 commented 4 years ago

@Rita-Bubnova To the Undo-Redo question for word and slide. Usage is similar to cell.

word-slide-upgrade.zip

fangjialong2019 commented 4 years ago

@Rita-Bubnova

UI is not a big problem, we can add skins based on source code of the community version. Thank you for your contribution to open source.

If possible, please help me to check my solution to the question of Undo-Redo

ShockwaveNN commented 4 years ago

Currently our dev team is not ready to implement undo-redo in fast co-edit As you mention in your case data loss can happen and this code cannot be released in production-ready solution as ours

And since our dev team is not ready - I don't think any one in our team can provide you help with your solution

fangjialong2019 commented 4 years ago

@ShockwaveNN I hope you can solve this problem quickly, and you can refer to my solution, because it works fine most of the time.

RuslanGabbasov commented 3 years ago

@ShockwaveNN In strict collaborative mode, that we should to use because otherwise collaborative usage of spreadsheets is dangerous, data loses very often too. In the reason of network connection lost or computer goes into sleep mode when user write something without manual saving. Most of our clients denied of use spreadsheet editor in OnlyOffice only because of this. I think you should increase priority of this feature to absolutely immediately important level.

ShockwaveNN commented 3 years ago

@RuslanGabbasov Sorry to hear this

As far as I understand it - implementing undo-redo in co-edit mode is pretty complicated task, so I think it's main reason why it's still not implemented

A shown your report to our dev team, but I'm not in position to change priorities of features to implement

fangjialong2019 commented 3 years ago

@RuslanGabbasov For this reason, we purchased WPS WebOffice

biva commented 3 years ago

Dear @ShockwaveNN and @Rita-Bubnova Thank you for this great OnlyOffice: our team is really impressed by the quality, the reactivity and the look of your solution :) We love it. The undo-redo feature in fast co-editing mode would really be great indeed. I understand it's not an easy task, but do you have some good news in this regard? Thank you again !

ShockwaveNN commented 3 years ago

@biva Sorry, no news

Since we are in no control of priority of this task - if this is very important for you - you can try to contact sales team at sales@onlyoffice.com and discuss it

biva commented 3 years ago

@ShockwaveNN thanks for your quick feedback: it's not that urgent, it's just that I pressed Ctrl+Z several times and was surprised to not see this working ;) I understand: you have to deal with priorities. I hope it will come soon :) And congrats again for your great product, it's even better than Google Sheet!

ImaCrea commented 3 years ago

Hello dear people at OnlyOffice.

another message here to tell you this cmd+z feature is much needed here also. Especially on spreadsheet where people work on formulas and complex data.

Users feedbacks we collected go along these lines:

From what I understand, there's a technical challenge behind that which seems quiet big. That might explain this complicated experience and why you haven't been able to prioritize that issue for the moment.

I understand technically it's complicated at the moment to prioritize and this is not in your backlog (or maybe it changed since latest message here?), but maybe we could find an intermediate solution by focusing on ux side first?

I'm curious if you thought about such angle to try to solve that problem?

ShockwaveNN commented 3 years ago

@ImaCrea Thanks for your detailed explanation, I've pointed out it to our UX team, maybe they have some ideas

biva commented 3 years ago

Hello @ShockwaveNN , would you have any good news on this issue?

ShockwaveNN commented 3 years ago

Sorry no news

ImaCrea commented 2 years ago

Sorry no news

Still no news by any chance? ^^'

ShockwaveNN commented 2 years ago

@ImaCrea Sorry, no news. This is a very-very complicated task and currently not our top priority. If you want to discuss our priorities - feel free to contact sales@onlyoffice.com

ImaCrea commented 2 years ago

@ImaCrea Sorry, no news. This is a very-very complicated task and currently not our top priority. If you want to discuss our priorities - feel free to contact sales@onlyoffice.com

Alright, I'll think about it. Do you have a public roadmap somewhere by any chance please?

ShockwaveNN commented 2 years ago

@ImaCrea Yes, we have It's not always most actual one, but it's the best we can provide

ImaCrea commented 2 years ago

Hello there,

We're on 6.4.2 and I can confirm Undo-Redo is now working on fast co-edit mode for docx and pptx. This is great news.

Would be amazing when it work for xlsx!

Rita-Bubnova commented 2 years ago

@ImaCrea, Sorry, I don't think you're right about the Redo part

I'll try to clarify once more about Undo / Redo in fast co-edit mode (bugs from the comment).

Undo works in the Document and Presentation Editors. Bug 45359 - Add Undo to the Spreadsheet Editor. Redo doesn't work in Document, Spreadsheet and Presentation Editors. These are bugs 45357, 45360 and 45358 in our private issue tracker.

yurkobb commented 2 years ago

I see that in the desktop version of the spreadsheet editor (v. 7.1.0.215) Undo & Redo works in Fast co-editing mode (that is great news!). Is it coming to the web version as well?

EDIT: Sorry, I was confused - it works in both online and desktop version, but only within a single cell while editing its contents, not in the general case.

ShockwaveNN commented 2 years ago

@yurkobb Yes, this issue is still unresolved fully

PasserDreamer commented 2 years ago

I don't know how OnlyOffice implemented this function. How about follow what git do? IMO, every change is a commit, everyone who is opening the file must sync to head before save changes (branch migration). Undo and Redo also as a new commit.

pierreozoux commented 2 years ago

@PasserDreamer this is a hard problem to solve, read that for a bit of background. https://stackoverflow.com/questions/26694359/differences-between-ot-and-crdt (I don't know what oo is using, but probably not git, and it is probably not a good idea to use git)