search

ONLYOFFICE / docker-onlyoffice-owncloud

MIT License
98 stars 32 forks source link

outdated reference to owncloud/nextcloud app #27

Open OlivierBondu opened 5 years ago

OlivierBondu commented 5 years ago

Hi,

it seems the reference to the onlyoffice owncloud app points to commit 262ce12, which is from September 2017, while the actual app has seen some development since.

This caused some trouble but the fix was quite simple, though after a lot of digging: it suffice to comment out this line: https://github.com/ONLYOFFICE/docker-onlyoffice-owncloud/blob/573ccea807ddbaaa731a46c34bdd4cf3d6a0943f/set_configuration.sh#L14

then the script goes and fetch the latest app instead of the outdated one.

Hope this helps, thanks for the nice project !

LinneyS commented 5 years ago

https://github.com/ONLYOFFICE/docker-onlyoffice-owncloud/blob/573ccea807ddbaaa731a46c34bdd4cf3d6a0943f/set_configuration.sh#L14 If you comment out this line, how will the ONLYOFFICE app appear in ownCloud?

The instructions indicate the update modules during installation.

git submodule update --remote
LinneyS commented 5 years ago

Updated submodules ad7410d86291b2f03f5d78120123466c26709c8b

OlivierBondu commented 5 years ago

My use case was nextcloud, where the app is in the store, so no need to copy the files manually, just 'enabling' the app does the magic apparently (which seems rather less pain than manually updating this repo every time a new version of the app is available)

LinneyS commented 5 years ago

Remade to use the command app:install in Nextcloud

OlivierBondu commented 5 years ago

thanks!