search

ONLYOFFICE / onlyoffice-nextcloud

The app which enables the users to edit office documents from Nextcloud using ONLYOFFICE Document Server, allows multiple users to collaborate in real time and to save back those changes to Nextcloud
GNU Affero General Public License v3.0
559 stars 158 forks source link

GetEditorsCheckInterval now check system value properly. #960

Closed adriangibanelbtactic closed 6 months ago

adriangibanelbtactic commented 6 months ago

editors_check_interval check fix

Introduction

This aims to fix: https://github.com/ONLYOFFICE/onlyoffice-nextcloud/issues/864 bug.

Specifically the part where the editors_check_interval value keeps getting ignored.

I think that the setting is coming as an string type and that's why it wasn't checked properly.

How to turn this on

php occ config:system:set onlyoffice editors_check_interval --value=0

given that:

php occ config:app:set onlyoffice editors_check_interval --value=0

won't be read at all by the current code.

Debug help

Note that I have not been able to check this in a cron scenario because I'm not sure how to force that same cron to be run. Were you to give some clues on how to force the app's cron or whatever triggers the JobListController.php controller to do its thing I would double-check this thanks to some debug to the nextcloud.log file.

About previous code

So the previous when interval was set to 0 it always changed that value to 86400 while ignoring the requested 0 value.

LinneyS commented 6 months ago

@adriangibanelbtactic thanks for the help Please check this version of the problem fix #965

adriangibanelbtactic commented 6 months ago

@adriangibanelbtactic thanks for the help Please check this version of the problem fix #965

That's arguably better than my pull request and it's already merged.

Closing this pull request.