ONNC / onnc

Open Neural Network Compiler
https://onnc.ai
BSD 3-Clause "New" or "Revised" License
514 stars 92 forks source link

[bug] ComputeGraph dfs and bfs graph traverse bug #66

Open cycheng opened 6 years ago

cycheng commented 6 years ago

Test Case:

onnc::Module module; IRBuilder builder(module); ComputeGraph& cg = *builder.CreateComputeGraph("top-level");

ComputeOperator op1 = builder.AddComputeOp(); ComputeOperator op2 = builder.AddComputeOp(); ComputeOperator op3 = builder.AddComputeOp(); ComputeOperator op4 = builder.AddComputeOp();

// op1 op2 // \ /
// op3 // | // op4 cg.addOperand(op1, op3); cg.addOperand(op2, op3); cg.addOperand(op3, op4);

Expect dfs traversing output: op1 op3 op4 op2 Actual output: op1

lubatang commented 6 years ago

Got it. I'll write a unittest and resolve it.