search

ONSAS / ONSAS.jl

An Open Nonlinear Structural Analysis Solver in Julia
MIT License
7 stars 1 forks source link

Error on "using ONSAS.DynamicState" #491

Closed tkrisnguyen closed 2 months ago

tkrisnguyen commented 2 months ago

Hello,

I just rerun dynamic_analyses.jl, but with the command

using ONSAS.DynamicStates

the following error appear:

ERROR: UndefVarError: DynamicStates not defined

How can I resolve this problem?

Thank you.

mvanzulli commented 2 months ago

Hey there, currently dynamic analysis is not supported. We have issues to start address this according to ONSAS.m implementation. Im happy to have a quick chat if you are keen.

tkrisnguyen commented 2 months ago

I'm happy to involve in (solving) this issue.

mvanzulli commented 2 months ago

Thank you so much for your motivation. I think currently we are not planning to extend the capabilities of this package to solve dynamic analysis. You can use ONSAS.m which is validated and has multiple algorithms to solve dynamic analysis.

Regarding the issue, can you provide the code to reproduce the issue. If a execute julia --project test/structural_analyses/dynamic_analyses.jl form ONSAS root folder then works fine. Seems that you are trying to use the REPL, since ONSAS exports DynamicStates modules @reexport using .DynamicStates make sure you have instantiated the ONSAS environemnt julia --project=. from the root.

mvanzulli commented 2 months ago

If you want, you can submit an MR adding the following comment in dynamic_analysis.jl and DynamicStates if that helps: 

"""
WARNING: These test files are placeholders for future development of Dynamic Analysis in ONSAS.jl but are not currently supported.
"""
tkrisnguyen commented 2 months ago

What is "an MR"? I am sorry for this newbee question.

mvanzulli commented 2 months ago

Oh sorry I didn't clarify that in the first place. I meant a pull request. But is just optional if you want to contribute just adding this comment into the files. Since this is not an issue I think we can close it :)