ONSdigital / SDG_11.2.1

Analysis for the UN Sustainable Development Goal 11.2.1
https://onsdigital.github.io/SDG_11.2.1/
Apache License 2.0
5 stars 7 forks source link

Update and improve the process diagram #227

Closed jwestw closed 2 years ago

jwestw commented 2 years ago

The process diagram which is currently in the README is a low quality image and is somewhat out of date and incorrect in a few places.

nkshaw23 commented 2 years ago

First draft with new format attached. Based on original flowchart, #221 and looking through _main module.

Points to note:

Created using Gliffy (drag and drop - available through confluence) so change to layour and formatting are very easy to undertake.

SDG_POC

jwestw commented 2 years ago

Hi @nkshaw23 thank you again for doing this. It's great!

I have some ideas and comments here for you to consider.

Note: later we will get rid of this loop, but I don't plan to do that until after version 1.0, because it works.

Looking forward to getting this ticket closed off and this much improved diagram integrated into the new project webpage!

nkshaw23 commented 2 years ago

Comments below:

SDG_POC (1)

nkshaw23 commented 2 years ago

05km vs 1km buffer added

SDG_POC (2)

jwestw commented 2 years ago

@nkshaw23 Sorry but we have realised that the urban/rural split is not actually a disaggregation. Could you take that out please? Call me to discuss.

nkshaw23 commented 2 years ago

@james-westwood updated

SDG_POC (3)

jwestw commented 2 years ago

@james-westwood updated

Perfect!

Antonio-John commented 2 years ago

-We need to add an extra step between disaggregation & share of population with convenient access to public transport. -This step would reflect how we count up the OA's to get our LA calculation.

Antonio-John commented 2 years ago

Change for loop LA box to reflect:

nkshaw23 commented 2 years ago

Made some changes based on comment above.

SDG_POC (6)

jwestw commented 2 years ago

I think the improvement of this diagram is finished for now. So we can close this ticket. #254 will bring the diagram into the Sphinx pages.