Restrict las to just england and wales

[nkshaw23]

Pull Request submission

Updated main so that only LA from england and wales are included in the process. Turns out this was already done for Scotland data, so kept the code pretty much the same for consistency.

Note: This branch was based off master (which hasnt had linted code (#337) merged in yet). So lines added are okay, but rest of the code isn't. Didn't seem worth linting everything when this has already been done.

Note2: cleaning_up_master branch has to be merged first as this contains code to correct the gitkeep issue which will stop the pipeline from starting

Closes or fixes

Fixes #343

Code

• [x] Requirements My/our code matches the requirements of the ticket
• [x] Functionality: New functions meet requirements in issue ticket
• [x] Compliant Code Code is as PEP 8 compliant as I can humanly make it
• [x] Code runs The code runs on my machine
• [ ] Clean Code (see description above)
  • [ ] Code has been linted (use your favourite linter)
  • [ ] Code adheres to DRY

Documentation (N/A)

Any new code includes all the following forms of documentation:

• [ ] Function Documentation Docstrings within the function(s') definition(s) have been created
  • [ ] Includes parameters and returns for all major functions
  • [ ] Includes data types
• [ ] Updated Documentation: Working doc has been updated and a new ticket to update the master documentation has been created.

Data (N/A)

• [ ] All data needed to run this script has been added to Sync

Testing (N/A)

• [ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

---

Peer Review Section

• [ ] All requirements install from (updated) requirements.txt
• [ ] Documentation has been created and is clear - check the google Doc
• [ ] Doctrings (Google format) have been created and accurately describe the function's functionality
• [ ] Unit tests pass, or if not present a new ticket to create tests has been created
• [ ] Code runs The code runs on reviewer's machine

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.

• [ ] I recommend merging this request.

---

Review comments

Insert detailed comments here!

These might include, but not exclusively:

• bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?)
• alternative methods (could it be written more efficiently or with more clarity?)
• documentation improvements (does the documentation reflect how the code actually works?)
• additional tests that should be implemented (do the tests effectively assure that it works correctly?)
• code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

[jwestw]

I will pull the code and run it for checking.

[jwestw]

Because the pop_year has changed my Whole Nation Pop file needs to be built.

I forgot about these messages so it was a surprise to see:

Nice to see it working well.

However it might be worth putting the .feather files on Sync, because it takes ages to (re)build from the population estimates Excel files.

[jwestw]

I hit a lot of problems along the way because I was missing data and the pop year had changed but I got the code to run now.