When la_pop_df was created, no geomtery or CRS was defined. This layer undergoes an intersection and so we cant be 100% sure that the correct points are being filtered during the intersection if the layer is not in the correct CRS.
BNG CRS added, and correct geometry selected (the layer has two for some reason) to ensure pop weighted centroids are used, not the polygon boundary.
Closes or fixes
Fixes #345
Code
[x] Requirements My/our code matches the requirements of the ticket
[x] Functionality: New functions meet requirements in issue ticket
[x] Compliant Code Code is as PEP 8 compliant as I can humanly make it
[x] Code runs The code runs on my machine
[x] Clean Code
[ ] Code has been linted (use your favourite linter)
Pull Request submission
When
la_pop_df
was created, no geomtery or CRS was defined. This layer undergoes an intersection and so we cant be 100% sure that the correct points are being filtered during the intersection if the layer is not in the correct CRS.BNG CRS added, and correct geometry selected (the layer has two for some reason) to ensure pop weighted centroids are used, not the polygon boundary.
Closes or fixes
Fixes #345
Code
Documentation (N/A)
Any new code includes all the following forms of documentation:
parameters
andreturns
for all major functionsData (N/A)
Testing (N/A)
Peer Review Section
requirements.txt
Final approval (post-review)
The author has responded to my review and made changes to my satisfaction.
Review comments
Insert detailed comments here!
These might include, but not exclusively:
Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.