ONSdigital / SDG_11.2.1

Analysis for the UN Sustainable Development Goal 11.2.1
https://onsdigital.github.io/SDG_11.2.1/
Apache License 2.0
5 stars 7 forks source link

Add geometry to la_pop_df #346

Closed nkshaw23 closed 1 year ago

nkshaw23 commented 1 year ago

Pull Request submission

When la_pop_df was created, no geomtery or CRS was defined. This layer undergoes an intersection and so we cant be 100% sure that the correct points are being filtered during the intersection if the layer is not in the correct CRS.

BNG CRS added, and correct geometry selected (the layer has two for some reason) to ensure pop weighted centroids are used, not the polygon boundary.

Closes or fixes

Fixes #345

Code

Documentation (N/A)

Any new code includes all the following forms of documentation:

Data (N/A)

Testing (N/A)


Peer Review Section

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.


Review comments

Insert detailed comments here!

These might include, but not exclusively:

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.