ONSdigital / SDG_11.2.1

Analysis for the UN Sustainable Development Goal 11.2.1
https://onsdigital.github.io/SDG_11.2.1/
Apache License 2.0
5 stars 7 forks source link

Look into PWC in Buffered Stops method #347

Closed jwestw closed 1 year ago

jwestw commented 1 year ago

We have looked into what is currently happening in the NI data processing to calculate if an OA is served or not.

jwestw commented 1 year ago

The problem may be at the stage when the geodataframe is created. gpd is not being forced to use the points in the population dataframe and instead it's defaulting to use the OA boundaries. i.e. it's using the geometry column as default to build the layer

nkshaw23 commented 1 year ago

Early investigations show that the PWC dataset ni_pop_wtd_centr_df loaded in line 102 is actually a polygon which implies that pwc_with_pop is a polygon. This df is used in only_la_pwc_with_pop which gets used in the intersection.

Image bewlow shows PWC for E/W/S loaded as points, and PWC for NI loaded as polygons

image

nkshaw23 commented 1 year ago

Line 97 in SDG_NI: Replace path to OA_ni with path to PWC NI dataset

paigeh-fsa commented 1 year ago

I think we can close this now as I have fixed the NI issue with the new dataset @nkshaw23 provided.