304 produce aggregate estimate ni

[paigeh-fsa]

Pull Request submission

I have put the aggregate estimate for NI here. I have not addressed all of the tasks in the ticket, see #356, this will be done in another ticket.

As part of this ticket, I have downloaded a new package to convert latitude and longitude coordinates to BNG. For this, you need to install the package convertbng, which is also in the requirements.txt.

I would redownload all NI datasets to run this ticket as the majority of NI data has changed quite a bit over recent weeks.

I still need to write some methodological changes here and will edit here when this has been done.

Closes or fixes

Fixes #

Code

• [ ] Requirements My/our code matches the requirements of the ticket
• [ ] Functionality: New functions meet requirements in issue ticket
• [ ] Compliant Code Code is as PEP 8 compliant as I can humanly make it
• [ ] Code runs The code runs on my machine
• [ ] Clean Code
  • [ ] Code has been linted (use your favourite linter)
  • [ ] Code adheres to DRY

Documentation

Any new code includes all the following forms of documentation:

• [ ] Function Documentation Docstrings within the function(s') definition(s) have been created
  • [ ] Includes parameters and returns for all major functions
  • [ ] Includes data types
• [ ] Updated Documentation: Working doc has been updated and a new ticket to update the master documentation has been created.

Data

• [ ] All data needed to run this script has been added to Sync

Testing

• [ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

---

Peer Review Section

• [x] All requirements install from (updated) requirements.txt
• [x] Documentation has been created and is clear - check the google Doc
• [x] Doctrings (Google format) have been created and accurately describe the function's functionality
• [ ] Unit tests pass, or if not present a new ticket to create tests has been created
• [x] Code runs The code runs on reviewer's machine

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.

• [x] I recommend merging this request.

---

Review comments

Insert detailed comments here!

These might include, but not exclusively:

• bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?)
• alternative methods (could it be written more efficiently or with more clarity?)
• documentation improvements (does the documentation reflect how the code actually works?)
• additional tests that should be implemented (do the tests effectively assure that it works correctly?)
• code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.