340 change age bands in scotland

[paigeh-fsa]

Pull Request submission

I have created an if statement in data_transform.py which handles any instances where the bins are larger than 90+. It should be generalised to work with any time that there are more bins over 90. I also changed the renaming of columns in scotland.py.

Closes or fixes

Fixes #

Code

• [x] Requirements My/our code matches the requirements of the ticket
• [x] Functionality: New functions meet requirements in issue ticket
• [x] Compliant Code Code is as PEP 8 compliant as I can humanly make it
• [x] Code runs The code runs on my machine
• [x] Clean Code
  • [ ] Code has been linted (use your favourite linter)
  • [ ] Code adheres to DRY

Documentation

Any new code includes all the following forms of documentation:

• [x] Function Documentation Docstrings within the function(s') definition(s) have been created
  • [x] Includes parameters and returns for all major functions
  • [ ] Includes data types
• [ ] Updated Documentation: Working doc has been updated and a new ticket to update the master documentation has been created.

Data

• [ ] All data needed to run this script has been added to Sync

Testing

• [ ] Unit tests Unit tests have been created and are passing or a new ticket to create tests has been created

---

Peer Review Section

• [x] All requirements install from (updated) requirements.txt NA
• [x] Documentation has been created and is clear - check the google Doc NA
• [x] Doctrings (Google format) have been created and accurately describe the function's functionality NA
• [x] Unit tests pass, or if not present a new ticket to create tests has been created
• [x] Code runs The code runs on reviewer's machine

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.

• [x] I recommend merging this request.

---

Review comments

Insert detailed comments here!

These might include, but not exclusively:

• bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?)
• alternative methods (could it be written more efficiently or with more clarity?)
• documentation improvements (does the documentation reflect how the code actually works?)
• additional tests that should be implemented (do the tests effectively assure that it works correctly?)
• code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

[Antonio-John]

I will review :)

[Antonio-John]

Review comments Insert detailed comments here!

The age_bin list needs updating in line 249. Currently it has all the old age bins. So, when these are being read into the served_proportion_disag function it doesn't recognise some of the age bins.

It would be better to make the function age_bin to return something. This is the function contained within data_ingest in bin_pop_ages.

These might include, but not exclusively:

bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?) alternative methods (could it be written more efficiently or with more clarity?) documentation improvements (does the documentation reflect how the code actually works?) additional tests that should be implemented (do the tests effectively assure that it works correctly?) code style improvements (could the code be written more clearly?) Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

[Antonio-John]

The function _age_bin is correctly defined, however when it's being used it needs to be assigned a variable.

[paigeh-fsa]

@Antonio-John I think I have now addressed all your comments, let me know if there is anything else :)