ONSdigital / SDG_11.2.1

Analysis for the UN Sustainable Development Goal 11.2.1
https://onsdigital.github.io/SDG_11.2.1/
Apache License 2.0
5 stars 7 forks source link

fixing so buffers are applied correctly #377

Closed Antonio-John closed 1 year ago

Antonio-John commented 1 year ago

Pull Request submission

I have added in capacity_type staying in main.py. Also, the buffer_points function has now got error checking so that if a value of capacity_type is not high or low it will throw an error.

Closes or fixes

Fixes #376

Code

Documentation

Any new code includes all the following forms of documentation:

Data

Testing


Peer Review Section

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.


Review comments

Insert detailed comments here!

These might include, but not exclusively:

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

Antonio-John commented 1 year ago

One comment in code

Good spot. Code runs fine for me & all geo_spatial buffers are non blank.